GitLab

https://bugzilla.redhat.com/show_bug.cgi?id=1103325

Chris Lee authored Apr 04, 2014 and Bastien Nocera committed Apr 07, 2014

If the OPF file is in the root dir, g_path_get_dirname returns "."
instead of an empty string. This results in an invalid key for the cover
image, because it looks like "./OEBPS/cover_path.jpg" instead of
"OEBPS/cover_path.jpg" and then unzipping for that path fails.

We were never checking the retval of get_cover_img_num() so if
no covers were found, we'd try to read index-of-first-img minus 1.

Chris Lee authored Nov 13, 2013 and Bastien Nocera committed Nov 13, 2013

The image data isn't encrypted, so we can still generate thumbnails.

http://wiki.mobileread.com/wiki/MOBI#MOBI_DRM

It's useless doing so, and only leads to confusion.

This stops a crash in the thumbnailer if the cover cannot
be found.

This makes it easier to debug decompression problems.

The error domain used (0) is invalid. We now use errors in the
G_IO_ERROR domain instead.

Propagate errors from internal functions.
Don't doublefree sections on errors.

Bring COPYING up to date with
http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt

In the metadata.

Rather than barf later on.

If we managed to find the cover path, but we can't decompress the
data, print a warning and carry on.

So that the thumbnailer works on older versions of GNOME.

To locate the rootfile, and parsing the rootfile to know the
path of the cover image.