Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GNOME Utility Library GNOME Utility Library
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 69
    • Issues 69
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • GNOME Utility LibraryGNOME Utility Library
  • Merge requests
  • !122

Merged
Created Oct 27, 2021 by Bastien Nocera@hadessDeveloper

Revert "thumbnails: keep the orignal file name"

  • Overview 9
  • Commits 1
  • Pipelines 2
  • Changes 1

This reverts commit e7006be2.

Passing the filename to an untrusted thumbnailer is a potential information leak, or a possible method to get that thumbnailer to crash.

The Flatpak sandboxing codepaths unfortunately cannot remap files, so that's the reason why the original filename is passed.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: wip/hadess/revert-filename-leak