GitLab

This is crufty and no longer useful. gnome-control-center will now
display GNOME Shell version instead of gnome-desktop version, which is a
more meaningful version to display anyway.

With this change, we'll no longer have to spin releases of gnome-desktop
with no changes.

See also: gnome-shell#5406
See also: gnome-control-center!1299

Saikeo Kavhanxay authored Apr 19, 2022 and Administrator committed Apr 19, 2022

(cherry picked from commit a750b99e)

Pawan Chitrakar authored Apr 16, 2022 and Administrator committed Apr 16, 2022

(cherry picked from commit 5de851a7)

Also, remove a very stale comment.

Sergio Costas authored Jan 29, 2022 and Michael Catanzaro committed Apr 11, 2022

The methods generate_thumbnail(), save_thumbnail and
create_failed_thumbnail from the class
gnome_desktop_thumbnail_factory offers neither a GError nor a
GCancellable options. For synchronous operations this is not
a true problem, but for asynchronous operations both are
a good idea.

This MR adds those parameters to the method.

Charles Monzat authored Apr 10, 2022 and Administrator committed Apr 10, 2022

(cherry picked from commit 20ba5941)

We need to be able to check for GNOME_DESKTOP_PLATFORM_VERSION >= 43.

Bastien Nocera authored Oct 27, 2021 and Michael Catanzaro committed Mar 16, 2022

This reverts commit e7006be2.

Passing the filename to an untrusted thumbnailer is a potential
information leak, or a possible method to get that thumbnailer
to crash.

The Flatpak sandboxing codepaths unfortunately cannot remap files, so
that's the reason why the original filename is passed.

Ryan Gonzalez authored Feb 01, 2022 and Michael Catanzaro committed Feb 07, 2022

Otherwise, only the symlink target is sent into the sandbox, so the symlink
itself is not found, and thumbnailing fails.
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>

Sergio Costas authored Jan 27, 2022 and Sergio Costas committed Feb 06, 2022

This MR adds async versions for the following methods:

 gnome_desktop_thumbnail_factory_generate_thumbnail
 gnome_desktop_thumbnail_factory_save_thumbnail
 gnome_desktop_thumbnail_factory_create_failed_thumbnail

This is useful to avoid blocking the main loop while creating
the thumbnails (which is an operation that can last too much
time), and allows to do it in Javascript, where is not possible
to create a thread in a GTask.

Fix #205

Mike FABIAN authored Feb 01, 2022 and Michael Catanzaro committed Feb 06, 2022

See also: https://fedoraproject.org/wiki/Changes/Ibus_table_cangjie_default_for_zh_hk

Previously, we used fedora:rawhide for gnome-desktop CI, but stopped
because gitlab.gnome.org's docker version was incompatible with F35
containers for a long time, so we pinned to F34 instead. Now we have
fixed that and updated to F35, but we'll be stuck here for a while
because we won't remember to update again in the future. fedora:latest
seems like a nice compromise between pinning to a particular stable
release vs. using rawhide for CI.

If the project is configured to build without systemd support, this
function is unused.

If one is foolish enough to also build with -Werror, as I am, then this
the resulting unused-function warning is fatal and one is sad.

Emmanuele Bassi authored Nov 27, 2021 and Emmanuele Bassi committed Nov 27, 2021

The `Makevars` file is only meant to be used by `make`.

Emmanuele Bassi authored Nov 27, 2021 and Emmanuele Bassi committed Nov 27, 2021

Otherwise xgettext won't recognise the translatable language string.

Fixes: #202

Emmanuele Bassi authored Nov 27, 2021 and Emmanuele Bassi committed Nov 27, 2021

- Do not include "config.h"
- Leave conditionally including xlocale.h to source files
- Add an error for missing GETTEXT_PACKAGE
- Rename non-idiomatic `_l` macro to `L_`

At some point, we're going to build only the 4.0 libraries except on
older versions of GNOME.

We want to allow building libgnome-desktop without the GUI libraries.

In order to port the GnomeBG and GnomeRR APIs to GTK4 we need to copy
the files into their own subdirectories, as we want to keep the older
GTK3-based implementations available for the legacy
libgnome-desktop-3.0. It also makes it easier for us to spin off these
libraries into their own projects, if we decide to do so.