GitLab

Add a Meson build system

See merge request !7

fix non-literal format string issue with clang

See merge request !9

clang errors out when using -Werror=format-nonliteral
since the definition of g_strdup_vprintf() from glib-2.0
is using va_list and clang seems to still warn where as
gcc doesn't do that for va_list arguments
Signed-off-by: Khem Raj <raj.khem@gmail.com>

Its time.

ever so slightly.

Fix compiler warnings

See merge request !6

Prerequisite for #4

. Additionally, this adds some more compiler warnings,
broadly similar to those used in libostree and bubblewrap.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Previously they were appended to a write-only variable.
Signed-off-by: Simon McVittie <smcv@collabora.com>

We call g_log_writer_is_journald() unconditionally since commit
cd78f8f9

 "Output messages by default if stdout is not the Journal"
and nobody complained.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

This means we can use -Wswitch-enum to check that we have thought
about everything we need to handle.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

The build system was meant to enforce this, but due to a bug in
Makefile-tests.am, the WARN_CFLAGS weren't used for anything.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Produce less confusing --help output

See merge request !5

Add a man page

See merge request !4

Signed-off-by: Simon McVittie <smcv@debian.org>

--dir wants an argument, and --first-root does not. Adjust the
GOptionEntry placeholders accordingly.
Signed-off-by: Simon McVittie <smcv@debian.org>

n_passed is garbage in --list mode

See merge request !3

Detected by clang's scan-build:

	src/gnome-desktop-testing-runner.c:1052:16: warning: The left operand of '>' is a garbage value
	  if (n_failed > 0)
	      ~~~~~~~~ ^

Create log directory

See merge request !2

Just as for the failed tests output directory, create the successful
tests directory before trying to output to it. For example, this
should create a “log-directory” directory:
gnome-desktop-testing-runner -L log-directory glib/gdatetime.test

Don't crash on unknown command-line options

See merge request !1

gnome-desktop-testing-runner --foo
made it crash because it tried to access a number of arrays which
weren't allocated at option parsing time. Simply allocate them so we
access empty arrays instead of dereference a NULL pointer.

Without this, you can't run make install more than once.

This broke the libostree CI which builds g-d-t-r from
git master using clang.

2018.1

This release drops the libgsystem dependency, which entailed
a nontrivial rewrite.

Git-EVTag-v0-SHA512: 99f4558120f1447b1769cfa1cd35e54428792daac3c712f6b5adb6aa3af52754e208fb2718746beb2d5299d09a3dc5ea29ee449a48ff82d2c33d4954052d5ff9

Signed-off-by: Simon McVittie <smcv@debian.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=788470

Reviewed-by: Emmanuele Bassi <ebassi@gnome.org>

As much as I'd like to stop supporting non-systemd Linux systems, some
people get very upset by the suggestion that systemd is mandatory on
Linux, and it isn't portable to non-Linux in any case.
Signed-off-by: Simon McVittie <smcv@debian.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=788470

Reviewed-by: Emmanuele Bassi <ebassi@gnome.org>

Otherwise the change in behaviour since 2016.1 would be a regression.
Signed-off-by: Simon McVittie <smcv@debian.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=788470

Reviewed-by: Emmanuele Bassi <ebassi@gnome.org>

Signed-off-by: Simon McVittie <smcv@debian.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=788470

Reviewed-by: Emmanuele Bassi <ebassi@gnome.org>

Caught these when I happened to have `CC=clang` due to some refactoring in the
libostree CI tests.

Saw this in a libostree PR, was caught by ASAN there.

This contains just the test output (stdout/stderr), and is
always generated even on success.  This is really what we want
for libostree at least; see https://github.com/ostreedev/ostree/pull/1218

I want to drop libgsystem from the world, this is one of the last holdouts. We
now require modern GLib and libsystemd. A side effect of this is that we're
likely to break some of the gnome-continuous journald integration.

Signed-off-by: Simon McVittie <smcv@debian.org>

See https://git.gnome.org/browse/ostree/commit/?id=d25212f04ac824afff9f45e61be3d8e63be174f2
for a chain of events that started this.

Basically it's a convenient way for tests to know they're being run
from a temporary directory.

Just on general principle, matching what we do in ostree etc.

It's shorter/less annoying to type, yet still fairly namespaced.