Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Settings
Settings
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 476
    • Issues 476
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 39
    • Merge Requests 39
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • SettingsSettings
  • Issues
  • #250

Closed
Open
Opened Oct 25, 2018 by Ondrej Holy@oholy
  • Report abuse
  • New issue
Report abuse New issue

All lines are selected in language chooser

The !162 (merged) caused that language chooser have all lines selected if cc_language_chooser_set_language() is not called before use.

Screenshot_from_2018-10-25_13-42-28

This happens in Users panel for users without language set (just for first time):

  1. Create new user, or choose some without language set
  2. Click to language button

I can fix it in Users panels by the following, but I think that it should be fixed in language chooser directly.

diff --git a/panels/user-accounts/um-user-panel.c b/panels/user-accounts/um-user-panel.c
index 4ae3dc0bd..8d3c403e5 100644
--- a/panels/user-accounts/um-user-panel.c
+++ b/panels/user-accounts/um-user-panel.c
@@ -1046,4 +1046,3 @@ change_language (GtkButton   *button,
 
-        if (current_language && *current_language != '\0')
-                cc_language_chooser_set_language (self->language_chooser, current_language);
+        cc_language_chooser_set_language (self->language_chooser, current_language);
         gtk_window_present (GTK_WINDOW (self->language_chooser));
Assignee
Assign to
GNOME 3.32
Milestone
GNOME 3.32
Assign milestone
Time tracking
None
Due date
None
2
Labels
1. Bug 6. Component: Region & Language
Assign labels
  • View project labels
Reference: GNOME/gnome-control-center#250