Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Settings Settings
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,005
    • Issues 1,005
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • SettingsSettings
  • Merge requests
  • !722

Merged
Created Mar 10, 2020 by Jian-Hong Pan@starnight

display: Fix the resolution going to be tested

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

Gnome-control-center checks the display modes by cc_display_config_is_scaled_mode_valid() ... cc_display_config_dbus_is_scaled_mode_valid() to exclude unusable low resolutions.

However, it is the current using resolution that going to be tested by is_scaled_mode_allowed() in is_scale_allowed_by_active_monitors(), if it is global scaled required or configured as cloning mode originally. Therefor, it will check current using resolution again and again, instead of the enumerated one. This leads gnome-control-center building wrong resolution list on the panel.

This patch replaces the current mode with the enumerated mode to have the correct resolution to be tested by is_scaled_mode_allowed().

Fixes #903 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: I903