From ef359060eef1364019fd61d4862d8dd17918d40d Mon Sep 17 00:00:00 2001
From: Felipe Borges <felipeborges@gnome.org>
Date: Tue, 22 Aug 2023 10:54:11 +0200
Subject: [PATCH] common: Fix "selectable" state of the ListRow InfoButton

Originally the screen reader wasn't reading the text of the label
within the popover. It read when we set label.selectable = True.
That had the side-effect of making the label have the visual look
of a selectable label (as expected).

This hack unsets the selectable state of the popover when it is
visible, but that still allows the screen reader to read the label.

Fixes #2508
---
 panels/common/cc-list-row-info-button.ui | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/panels/common/cc-list-row-info-button.ui b/panels/common/cc-list-row-info-button.ui
index edd7841a14..7ca3c92c5b 100644
--- a/panels/common/cc-list-row-info-button.ui
+++ b/panels/common/cc-list-row-info-button.ui
@@ -11,7 +11,7 @@
           <property name="label" translatable="yes">More information</property>
         </accessibility>
         <property name="popover">
-          <object class="GtkPopover">
+          <object class="GtkPopover" id="popover">
             <child>
               <object class="GtkLabel" id="label">
                 <property name="halign">center</property>
@@ -22,7 +22,8 @@
                 <property name="max-width-chars">50</property>
                 <property name="valign">center</property>
                 <property name="wrap">True</property>
-                <property name="selectable">true</property>
+                <!-- This is a hack to make the screen reader read the text of the label. See issue #2508 -->
+                <property name="selectable" bind-source="popover" bind-property="visible" bind-flags="invert-boolean">True</property>
               </object>
             </child>
           </object>
-- 
GitLab