Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Settings Settings
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,039
    • Issues 1,039
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 62
    • Merge requests 62
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • SettingsSettings
  • Merge requests
  • !1352

background: revert false indentation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Amy requested to merge amyipdev/gnome-control-center:amyipdev-patch-3 into main Jun 10, 2022
  • Overview 4
  • Commits 2
  • Pipelines 13
  • Changes 1

Commit 46673670 ("Fix indentation") indented lines 160-163 of cc-background-chooser.c to make them seem as if they were part of the associated if statement. However, they are not, which causes confusion as to the intention of the code. It appears as if the gtk_accessible_update_property call is executed upon button being non- null, but it is always executed due to the lack of an if block. For clarity, and to resolve a compiler warning, this patch should be reverted.

This patch reverts 46673670, changing the indentation back correctly. This was mentioned in #1902 (closed) and received no objections, including approval from Lukas.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: amyipdev-patch-3