Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Settings Settings
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,040
    • Issues 1,040
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 65
    • Merge requests 65
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • SettingsSettings
  • Merge requests
  • !1198

search: Overhaul location dialog, fix accessibility and keynav

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christopher Davis requested to merge BrainBlasted/gnome-control-center:search-fixups into master Feb 09, 2022
  • Overview 2
  • Commits 4
  • Pipelines 4
  • Changes 6

Fixes a few things missed in my initial MR for this panel:

  • I re-designed the Search Locations dialog, dropping the tabs in favor of AdwPreferences{Window,Page,Group}
  • Fixed keyboard navigation for the search results listbox
  • Set proper accessibility relations
  • Used AdwActionRow for search location rows, and made clicking the search results rows activate their switches
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: search-fixups