Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Settings Settings
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 923
    • Issues 923
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 78
    • Merge requests 78
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • SettingsSettings
  • Merge requests
  • !1044

display: Use ComboBox when folded

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Guido Günther requested to merge guidog/gnome-control-center:frac-scale into master Aug 24, 2021
  • Overview 6
  • Commits 2
  • Pipelines 3
  • Changes 4

On small window sizes the ButtonBox can overflow the panel. This is especially true in single display mode when no other elemnts prevent shrinking to e.g. 360px width on phones. Use the ComboBox introduced in 632cb3c9 in these cases.

For that we introduce cc_display_settings_refresh_layout() to refresh the layout when the folded state changes. This can later on be used for more tweaks to shrink to smaller sizes.

o

recording

(for the video i temporarily allowed more buttons in the button bar since my monitor would advertise too many scalings and combo box would always be used in that case)

/cc @bertob @bberg

Closes: #1443 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: frac-scale