Settings merge requestshttps://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests2023-08-31T20:44:30Zhttps://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1043Draft: pp_new_printer_dialog and pp_ppd_selection_dialog tests2023-08-31T20:44:30ZBrandon NielsenDraft: pp_new_printer_dialog and pp_ppd_selection_dialog tests`pp_new_printer_dialog` and `pp_ppd_selection_dialog` tests lack smoke tests to verify public API behavior.
For `pp_ppd_selection_dialog`, `test_empty_ui` makes sure the "Loading drivers database..." label is shown when no `PPDList` is ...`pp_new_printer_dialog` and `pp_ppd_selection_dialog` tests lack smoke tests to verify public API behavior.
For `pp_ppd_selection_dialog`, `test_empty_ui` makes sure the "Loading drivers database..." label is shown when no `PPDList` is provided. `test_load_complete` ensures the label is cleared when an empty `PPDList` is provided. `test_manufacturer_list_display` makes sure the `PPDList` correctly displays manufacturers. `test_model_list_display` ensures the displayed models update correctly when a manufacturer is selected. These together effectively exercise `pp_ppd_selection_dialog_set_ppd_list`.
`test_get_ppd_name` forces a selection and verifies `pp_ppd_selection_dialog_get_ppd_name`, `test_get_ppd_display_name` does the same for `pp_ppd_selection_dialog_get_ppd_display_name`.
For `pp_new_printer_dialog`, `test_get_new_printer` builds a completely new list store to avoid depending on CUPS behaviors. This store is swapped in, a selection is forced, and basic functioning of `pp_new_printer_dialog_get_new_printer` is checked.