Consolidate Sharing service status strings (on/off/enabled/disabled/active...)
The following discussion from !1783 (merged) should be addressed:
- @aday started a discussion: (+8 comments)
Screenshot looks great!
The only issue I see is the inconsistent states - it would be better if they all said "On" or "Off", as opposed to the mix of On/Enabled/Active. I guess that's not a new issue though.
There are 3 service statuses = OFF/ENABLED/ACTIVE.
I added a new commit that only shows "On" when the service is ACTIVE. If it is ENABLED but not ACTIVE, we now show "Off".
Ah, that makes sense. I can see why it would be desirable to communicate "enabled but not on active now".
I think the main issue here is the combination of "On" with "Active" and "Enabled". They're not logically related. Also, "On" doesn't fit my mental model of SSH. In my mind, it's either allowed or it isn't.
What about using "Disabled"/"Enabled"/"Active" for all the status strings, and limiting SSH to "Disabled" or "Enabled"?
The logic for "enabled" in the File/Media sharing is that it indicates other networks will automatically activate and are still enabled in that sense. I found the wording a bit confusing as well, but changing it to "Off" will hide that other networks might still automatically activate the service.
Perhaps "Off", "Standby", and "Active" (or "Enabled" or "On") would work?
The latest commit I push makes it use "Enabled", "Disabled", "Active". @aday what do you think about "Standby" as proposed by @velsinki here? I also thought of using "Available".
It's a neat idea. The main issue with "Standby" is that it's a noun. To be grammatically correct, the label would need to read "On Standby" which is a bit awkward.
Ah yes, that's a bit weird. However, I find "Enabled" vs. "Active" more awkward.
But the option as @aday proposed above and as in 0956d0b6 is possibly even more confusing, as now "Enabled" for SSH means it's running, whereas for File Sharing it would mean currently not running... I would say all sharing things should have the same word for completely off or running (not different for media/file).
Maybe always "Off" for completely off, "On" for actually running, and then for the network enabled but currently off perhaps: "Inactive", "Saved" or maybe "On Standby"? "Saved" might work well too, as it implies some state is saved, but different from "On".
Main states 0956d0b6 states "Saved" state, only "Off"/"On"