GTK4 port UI review

The following is a list of relatively polish issues observed while testing main today (in a JHBuild session). Some of the issues are obvious regressions in the GTK4 port. Others aren't new, but reflect gaps between the HIG and the design patterns being used - since we're porting to GTK4 it would be nice to try and follow the design patterns as much as possible.

I've been a little superficial in the review in some areas. I've also skipped over some panels that we know need rethinking (removable media, sharing, default applications, color).

I'll update the list to reflect discussion and progress.

Priority issues

These are the most obvious visual issues. Could include any critical functional issues too.

• Wi-Fi
  • Giant spinner shown in network settings dialogs immediately after opening [1]
• Network
  • Every row of the VPN list is rounded [3]
• Sound
  • Alert sound toggles at the bottom missing styling
• Printers
  • Fuzzy icons in the list
  • List isn't centered
• Displays
  • Night light slider escapes bounds of listbox
  • When there's only one display, we shouldn't show the on/off switch row for that display

Other issues

• Wi-Fi
  • Secondary menu appears as a list of buttons inside a popover - shouldn't it be a regular menu? [2]
• Network
  • Add OpenVPN modal doesnt have enough height and it is not resizable
• Appearance
  • Needs design - selection indicators are inconsistent - light/dark selector uses a border around the thumbnail, whereas the wallpaper selection uses a check
  • Needs design - the add picture button should maybe have a background?
• Notifications
  • List rows should have a go-next-symbolic icon
  • Dialog windows should have margin around the list box
• Search
  • Search locations dialog needs list boxes
  • Search locations button position is odd, needs rethinking (see !1164 (merged) and latest mockups)
• Thunderbolt
  • Odd empty state [5]
  • Direct access row should have a list box around it
• Sound
  • Volume slider at the top would be better in a list box
• Power
  • Automatic suspend row should have a go-next-symbolic
  • Automatic suspend dialog needs boxed lists
• Displays
  • Inconsistent number badges - some are square, some are round
• Mouse & Touchpad
  • Needs design - the "Test Your Settings" label is long, shouldn't use "your" if possible
• Keyboard
  • Input source list menus have bold text - should be regular weight?
  • Input source switching radio button rows look cramped. See the multitasking panel for a better spacing.
• Region & Language
  • Maybe drop the My Account / Login Screen switcher - see latest mockups
  • List rows need go-next-symbolic icons
  • Language dialog needs updating
  • Formats dialog has a spurious window close button
• Accessibility
  • Rows that open a dialog should have go-next-symbolic icons
• Date & Time
  • Date and time and time zone rows need go-next-symbolic icons
• About
  • Arrow in Software updates row is at the start of the row [6]
• Online Accounts
  • Floating shadow, presumably from a listrow that's in the middle of the panel [7]

[1]

[2]

[3]

[4]

[5]

[6]

[7]