Rework the widgetry of the dialogs to use
AdwPreferences{Page,Group} and AdwActionRows.
This lets the dialogs be freely resizable,
and gives them sensible default sizes.

The extra line was causing newline chars and whitespaces to be added
to translation strings

Mohammed Sadiq authored Feb 11, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

It's possible that the QR code for the same text has been requested,
but for a different size.  Fix a memory leak that would happen
in those cases.

Uses AdwPreferencesPage and AdwPreferencesGroup for
consistency with the rest of the application. The
combo rows now use AdwActionRow so they can be
included in the AdwPreferencesGroup without
a custom list box.

Carlos Garnacho authored Feb 12, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

Closes: #1612

Carlos Garnacho authored Feb 12, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

This is a possible reason for undesired calibration resets.

Closes: #1613

Carlos Garnacho authored Feb 12, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

Unfortunately, this may be the case, it is better to show wonky UI
than no UI at all.

Carlos Garnacho authored Feb 10, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

Instead of figuring out a monitor number from a GdkMonitor, and
look the GdkMonitor back up, pass the GdkMonitor directly.

Carlos Garnacho authored Feb 12, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

So we can fullscreen on a monitor and forget.

Carlos Garnacho authored Feb 12, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

Modernize a bit the code, since it will be easier to do some things
as a window subclass.

Carlos Garnacho authored Feb 12, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

Add "Cc" prefix so it's more consistent with the rest of the project.

Carlos Garnacho authored Feb 10, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

It got to a building state in the GTK4 port, but was broken at
runtime. Update event handlers and builder objects so it works again.

Carlos Garnacho authored Feb 10, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

These dimensions are no longer used.

Carlos Garnacho authored Feb 12, 2022 and Georges Basile Stavracas Neto committed Feb 12, 2022

This function was only used for logging purposes, we can do
without it.

Ivan Molodetskikh authored Jan 28, 2022 and Florian Müllner committed Feb 12, 2022

Move this to gnome-shell where it belongs. See
gnome-shell!2107

See gnome-shell!2070

Mohammed Sadiq authored Feb 11, 2022 and Georges Basile Stavracas Neto committed Feb 11, 2022

Explicitly set white background for the image so that white border
is shown around the QR code in dark themes too.

All other dialogs have bold titles, this should too.

Issue #1587

Allow search entry of new printer dialog to expand so that it fills
the available area. It does not fill it now so there is more free
space on the right than on the left.

Issue #1587

Change align of the printers icons to CENTER from FILL so that the icons
are not stretched.

Issue #1587

Make use of libadwaita's provided widget for status pages
instead of rolling our own.

Felipe Borges authored Oct 18, 2021 and Georges Basile Stavracas Neto committed Feb 10, 2022

In commit c7bd4428 we started to
show the configuration button for all rows, which fixes the original
issue of not being able to tweak a connection during association but
also introduces a regression of not having connection data to show
for other connections in the list. This way, the configuration
button will fail to create a net_connection_editor interface for
rows that aren't associated with an active connection.

Let's only show the configuration button when the NMActiveConnectionState
is either NM_ACTIVE_CONNECTION_STATE_ACTIVATING or
NM_ACTIVE_CONNECTION_STATE_ACTIVATED.

Fixes #1494