1. 27 May, 2022 2 commits
  2. 26 May, 2022 9 commits
    • Norbert Pfeiler's avatar
      info-overview: Remove trailing space after CPU name · 6c79f2e9
      Norbert Pfeiler authored
      It was apparent when selecting the text, as the text is right aligned.
      
      »AMD® Ryzen threadripper 1950x 16-core processor × 32 «
      ↓
      »AMD® Ryzen threadripper 1950x 16-core processor × 32«
      6c79f2e9
    • Benjamin Berg's avatar
      network: Fix saving passwords for non-wifi connections · 393528f5
      Benjamin Berg authored
      When validating security settings for non-wifi connections, we
      temporarily create a wireless connection. Unfortunately, when this
      connection is destroyed, it'll clear the stored password from the 802.1x
      settings object.
      
      Avoid this by removing the setting before the temporary connection is
      destroyed.
      
      Closes: #337
      393528f5
    • Victor Toso's avatar
      keyboard-shortcut-editor: fix leak of accel string · e8650a56
      Victor Toso authored
      ==31571== 120 bytes in 8 blocks are definitely lost in loss record 17,034 of 19,290
      ==31571==    at 0x484086F: malloc (vg_replace_malloc.c:380)
      ==31571==    by 0x4AF77A8: g_malloc (gmem.c:106)
      ==31571==    by 0x4D9816A: gtk_accelerator_name (gtkaccelgroup.c:1577)
      ==31571==    by 0x4A82D1: setup_custom_shortcut (cc-keyboard-shortcut-editor.c:364)
      ==31571==    by 0x4A92DF: cc_keyboard_shortcut_editor_key_press_event (cc-keyboard-shortcut-editor.c:745)
      e8650a56
    • Victor Toso's avatar
      keyboard-item: fix leak on unused CcKeyCombo · e7872ed1
      Victor Toso authored
      ==31571== 288 bytes in 24 blocks are definitely lost in loss record 18,138 of 19,290
      ==31571==    at 0x484086F: malloc (vg_replace_malloc.c:380)
      ==31571==    by 0x4AF77A8: g_malloc (gmem.c:106)
      ==31571==    by 0x4A4119: variant_get_key_combos (cc-keyboard-item.c:475)
      ==31571==    by 0x4A41FD: settings_get_key_combos (cc-keyboard-item.c:498)
      ==31571==    by 0x4A46BE: cc_keyboard_item_load_from_gsettings (cc-keyboard-item.c:574)
      ==31571==    by 0x4A5BBB: append_section (cc-keyboard-manager.c:315)
      ==31571==    by 0x4A605D: append_sections_from_file (cc-keyboard-manager.c:431)
      ==31571==    by 0x4A6766: reload_sections (cc-keyboard-manager.c:568)
      ==31571==    by 0x4A6D68: cc_keyboard_manager_load_shortcuts (cc-keyboard-manager.c:707)
      ==31571==    by 0x4A2FA4: cc_keyboard_shortcut_dialog_init (cc-keyboard-shortcut-dialog.c:841)
      ==31571==    by 0x4A7A288: g_type_create_instance (gtype.c:1929)
      ==31571==    by 0x4A61CAC: g_object_new_internal (gobject.c:1945)
      e7872ed1
    • Victor Toso's avatar
      keyboard-manager: fix leak of section list store · f62ba0d9
      Victor Toso authored
      ==25729== 1,058 (40 direct, 1,018 indirect) bytes in 1 blocks are definitely lost in loss record 20,104 of 20,657
      ==25729==    at 0x484086F: malloc (vg_replace_malloc.c:380)
      ==25729==    by 0x4AF77A8: g_malloc (gmem.c:106)
      ==25729==    by 0x4B0F1E4: g_slice_alloc (gslice.c:1072)
      ==25729==    by 0x4B09060: UnknownInlinedFun (gsequence.c:1609)
      ==25729==    by 0x4B09060: g_sequence_insert_before (gsequence.c:527)
      ==25729==    by 0x4ED2FE7: gtk_list_store_insert (gtkliststore.c:1271)
      ==25729==    by 0x4A5DCE: append_section (cc-keyboard-manager.c:363)
      ==25729==    by 0x4A605D: append_sections_from_file (cc-keyboard-manager.c:431)
      ==25729==    by 0x4A6766: reload_sections (cc-keyboard-manager.c:568)
      ==25729==    by 0x4A6D33: cc_keyboard_manager_load_shortcuts (cc-keyboard-manager.c:706)
      ==25729==    by 0x4A2FA4: cc_keyboard_shortcut_dialog_init (cc-keyboard-shortcut-dialog.c:841)
      ==25729==    by 0x4A7A288: g_type_create_instance (gtype.c:1929)
      ==25729==    by 0x4A61CAC: g_object_new_internal (gobject.c:1945)
      f62ba0d9
    • Victor Toso's avatar
      common: Fix leak of GUdevDevice · b3c42dff
      Victor Toso authored
      The add_device() check for g_udev_device_get_parent() was leaking (see
      below). As this is actually used in create_device(), I'm passing it as
      argument to avoid a second call to that function.
      
       > 34,175 (1,080 direct, 33,095 indirect) bytes in 27 blocks are definitely lost in loss record 19,729 of 19,758
       >    at 0x4A7A337: g_type_create_instance (gtype.c:1907)
       >    by 0x4A61CAC: g_object_new_internal (gobject.c:1945)
       >    by 0x4A62C7C: g_object_new_with_properties (gobject.c:2114)
       >    by 0x4A63780: g_object_new (gobject.c:1785)
       >    by 0x5EA5A6A: _g_udev_device_new (gudevdevice.c:132)
       >    by 0x4B6D24: add_device (gsd-device-manager.c:447)
       >    by 0x4B6FBF: gsd_device_manager_init (gsd-device-manager.c:517)
       >    by 0x4A7A288: g_type_create_instance (gtype.c:1929)
       >    by 0x4A61CAC: g_object_new_internal (gobject.c:1945)
       >    by 0x4A62C7C: g_object_new_with_properties (gobject.c:2114)
       >    by 0x4A63780: g_object_new (gobject.c:1785)
       >    by 0x4B7075: gsd_device_manager_get (gsd-device-manager.c:533)
      b3c42dff
    • Michael Catanzaro's avatar
      network: fix critical when opening VPN details page · 522074ec
      Michael Catanzaro authored
      I was seeing this critical when opening the VPN details page:
      
      (gnome-control-center:78888): nm-CRITICAL **: 16:26:21.689: ((src/libnm-client-impl/nm-device.c:1299)): assertion '<dropped>' failed
      
      It probably broke in 551d7228. The code
      above and below expects self->device may be NULL, so let's add a
      NULL check here.
      522074ec
    • Jeremy Bicha's avatar
      wwan: Remove duplicate line from .desktop · 34b5db13
      Jeremy Bicha authored
      34b5db13
    • Ian Douglas Scott's avatar
      keyboard: Avoid segfault due to no "data" for `custom_shortcut_add_row` · 7b0c55bf
      Ian Douglas Scott authored
      Ultimately it would be good to get rid of the use of
      `g_object_set_data`/`g_object_get_data` here, but this works for now.
      
      Fixes #1373.
      7b0c55bf
  3. 24 Apr, 2022 1 commit
  4. 03 Apr, 2022 1 commit
  5. 16 Mar, 2022 1 commit
  6. 10 Mar, 2022 3 commits
  7. 07 Mar, 2022 1 commit
  8. 20 Feb, 2022 1 commit
  9. 15 Feb, 2022 3 commits
  10. 13 Feb, 2022 2 commits
  11. 10 Feb, 2022 1 commit
    • Felipe Borges's avatar
      network: Show configuration button only for active/connecting connections · 212ab19d
      Felipe Borges authored
      In commit c7bd4428 we started to
      show the configuration button for all rows, which fixes the original
      issue of not being able to tweak a connection during association but
      also introduces a regression of not having connection data to show
      for other connections in the list. This way, the configuration
      button will fail to create a net_connection_editor interface for
      rows that aren't associated with an active connection.
      
      Let's only show the configuration button when the NMActiveConnectionState
      is either NM_ACTIVE_CONNECTION_STATE_ACTIVATING or
      NM_ACTIVE_CONNECTION_STATE_ACTIVATED.
      
      Fixes #1494
      212ab19d
  12. 07 Feb, 2022 2 commits
  13. 05 Feb, 2022 1 commit
  14. 31 Jan, 2022 1 commit
  15. 30 Jan, 2022 6 commits
  16. 29 Jan, 2022 5 commits