1. 23 Apr, 2021 1 commit
  2. 22 Apr, 2021 1 commit
  3. 14 Apr, 2021 1 commit
  4. 20 Nov, 2020 8 commits
  5. 25 Sep, 2020 5 commits
    • Pascal Nowack's avatar
      sharing: Remove vino preferences · 2a39ce60
      Pascal Nowack authored
      They are unused now.
      2a39ce60
    • Pascal Nowack's avatar
      sharing: Replace vino with gnome-remote-desktop for X11 sessions · c6eda3c7
      Pascal Nowack authored
      vino does not work in Wayland sessions and gnome-settings-daemon
      removed vino support in [1] which will effectively not start
      'vino-server' any more.
      The replacement for vino is gnome-remote-desktop since it works in both
      Wayland and X11 sessions.
      The gnome-remote-desktop sharing panel however is currently only shown
      for Wayland sessions, which makes it harder to use it for X11 sessions
      since the user has to login into the Wayland sessions just to be able
      to enable gnome-remote-desktop.
      
      Therefore, also remove vino from g-c-c and replace it with
      gnome-remote-desktop for X11 sessions, too.
      
      [1] gnome-settings-daemon!135
      
      Closes: #212
      Closes: #937
      c6eda3c7
    • Ian Douglas Scott's avatar
      keyboard: Fix behavior of "Replace" when adding custom shortcut · 6172c970
      Ian Douglas Scott authored
      In the shortcut editor, the "Replace" button is shown instead of "Set"
      or "Add" when there is a collision. But this executes the same code as
      "Set", so when adding a shortcut, it doesn't actually work.
      6172c970
    • Arne's avatar
      sound: fix subwoofer slider · f2c0a025
      Arne authored
      f2c0a025
    • Hui Wang's avatar
      sound: update the profile list after getting the signal from gvc · bbc1ca6d
      Hui Wang authored
      
      
      In the ubuntu 20.04, we found a regression on HDMI audio. We plug a
      HDMI/DP monitor, the output device is the speaker in the output device
      combo box, then we select the HDMI from the combo box, the output
      device is switched to HDMI audio successfully, but the configuration
      box is empty. This will not happen in the ubuntu 18.04, the profile
      will show hdmi-stereo in this situation. So I think this is a
      regression.
      
      When problem happens, I could see the errors from log:
      Gvc:    DEBUG: Matching profile for 'output:analog-stereo' is '(null)'
      Gvc:    DEBUG: Matching profile for 'output:analog-stereo' is '(null)'
      Gvc:    DEBUG: Matching profile for 'output:analog-stereo' is '(null)'
      
      Through debugging, I found the cc_profile_combo_box_set_device() is
      called too early. In the ubuntu 18.04, this function is called after
      pulseaudio changes the active_profile, but in the ubuntu 20.04, it is
      called ahead of pulseaudio changes the active_profile.
      
      To fix it, add a signal callback function, after pulseaudio changes
      the active_profile, this callback function will be called, then call
      cc_profile_combo_box_set_device().
      Signed-off-by: Hui Wang's avatarHui Wang <hui.wang@canonical.com>
      bbc1ca6d
  6. 31 Aug, 2020 1 commit
  7. 30 Aug, 2020 1 commit
  8. 26 Aug, 2020 1 commit
  9. 23 Aug, 2020 1 commit
  10. 19 Aug, 2020 1 commit
  11. 18 Aug, 2020 2 commits
  12. 17 Jul, 2020 2 commits
    • Rafael Fontenelle's avatar
      e7eb8d98
    • Elia Geretto's avatar
      printers: Do not authenticate SMB servers when search field is edited · 6eaaf22e
      Elia Geretto authored
      When the search field in the "Add Printer" dialog is edited, no
      authentication with a remote SMB server should be attempted. The server
      should just be added to the list and marked with "Server requires
      authentication". The user can then authenticate the server by clicking
      on it.
      
      The behavior described above is probably the intended one when the code
      was written, since there is no closure registered for the
      "authentication-required" signal in the function this commit modifies.
      This commit should simply restore the intended behavior.
      
      Resolves: #755
      6eaaf22e
  13. 16 Jul, 2020 1 commit
  14. 06 Jul, 2020 1 commit
  15. 03 Jul, 2020 1 commit
  16. 26 Jun, 2020 8 commits
    • Marco Trevisan's avatar
      fingerprint-dialog: Disconnect signals and reset stages on enroll-restart · f6f975a8
      Marco Trevisan authored
      This happens if going to the previous page when enrolling a finger
      f6f975a8
    • Marco Trevisan's avatar
      fingerprint-dialog: Don't limit the number of maximum enroll stages · 09cefec2
      Marco Trevisan authored
      There are devices with more than 10 enroll stages we should handle, so
      instead of hardcoding a grid of images, let's just build this dynamically
      using a flowbox
      09cefec2
    • Marco Trevisan's avatar
      fingerprint-dialog: Don't use sync calls for deleting fingerprints · 690f8034
      Marco Trevisan authored
      Don't make the UI to block while deleting the saved prints (that might take
      some time, especially for devices with internal storage) but just use a task
      with a thread that:
       - Mark the fingerprint row as unsenstive
       - Calls the method to delete prints
       - In the same thread, calls the method to fetch the updated informations
       - Returns in set_fingerprint_row_cb where we update the UI again
      
      Again this would be nicer to be done just using async calls but this is
      something to do in some bigger refactor.
      690f8034
    • Marco Trevisan's avatar
      user-panel: Only load the fingerprint state once · 563232e4
      Marco Trevisan authored
      Don't load the fingerprint information all the times we update the view, but
      load it during initialization only.
      
      The fingerprint state in fact can only change because we requested it
      through the dialog that we control already and that would update the
      relevant widgets state anyways.
      
      Also, given that the fingerprint settings are visible for the current user
      anyway, we can track this only with a simple boolean, instead of using a set
      of UIDs.
      563232e4
    • Marco Trevisan's avatar
      user-panel: Pass a cancellable to the fingerprint operations · 7d133b8b
      Marco Trevisan authored
      And cancel it when changing user and on disposition
      7d133b8b
    • Marco Trevisan's avatar
      c65f108f
    • Marco Trevisan's avatar
      user-panel: Don't wait for fprintd on initialization · c413d4db
      Marco Trevisan authored
      When opening the user panel we g-c-c performs lots of sync operations that
      may cause a noticeable slowdown, especially when a fingerprint device is
      available, in fact set_fingerprint_label() call leads to:
        - DBus sync request of the system bus
        - fprintd dbus-activation
          + This leads to sync opening of all the devices, that might also cause
            a slowdown, depending on the devices drivers
        - Dbus sync calls to the device to get the list of enrolled fingerprints
      
      Only after we've a reply, we update the g-c-c UI and continue the execution.
      
      The fingerprint dialog code would need some global refactor, but to fix this
      without big changes, let's just use GTask that runs a thread in wich we do
      all the sync operations, and once done we finally update the widget state.
      c413d4db
    • Marco Trevisan's avatar
      user-panel: Add reference to selected user and clear on dispose · 689aee32
      Marco Trevisan authored
      The object was wrongly unreffed (as ActUserManager has the ownership) on
      user switch, so add a reference instead when assigning it to our private
      ref and unref it on dispose.
      689aee32
  17. 25 Jun, 2020 1 commit
  18. 18 Jun, 2020 1 commit
  19. 15 Jun, 2020 1 commit
  20. 03 Jun, 2020 1 commit