GitLab

The widget were renamed in 6cd94618 and this setting was broken.

Fixes #555

This would leak the value of the first setting.

Info panel crashes has been fixed by !387 on master branch, however,
gnome-3-30 is still affected as the same fix can't be used there, because
its complexity and changed dependencies. The panel crashes because
GUnixMountPoint is by mistake used as GUnixMountEntry. Let's find
and use corresponing GUnixMountEntry to simply fix those crashes for
gnome-3-30.

Closes: #411

(cherry picked from commit be3fbd8b)

(cherry picked from commit 5b53f026)

(cherry picked from commit e520ab89)

This caused the UI related strings to be leaked.

(cherry picked from commit 713e2097)

When comparing configurations, the monitor positions are compared
directly. This comparison will not work properly if one of the
configurations has an offset.

This results in the "Apply" button to show up incorrectly after moving
the top/left monitor position.

(cherry picked from commit d9aab366)

We were converting the floating point numbers to integers using a cast,
which causes them to be always rounded down. The result is that a
monitor may be too small by a pixel, creating broken configurations.

Also fix the same issue when calculating whether a scale should be
supported.

See mutter#412

(cherry picked from commit 4db431d7)

Since the gsettings is for the repeat-interval but the
GUI is for Speed, we need to reverse the mapped direction.

We have to turn off the fill indicator (has_origin) for Speed
since it fills the right side instead of the left. We turn
off the indicator for Delay to match.

Closes: #311
(cherry picked from commit ae75ebca)

In the async version of the client creation, i.e. when a new client
is created via bolt_client_new_async and an error happens it will be
passed to g_task_return_error which takes ownership of it but the very
same error will also be free'd via g_autoptr; remove the latter.

This is a port of bolt commit e96f8bd47587b167ae46c8ac9347003f69f931dd

(cherry picked from commit 06894e02)

The Thunderbolt panel warns about explicit_bzero() not being available
but never checked for it.

gnome-control-center/panels/thunderbolt/bolt-str.c: In function ‘bolt_erase_n’:
gnome-control-center/panels/thunderbolt/bolt-str.c:33:4: warning: #warning no explicit bzero, using fallback [-Wcpp]
   #warning no explicit bzero, using fallback
    ^~~~~~~

Closes: #286


(cherry picked from commit cad5f982)

Should be left-aligned, previously it was centered

When changing the display mode, the apply button does not appear if the
current mode and new mode differ only in their interlaced flag.

The display mode comparison function now takes the interlaced flag into
account.

(cherry picked from commit b4809cd2)

The AP list needs to be updated every time APs are added or removed.
However, such addition and removal generally happens in bulk (i.e. scan
results coming in) and doing so for every AP is wasteful.

So update the widget from an idle handler instead of updating it
immediately from the signal handler.

Fixes #152

The code to lookup or insert items into the combobox had a few issues.
It would assume that the items are sorted, causing existing items to not
be found and be inserted instead. It also would simply forget to insert
an item if it was larger than all existing items.

This code is now changed to iterate over all items, finding the best
insertion point in the process (next item has a larger value, or the
values are not increasing anymore). The item will only be inserted if it
has not been found.

Fixes #261


(cherry picked from commit b5711c59)

Use g_signal_connect_object to ensure handler is not run after object is
destroyed.

Fixes: #223

gnome-settings-daemon emits notifications related to these four control
panels. If we add X-GNOME-UsesNotifications to their desktop files, the
user will be able to control the notifications.

https://wiki.gnome.org/Initiatives/GnomeGoals/NotificationSourceSigned-off-by: Philip Withnall <withnall@endlessm.com>


(cherry picked from commit c07b3573)

Simply a small cleanup to typedef the relevant data structures.

(cherry picked from commit c9fc833d)