Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Characters Characters
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 52
    • Issues 52
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • CharactersCharacters
  • Merge requests
  • !7

libgc: Fix crasher with some GCC configurations

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Bastien Nocera requested to merge wip/fix-gc-blocks-init-crasher into master Apr 21, 2018
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

const variables are not supposed to be writable, and trying to initialise the various "const" blocks caused SEGVs. Remove the const modifier as it's incorrect.

The valgrind output for this crash is clear, "Bad permissions":

==11056== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==11056==  Bad permissions for mapped region at address 0x28C91360
==11056==    at 0x28C8D0AB: init_blocks (gc.c:926)
==11056==    by 0x28C8E46B: gc_character_iter_init_for_related (gc.c:938)
==11056==    by 0x28C8E46B: gc_search_context_search (gc.c:1124)
Edited Apr 21, 2018 by Bastien Nocera
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/fix-gc-blocks-init-crasher