Skip to content

Distinguish hidden calendars in the .ics event importer dialog — Sam's Fan Edition 🪭

Jeff Fortin requested to merge jfft/gnome-calendar:eye_icon_for_invisible_calendars_in_importer into main

This is what I could salvage from !428 (closed) by myself, to show indicator icons on hidden calendars among the choices in the import dialog.

This MR here only improves the .ics event importer dialog by adding the "eye not looking" icons for not-shown calendars; it fixes #1184 (closed).

What is not part of this MR here:

  • It does not handle "hidden calendar" icons in the event editor dialog (only in the importer dialog), because I couldn't figure out the conflicts there either, and the Event Editor dialog needed more refactoring for this to be possible.
    @DiegoIvanME reimplemented/solved this in !477 (merged) now.

  • It does not filter out read-only calendars from either the import dialog nor the event editor dialog (I could not figure that out myself while staring at the GtkFilterListModel and GtkFilter documentation.)
    @TheEvilSkeleton reimplemented/solved this in !474 (merged) now.

Result of this MR here:

Before After, v1 After, v2 (status icon split out from colored dots)
GNOME_Calendar_event_importer_hidden_calendars_-_before GNOME_Calendar_event_importer_hidden_calendars_-_after event_importer_read-only_and_invisible_calendars_-after__as_implemented-_v2_pix.opti

v2 (shown above) splits out the indicator icon from the colored dot icon, as per design consensus from @PhilippSauberz, @monster, @cassidyjames, @TheEvilSkeleton and @DiegoIvanME around @snwh's idea.~~ It was added as an extra commit on top, but it can be squashed with the previous commit if desired.~~

The last commit, adding an a11y description label, uses the exact same translatable string as Diego's event editor branch.

Edited by Jeff Fortin

Merge request reports