event-popover: Rework UI and code (!392) · Merge requests · GNOME / gnome-calendar

Hari Rana requested to merge TheEvilSkeleton/gnome-calendar:redo-event-popover into main Dec 07, 2023

This was initially a port to libadwaita widgets, but due to limitations with gtk#5782 and #1004 (closed), I reworked the UI without abusing the popover's limitations.

Depends on !418

This builds on top of the existing UI/code, while adding a few improvements and behavioral changes.

To list out major improvements and changes:

The entire content of the popover is wrapped inside GtkScrolledWindow, because otherwise it's really difficult to apply a drop shadow in specific cases, and consistently size every GtkSeparator. Furthermore, there isn't a libadwaita page widget strictly designed for popovers. It also ensures that, no matter the size of the content, the width of the popover is limited and won't take as much horizontal space as possible, for readability.

Any section needing a specific amount of spacing (separation) or flexibility to alter or remove is wrapped inside its own dedicated GtkBox.

Everything but the title and description are ellipsized and limited to one line. This is to avoid GtkPopover's limitations with text wrapping; see: gtk#5782.

Each section is properly separated with GtkSeparators, with equal amount of top and bottom margins.

Location and Meetings section are mutually exclusive; only one is shown.

When an event has no description/note, the popover will always display that there's no description.