Skip to content

calendar-monitor: Ensure cancellable is not cancelled before set complete

Krifa75 requested to merge Ordissimo/gnome-calendar:check-cancellable into main

Step to reproduce :

  • Add a new calendar
  • Play to Hide/Display multiple calendar
  • Remove the new calendar added

Current behavior :
(gnome-calendar:20584): GLib-GObject-CRITICAL **: 15:00:15.437: g_object_ref: assertion '!object_already_finalized' failed

with gdb :

Thread 1 "gnome-calendar" received signal SIGSEGV, Segmentation fault.
0x00005555555bb826 in set_complete (self=0x0, complete=0) at ../src/core/gcal-calendar-monitor.c:873
873	  if (self->complete == complete)
(gdb)

It seems in set_complete self is NULL, so I added a condition to check it has been cancelled.

I hope I did everything right.

Thanks !

Merge request reports