gnome-calendar issueshttps://gitlab.gnome.org/GNOME/gnome-calendar/-/issues2019-11-08T17:49:20Zhttps://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/468Search results popover flickering2019-11-08T17:49:20ZGeorges Basile Stavracas NetoSearch results popover flickeringGNOME 3.34Georges Basile Stavracas NetoGeorges Basile Stavracas Netohttps://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/456Short option -d is interpreted as --date instead of --debug2019-11-08T17:51:43ZSibo DongShort option -d is interpreted as --date instead of --debugRunning version 3.34. The output of `gnome-calendar --help` is
```
Usage:
gnome-calendar [OPTION…]
Help Options:
-h, --help Show help options
--help-all Show all help options
--help-gapplication ...Running version 3.34. The output of `gnome-calendar --help` is
```
Usage:
gnome-calendar [OPTION…]
Help Options:
-h, --help Show help options
--help-all Show all help options
--help-gapplication Show GApplication options
--help-gtk Show GTK+ Options
Application Options:
-q, --quit Quit GNOME Calendar
-v, --version Display version number
-d, --debug Enable debug messages
--date Open calendar on the passed date
-u, --uuid Open calendar showing the passed event
--display=DISPLAY X display to use
```
`-d` should enable debug messages, but it seems that it is being interpreted as `--date` instead.
```
$ gnome-calendar -d
Missing argument for -d
$ gnome-calendar --date
Missing argument for --date
```
I believe the issue is with [this line](https://gitlab.gnome.org/GNOME/gnome-calendar/blob/3.34.0/src/gui/gcal-application.c#L76) where it appears that `--date` has the same short option name as `--debug` above it.GNOME 3.34Georges Basile Stavracas NetoGeorges Basile Stavracas Netohttps://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/423Recommend auditing all use of g_signal_connect()2019-09-14T23:33:30ZMichael CatanzaroRecommend auditing all use of g_signal_connect()I spent most of yesterday and today looking over a bunch of gnome-calendar crash reports. One commonality is that there are several very similar mistakes with signal use:
* Failure to disconnect a signal handler from an object foo when...I spent most of yesterday and today looking over a bunch of gnome-calendar crash reports. One commonality is that there are several very similar mistakes with signal use:
* Failure to disconnect a signal handler from an object foo when the self object is destroyed. The foo outlives self and emits the signal, then the signal handler crashes because it's not prepared for self to already be destroyed. The best way to avoid this problem is to use g_signal_connect_object() (possibly with G_CONNECT_SWAPPED if desired), but disconnecting manually in dispose works fine too.
* Failure to disconnect the signal handler from a priv member when overwriting the priv member with another object. The signal handers must be disconnected manually.
Often both of these errors occur at the same time. Both errors are present in !73, !74, !75, !77, and !80. Each of those merge requests is a good example of how to fix both of these problems.
I have not audited gnome-calendar's code to check for more of these mistakes: I've just been looking at actual crash reports that have been piling up on Red Hat Bugzilla. I recommend reviewing every use of g_signal_connect* in gnome-calendar, as this seems highly likely to reveal more similar crashers. A quick count with 'git grep' reveals there about 90 of these to audit.GNOME 3.34Michael CatanzaroMichael Catanzarohttps://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/421Huge warning spam when starting calendar, including: "gsignal.c:2647: instanc...2019-11-08T17:51:46ZMichael CatanzaroHuge warning spam when starting calendar, including: "gsignal.c:2647: instance '0x198ac60' has no handler with id '262'"I see a huge warning spam when starting gnome-calendar git master:
```
$ jhbuild run gnome-calendar
(gnome-calendar:71138): dzl-menu-manager-WARNING **: 12:10:32.552: Link of type "section" missing "id=". Merging will not be possible.
...I see a huge warning spam when starting gnome-calendar git master:
```
$ jhbuild run gnome-calendar
(gnome-calendar:71138): dzl-menu-manager-WARNING **: 12:10:32.552: Link of type "section" missing "id=". Merging will not be possible.
(gnome-calendar:71138): GcalManager-WARNING **: 12:10:33.338: Failed to open/connect to calendar: Unable to connect to “Birthdays & Anniversaries”: The name is not activatable
(gnome-calendar:71138): GLib-GObject-WARNING **: 12:10:33.338: ../../../../Projects/glib/gobject/gsignal.c:2647: instance '0x198ac60' has no handler with id '262'
(gnome-calendar:71138): GcalManager-WARNING **: 12:10:33.339: Failed to open/connect to calendar: Unable to connect to “Personal”: The name is not activatable
(gnome-calendar:71138): GLib-GObject-WARNING **: 12:10:33.339: ../../../../Projects/glib/gobject/gsignal.c:2647: instance '0x198ad60' has no handler with id '268'
(gnome-calendar:71138): GcalManager-WARNING **: 12:10:33.339: Failed to open/connect to calendar: Unable to connect to “GNOME 3.34”: The name is not activatable
(gnome-calendar:71138): GLib-GObject-WARNING **: 12:10:33.339: ../../../../Projects/glib/gobject/gsignal.c:2647: instance '0x198ace0' has no handler with id '265'
```
The e-d-s issues might be related to my host running e-d-s 3.32 instead of 3.33 that gnome-calendar is probably expecting. But at least the gsignal issues are serious and need fixed. I would use G_DEBUG=fatal-warnings to get a backtrace to those, but first the warnings that appear first would need to be solved, and I've fixed enough crashes just now that I don't plan to help with those, sorry.GNOME 3.34Michael CatanzaroMichael Catanzarohttps://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/413Multiday events in Month view are not properly allocated2019-07-08T02:36:22ZGeorges Basile Stavracas NetoMultiday events in Month view are not properly allocatedGNOME 3.34Georges Basile Stavracas NetoGeorges Basile Stavracas Netohttps://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/410Follow-up fixes to the Calendar Management dialog2019-07-08T02:36:21ZGeorges Basile Stavracas NetoFollow-up fixes to the Calendar Management dialogGNOME 3.34Georges Basile Stavracas NetoGeorges Basile Stavracas Netohttps://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/400Fix Flatpak Nightly2019-06-16T01:07:32ZGeorges Basile Stavracas NetoFix Flatpak NightlyGNOME 3.34Georges Basile Stavracas NetoGeorges Basile Stavracas Netohttps://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/100the month Label 'January' not shown in detailed entry dialog2019-11-08T17:51:51ZGeorges Basile Stavracas Netothe month Label 'January' not shown in detailed entry dialogCreated attachment 343468
detailed entry (image)
On a fresh start of gnome-calendar, the 'January' label is not shown. in calendar drop down in detailed entry dialog.
This probably happens only when current month is 'January'.
How to r...Created attachment 343468
detailed entry (image)
On a fresh start of gnome-calendar, the 'January' label is not shown. in calendar drop down in detailed entry dialog.
This probably happens only when current month is 'January'.
How to reproduce:
1. Close all instances of gnome-calendar and open a new one.
2. Click some day on January (month view) -> Edit
3. Click on event begin dropdown.
Result:
The label 'January' is marked blank.
Please see the attached screenshot.
**Attachment 343468**, "detailed entry (image)":
![detailed-entry-jan](/uploads/13fd1ddcea401f74175cbae55eae7fb1/detailed-entry-jan.png)
**[Link to original bug (#777245)](https://bugzilla.gnome.org/show_bug.cgi?id=777245)**
## Design Tasks
TODO
## Development Tasks
TODO
## QA Tasks
TODOGNOME 3.34Nick GassonNick Gasson