Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-calculator gnome-calculator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 105
    • Issues 105
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-calculatorgnome-calculator
  • Merge requests
  • !117

Remove currency symbols when pasting

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Corey Berla requested to merge coreyberla/gnome-calculator:currency_symbol into master Jun 28, 2022
  • Overview 5
  • Commits 1
  • Pipelines 2
  • Changes 1

When pasting a value into calculator, remove major currency symbols (dollar, pound, euro, and yen). I'm not aware of anywhere in the source view that those symbols would be used (the currency conversion is outside the source view).

This issue was brought up in #224 (closed), but I believe that it is worth consideration. Even if we don't include all symbols, doesn't mean we shouldn't include the ones that are used commonly.

Pasting numbers with a currency symbol is a common use case for the calculator app. Both the Windows and Mac OS core calculator apps automatically remove the "$" symbol.

I don't have a background with vala, so hope my code is good.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: currency_symbol