Commit 1a488c96 authored by Christian Hergert's avatar Christian Hergert

build: fix a number of -Wmissing-declarations

parent 5be1b12f
Pipeline #15945 passed with stage
in 17 minutes and 1 second
......@@ -102,5 +102,15 @@ IDE_AVAILABLE_IN_ALL
gboolean ide_buffer_manager_apply_edits_finish (IdeBufferManager *self,
GAsyncResult *result,
GError **error);
IDE_AVAILABLE_IN_ALL
guint ide_buffer_manager_get_auto_save_timeout (IdeBufferManager *self);
IDE_AVAILABLE_IN_ALL
void ide_buffer_manager_set_auto_save_timeout (IdeBufferManager *self,
guint auto_save_timeout);
IDE_AVAILABLE_IN_ALL
gboolean ide_buffer_manager_get_auto_save (IdeBufferManager *self);
IDE_AVAILABLE_IN_ALL
void ide_buffer_manager_set_auto_save (IdeBufferManager *self,
gboolean auto_save_timeout);
G_END_DECLS
......@@ -159,5 +159,7 @@ IDE_AVAILABLE_IN_3_28
gboolean ide_buffer_get_failed (IdeBuffer *self);
IDE_AVAILABLE_IN_3_28
const GError *ide_buffer_get_failure (IdeBuffer *self);
IDE_AVAILABLE_IN_ALL
gboolean ide_buffer_get_has_diagnostics (IdeBuffer *self);
G_END_DECLS
......@@ -20,10 +20,11 @@
#define G_LOG_DOMAIN "ide-completion-provider"
#include "ide-completion-context.h"
#include "ide-completion-proposal.h"
#include "ide-completion-provider.h"
#include "ide-completion-list-box-row.h"
#include "completion/ide-completion-context.h"
#include "completion/ide-completion-private.h"
#include "completion/ide-completion-proposal.h"
#include "completion/ide-completion-provider.h"
#include "completion/ide-completion-list-box-row.h"
G_DEFINE_INTERFACE (IdeCompletionProvider, ide_completion_provider, G_TYPE_OBJECT)
......
......@@ -47,5 +47,8 @@ IdeDebuggerBreakpoints *ide_debug_manager_get_breakpoints_for_file (IdeDebugMana
IDE_AVAILABLE_IN_ALL
gboolean ide_debug_manager_supports_language (IdeDebugManager *self,
const gchar *language_id);
IDE_AVAILABLE_IN_ALL
IdeDebugger *ide_debug_manager_find_debugger (IdeDebugManager *self,
IdeRunner *runner);
G_END_DECLS
......@@ -53,12 +53,6 @@ enum {
static GParamSpec *properties [LAST_PROP];
IdeDirectoryBuildSystem *
ide_directory_build_system_new (void)
{
return g_object_new (IDE_TYPE_DIRECTORY_BUILD_SYSTEM, NULL);
}
static void
ide_directory_build_system_finalize (GObject *object)
{
......
......@@ -20,6 +20,7 @@
#include "config.h"
#include "editor/ide-editor-private.h"
#include "editor/ide-editor-search-bar.h"
static void
......
......@@ -219,12 +219,6 @@ ide_langserv_diagnostic_provider_init (IdeLangservDiagnosticProvider *self)
G_CONNECT_SWAPPED);
}
IdeLangservDiagnosticProvider *
ide_langserv_diagnostic_provider_new (void)
{
return g_object_new (IDE_TYPE_LANGSERV_DIAGNOSTIC_PROVIDER, NULL);
}
/**
* ide_langserv_diagnostic_provider_get_client:
*
......
......@@ -40,6 +40,9 @@ GFile *ide_project_info_get_file (IdeProjectInfo *self);
IDE_AVAILABLE_IN_ALL
IdeDoap *ide_project_info_get_doap (IdeProjectInfo *self);
IDE_AVAILABLE_IN_ALL
void ide_project_info_set_doap (IdeProjectInfo *self,
IdeDoap *doap);
IDE_AVAILABLE_IN_ALL
const gchar *ide_project_info_get_build_system_name (IdeProjectInfo *self);
IDE_AVAILABLE_IN_ALL
const gchar *ide_project_info_get_description (IdeProjectInfo *self);
......
......@@ -129,7 +129,7 @@ ide_project_item_get_parent (IdeProjectItem *item)
return priv->parent;
}
void
static void
ide_project_item_set_parent (IdeProjectItem *item,
IdeProjectItem *parent)
{
......
......@@ -34,6 +34,8 @@ struct _IdeProjectItemClass
IdeObjectClass parent_class;
};
IDE_AVAILABLE_IN_ALL
IdeProjectItem *ide_project_item_new (IdeProjectItem *parent);
IDE_AVAILABLE_IN_ALL
IdeProjectItem *ide_project_item_get_parent (IdeProjectItem *item);
IDE_AVAILABLE_IN_ALL
......
......@@ -1257,36 +1257,6 @@ ide_runner_take_fd (IdeRunner *self,
return dest_fd;
}
guint
ide_runner_get_n_fd_mappings (IdeRunner *self)
{
IdeRunnerPrivate *priv = ide_runner_get_instance_private (self);
g_return_val_if_fail (IDE_IS_RUNNER (self), 0);
return priv->fd_mapping ? priv->fd_mapping->len : 0;
}
gint
ide_runner_get_nth_fd_maping (IdeRunner *self,
guint i,
gint *dest_fd)
{
IdeRunnerPrivate *priv = ide_runner_get_instance_private (self);
FdMapping *map;
g_return_val_if_fail (IDE_IS_RUNNER (self), -1);
g_return_val_if_fail (priv->fd_mapping != NULL, -1);
g_return_val_if_fail (i < priv->fd_mapping->len, -1);
g_return_val_if_fail (dest_fd != NULL, -1);
map = &g_array_index (priv->fd_mapping, FdMapping, i);
*dest_fd = map->dest_fd;
return map->source_fd;
}
/**
* ide_runner_get_runtime:
* @self: An #IdeRuntime
......
......@@ -31,6 +31,7 @@
#include "devices/ide-device.h"
#include "runtimes/ide-runtime.h"
#include "runtimes/ide-runtime-manager.h"
#include "runtimes/ide-runtime-private.h"
#include "runtimes/ide-runtime-provider.h"
#include "threading/ide-task.h"
......
......@@ -51,7 +51,7 @@ ide_runtime_provider_real_can_install (IdeRuntimeProvider *self,
return FALSE;
}
void
static void
ide_runtime_provider_real_install_async (IdeRuntimeProvider *self,
const gchar *runtime_id,
GCancellable *cancellable,
......@@ -66,7 +66,7 @@ ide_runtime_provider_real_install_async (IdeRuntimeProvider *self,
G_OBJECT_TYPE_NAME (self));
}
gboolean
static gboolean
ide_runtime_provider_real_install_finish (IdeRuntimeProvider *self,
GAsyncResult *result,
GError **error)
......@@ -112,7 +112,7 @@ ide_runtime_provider_real_bootstrap_cb (GObject *object,
ide_task_return_pointer (task, g_object_ref (runtime), g_object_unref);
}
void
static void
ide_runtime_provider_real_bootstrap_async (IdeRuntimeProvider *self,
IdeBuildPipeline *pipeline,
GCancellable *cancellable,
......@@ -152,7 +152,7 @@ ide_runtime_provider_real_bootstrap_async (IdeRuntimeProvider *self,
IDE_EXIT;
}
IdeRuntime *
static IdeRuntime *
ide_runtime_provider_real_bootstrap_finish (IdeRuntimeProvider *self,
GAsyncResult *result,
GError **error)
......
......@@ -35,6 +35,7 @@
#include "debugger/ide-debugger-private.h"
#include "files/ide-file.h"
#include "sourceview/ide-omni-gutter-renderer.h"
#include "sourceview/ide-omni-gutter-renderer-private.h"
#include "sourceview/ide-source-view.h"
/**
......
......@@ -171,7 +171,7 @@ ide_toolchain_get_host_triplet (IdeToolchain *self)
return ide_triplet_ref (priv->host_triplet);
}
const gchar *
static const gchar *
ide_toolchain_real_get_tool_for_language (IdeToolchain *self,
const gchar *language,
const gchar *tool_id)
......@@ -183,7 +183,7 @@ ide_toolchain_real_get_tool_for_language (IdeToolchain *self,
return NULL;
}
GHashTable *
static GHashTable *
ide_toolchain_real_get_tools_for_id (IdeToolchain *self,
const gchar *tool_id)
{
......
......@@ -55,7 +55,7 @@ ide_progress_get_completed (IdeProgress *self)
return self->completed;
}
void
static void
ide_progress_set_completed (IdeProgress *self,
gboolean completed)
{
......
......@@ -32,6 +32,8 @@ G_DECLARE_FINAL_TYPE (IdeProgress, ide_progress, IDE, PROGRESS, GObject)
IDE_AVAILABLE_IN_ALL
IdeProgress *ide_progress_new (void);
IDE_AVAILABLE_IN_ALL
gboolean ide_progress_get_completed (IdeProgress *self);
IDE_AVAILABLE_IN_ALL
gdouble ide_progress_get_fraction (IdeProgress *self);
IDE_AVAILABLE_IN_ALL
gchar *ide_progress_get_message (IdeProgress *self);
......
......@@ -350,7 +350,7 @@ uri_cleanup (const char *uri_string)
return g_string_free (copy, FALSE);
}
gboolean
static gboolean
parse_host (const gchar *raw_host,
IdeUriParseFlags flags,
gchar **host,
......@@ -472,7 +472,7 @@ parse_port (const gchar *raw_port,
return TRUE;
}
gboolean
static gboolean
parse_userinfo (const gchar *raw_userinfo,
IdeUriParseFlags flags,
gchar **user,
......
......@@ -28,6 +28,7 @@
#include "util/ide-gtk.h"
#include "workbench/ide-perspective.h"
#include "workbench/ide-workbench.h"
#include "workbench/ide-workbench-private.h"
#include "workbench/ide-workbench-header-bar.h"
typedef struct
......
......@@ -196,7 +196,7 @@ gbp_cmake_toolchain_provider_load_finish (IdeToolchainProvider *provider,
return TRUE;
}
void
static void
gbp_cmake_toolchain_provider_unload (IdeToolchainProvider *provider,
IdeToolchainManager *manager)
{
......
......@@ -38,17 +38,6 @@ gb_command_manager_new (void)
return g_object_new (GB_TYPE_COMMAND_MANAGER, NULL);
}
GbCommandManager *
gb_command_manager_get_default (void)
{
static GbCommandManager *instance;
if (!instance)
instance = gb_command_manager_new ();
return instance;
}
static gint
provider_compare_func (gconstpointer a,
gconstpointer b)
......
......@@ -43,7 +43,7 @@ enum {
static GParamSpec *properties [LAST_PROP];
GtkWidget *
static GtkWidget *
gb_command_vim_get_active_widget (GbCommandVim *vim)
{
g_return_val_if_fail (GB_IS_COMMAND_VIM (vim), NULL);
......@@ -62,7 +62,7 @@ gb_command_vim_set_active_widget (GbCommandVim *vim,
g_object_notify_by_pspec (G_OBJECT (vim), properties [PROP_ACTIVE_WIDGET]);
}
const gchar *
static const gchar *
gb_command_vim_get_command_text (GbCommandVim *vim)
{
g_return_val_if_fail (GB_IS_COMMAND_VIM (vim), NULL);
......@@ -70,7 +70,7 @@ gb_command_vim_get_command_text (GbCommandVim *vim)
return vim->command_text;
}
void
static void
gb_command_vim_set_command_text (GbCommandVim *vim,
const gchar *command_text)
{
......
......@@ -26,5 +26,4 @@ G_BEGIN_DECLS
G_DECLARE_FINAL_TYPE (GbCommandVim, gb_command_vim, GB, COMMAND_VIM, GbCommand)
G_END_DECLS
......@@ -30,7 +30,6 @@
void _ide_ctags_index_register_type (GTypeModule *module);
void _ide_ctags_builder_register_type (GTypeModule *module);
void _ide_ctags_completion_item_register_type (GTypeModule *module);
void _ide_ctags_completion_provider_register_type (GTypeModule *module);
void _ide_ctags_highlighter_register_type (GTypeModule *module);
void _ide_ctags_service_register_type (GTypeModule *module);
......@@ -40,7 +39,6 @@ void
ide_ctags_register_types (PeasObjectModule *module)
{
_ide_ctags_index_register_type (G_TYPE_MODULE (module));
_ide_ctags_completion_item_register_type (G_TYPE_MODULE (module));
_ide_ctags_completion_provider_register_type (G_TYPE_MODULE (module));
_ide_ctags_highlighter_register_type (G_TYPE_MODULE (module));
_ide_ctags_service_register_type (G_TYPE_MODULE (module));
......
......@@ -25,11 +25,10 @@
#include "ide-ctags-index.h"
#include "ide-ctags-results.h"
G_DEFINE_DYNAMIC_TYPE_EXTENDED (IdeCtagsCompletionItem,
ide_ctags_completion_item,
G_TYPE_OBJECT,
0,
G_IMPLEMENT_INTERFACE (IDE_TYPE_COMPLETION_PROPOSAL, NULL))
G_DEFINE_TYPE_WITH_CODE (IdeCtagsCompletionItem,
ide_ctags_completion_item,
G_TYPE_OBJECT,
G_IMPLEMENT_INTERFACE (IDE_TYPE_COMPLETION_PROPOSAL, NULL))
DZL_DEFINE_COUNTER (instances, "IdeCtagsCompletionItem", "Instances", "Number of IdeCtagsCompletionItems")
......@@ -75,23 +74,12 @@ ide_ctags_completion_item_class_init (IdeCtagsCompletionItemClass *klass)
object_class->finalize = ide_ctags_completion_item_finalize;
}
static void
ide_ctags_completion_item_class_finalize (IdeCtagsCompletionItemClass *klass)
{
}
static void
ide_ctags_completion_item_init (IdeCtagsCompletionItem *self)
{
DZL_COUNTER_INC (instances);
}
void
_ide_ctags_completion_item_register_type (GTypeModule *module)
{
ide_ctags_completion_item_register_type (module);
}
gboolean
ide_ctags_completion_item_is_function (IdeCtagsCompletionItem *self)
{
......
......@@ -206,13 +206,13 @@ get_devhelp_book (GbpDevhelpDocumentationProvider *self,
return TRUE;
}
gchar *
static gchar *
gbp_devhelp_documentation_provider_get_name (IdeDocumentationProvider *provider)
{
return g_strdup ("Devhelp");
}
gboolean
static gboolean
start_get_info (IdeDocumentationProvider *provider,
IdeDocumentationInfo *info)
{
......@@ -233,7 +233,7 @@ start_get_info (IdeDocumentationProvider *provider,
return xml_parse (self, tokens[0], tokens[1], info);
}
void
static void
gbp_devhelp_documentation_provider_get_info (IdeDocumentationProvider *provider,
IdeDocumentationInfo *info)
{
......@@ -253,7 +253,7 @@ gbp_devhelp_documentation_provider_get_info (IdeDocumentationProvider *provider,
}
}
IdeDocumentationContext
static IdeDocumentationContext
gbp_devhelp_documentation_provider_get_context (IdeDocumentationProvider *provider)
{
GbpDevhelpDocumentationProvider *self = (GbpDevhelpDocumentationProvider *)provider;
......
......@@ -58,7 +58,7 @@ gbp_documentation_card__button_clicked (GbpDocumentationCard *self,
}
void
static void
gbp_documentation_card_closed (GtkPopover *popover)
{
GbpDocumentationCard *self = (GbpDocumentationCard *)popover;
......
......@@ -391,12 +391,12 @@ gbp_flatpak_clone_widget_worker (IdeTask *task,
else if (req->src->type == TYPE_ARCHIVE)
{
uristr = ide_vcs_uri_to_string (req->src->uri);
req->project_file = fetch_archive (uristr,
req->src->sha,
req->src->name,
req->destination,
self->strip_components,
&error);
req->project_file = gbp_flatpak_sources_fetch_archive (uristr,
req->src->sha,
req->src->name,
req->destination,
self->strip_components,
&error);
if (error != NULL)
{
ide_task_return_error (task, g_steal_pointer (&error));
......@@ -406,11 +406,11 @@ gbp_flatpak_clone_widget_worker (IdeTask *task,
for (i = 0; req->src->patches[i]; i++)
{
if (!apply_patch (req->src->patches[i],
req->project_file,
self->strip_components,
&error))
{
if (!gbp_flatpak_sources_apply_patch (req->src->patches[i],
req->project_file,
self->strip_components,
&error))
{
ide_task_return_error (task, g_steal_pointer (&error));
return;
}
......
......@@ -715,7 +715,7 @@ gbp_flatpak_runtime_provider_bootstrap_finish (IdeRuntimeProvider *provider,
IDE_RETURN (ret);
}
void
static void
gbp_flatpak_runtime_provider_locate_sdk_async (GbpFlatpakRuntimeProvider *self,
const gchar *id,
const gchar *arch,
......
......@@ -44,13 +44,13 @@ typedef enum {
ZIP
} ArchiveType;
gboolean
static gboolean
is_tar (ArchiveType type)
{
return (type >= TAR) && (type <= TAR_XZ);
}
const char *
static const char *
tar_decompress_flag (ArchiveType type)
{
if (type == TAR_GZIP)
......@@ -71,7 +71,7 @@ tar_decompress_flag (ArchiveType type)
return NULL;
}
ArchiveType
static ArchiveType
get_type (GFile *archivefile)
{
g_autofree gchar *base_name = NULL;
......@@ -434,7 +434,7 @@ create_uncompress_directory (GFile *dest,
return uncompress_dest;
}
SoupSession *
static SoupSession *
get_soup_session (void)
{
return soup_session_new_with_options (SOUP_SESSION_USER_AGENT, PACKAGE_NAME,
......@@ -566,12 +566,12 @@ extract_archive (GFile *destination,
}
GFile *
fetch_archive (const gchar *url,
const gchar *sha,
const gchar *module_name,
GFile *destination,
guint strip_components,
GError **error)
gbp_flatpak_sources_fetch_archive (const gchar *url,
const gchar *sha,
const gchar *module_name,
GFile *destination,
guint strip_components,
GError **error)
{
g_autoptr(GFile) archive_file = NULL;
g_autoptr(GFile) source_dir = NULL;
......@@ -605,10 +605,10 @@ fetch_archive (const gchar *url,
}
gboolean
apply_patch (const gchar *path,
GFile *source_dir,
guint strip_components,
GError **error)
gbp_flatpak_sources_apply_patch (const gchar *path,
GFile *source_dir,
guint strip_components,
GError **error)
{
g_autoptr(GFile) patchfile = NULL;
g_autofree char *patch_path = NULL;
......
......@@ -18,14 +18,13 @@
#pragma once
GFile *fetch_archive (const gchar *url,
const gchar *sha,
const gchar *module_name,
GFile *destination,
guint strip_components,
GError **error);
gboolean apply_patch (const gchar *path,
GFile *source_dir,
guint strip_components,
GError **error);
GFile *gbp_flatpak_sources_fetch_archive (const gchar *url,
const gchar *sha,
const gchar *module_name,
GFile *destination,
guint strip_components,
GError **error);
gboolean gbp_flatpak_sources_apply_patch (const gchar *path,
GFile *source_dir,
guint strip_components,
GError **error);
......@@ -30,12 +30,6 @@ static void vcs_initializer_init (IdeVcsInitializerInterface *iface);
G_DEFINE_TYPE_EXTENDED (IdeGitVcsInitializer, ide_git_vcs_initializer, G_TYPE_OBJECT, 0,
G_IMPLEMENT_INTERFACE (IDE_TYPE_VCS_INITIALIZER, vcs_initializer_init))
IdeGitVcsInitializer *
ide_git_vcs_initializer_new (void)
{
return g_object_new (IDE_TYPE_GIT_VCS_INITIALIZER, NULL);
}
static void
ide_git_vcs_initializer_class_init (IdeGitVcsInitializerClass *klass)
{
......
......@@ -663,7 +663,7 @@ gbp_meson_build_system_get_builddir (IdeBuildSystem *build_system,
return NULL;
}
gboolean
static gboolean
gbp_meson_build_system_supports_toolchain (IdeBuildSystem *self,
IdeToolchain *toolchain)
{
......
......@@ -128,7 +128,7 @@ toolchain_edition_preferences_get_add_widget (GbpMesonToolchainEditionPreference
return bin;
}
void
static void
gbp_meson_toolchain_edition_preferences_addin_load_finish (GObject *object,
GAsyncResult *result,
gpointer user_data)
......
......@@ -132,7 +132,7 @@ gbp_meson_toolchain_provider_load_worker (IdeTask *task,
(GDestroyNotify)g_ptr_array_unref);
}
void
static void
meson_toolchain_provider_search_finish (FileSearching *file_searching,
GError *error)
{
......@@ -153,7 +153,7 @@ meson_toolchain_provider_search_finish (FileSearching *file_searching,
ide_task_run_in_thread (task, gbp_meson_toolchain_provider_load_worker);
}
void
static void
add_all_files (GFile *array,
GPtrArray *dest_array)
{
......@@ -162,7 +162,7 @@ add_all_files (GFile *array,
g_ptr_array_add (dest_array, g_object_ref (array));
}
void
static void
meson_toolchain_provider_search_iterate (GObject *object,
GAsyncResult *result,
gpointer user_data)
......@@ -200,7 +200,7 @@ meson_toolchain_provider_search_iterate (GObject *object,
meson_toolchain_provider_search_finish (file_searching, NULL);
}
void
static void
meson_toolchain_provider_search_init (GbpMesonToolchainProvider *self,
GCancellable *cancellable,
GAsyncReadyCallback callback,
......@@ -300,7 +300,7 @@ gbp_meson_toolchain_provider_load_finish (IdeToolchainProvider *provider,
return TRUE;
}
void
static void
gbp_meson_toolchain_provider_unload (IdeToolchainProvider *provider,
IdeToolchainManager *manager)
{
......
......@@ -419,7 +419,7 @@ gbp_sysroot_manager_list (GbpSysrootManager *self)
return g_key_file_get_groups (self->key_file, NULL);
}
void
static void
gbp_sysroot_manager_finalize (GObject *object)
{
GbpSysrootManager *self = GBP_SYSROOT_MANAGER(object);
......
......@@ -44,7 +44,7 @@ _create_tool_path (const gchar *base_path,
return g_steal_pointer (&tool_path);
}
gchar *
static gchar *
_test_sdk_dirs (const gchar *basepath,
const gchar *dir)
{
......@@ -83,7 +83,7 @@ _test_sdk_dirs (const gchar *basepath,
}
/* Yocto systems are the most used ones, but the native toolchain is in a different folder */
IdeToolchain *
static IdeToolchain *
gbp_sysroot_toolchain_provider_try_poky (GbpSysrootToolchainProvider *self,
const gchar *sysroot_id)
{
......@@ -280,7 +280,7 @@ gbp_sysroot_toolchain_provider_load_finish (IdeToolchainProvider *provider,
return TRUE;
}
void
static void
gbp_sysroot_toolchain_provider_unload (IdeToolchainProvider *provider,
IdeToolchainManager *manager)
{
......
......@@ -48,7 +48,7 @@ savetask_free (gpointer data)
}
}
gboolean
static gboolean
gb_terminal_view_actions_save_finish (GbTerminalView *view,
GAsyncResult *result,
GError **error)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment