Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-builder gnome-builder
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 308
    • Issues 308
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-buildergnome-builder
  • Merge requests
  • !87

Update JavaScript/GJS Meson template to ES6.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Evan Welsh requested to merge ewlsh/gnome-builder:wip/rockon999/gjs-es6-template into master Jul 30, 2018
  • Overview 13
  • Commits 3
  • Pipelines 4
  • Changes 3

This merge request updates the current Meson template for GJS and makes a small change for other templates.

Impacts GJS' template:

  • Utilizes modern import syntax
  • Cleans up variable names in main.js
  • Uses the correct getter for active_window instead of the property
  • Use headerBar instead of header_bar in the UI file. We use camelCase for any non-introspected function/object.

Impacts all languages' template:

  • Converts the window.js custom GObject class to ES6 syntax, Lang.Class is deprecated
  • Adds a GTK+ version specifier in the window.ui file. This is mainly so when it is opened in Glade, Glade knows what version we're targeting and doesn't hide features. The Glade default is 3.10 so if we don't specify 3.20 a ton of new widgets and features are "hidden" in Glade and unknown to the user. Plus it is good practice to specify the version the UI is targeting.
Edited Jul 30, 2018 by Evan Welsh
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/rockon999/gjs-es6-template