From 0bfea484d86acee71144b34144f4d8dedb124b87 Mon Sep 17 00:00:00 2001
From: Alexander Mikhaylenko <alexm@gnome.org>
Date: Thu, 2 Mar 2023 08:32:46 +0400
Subject: [PATCH 1/8] libide/tree: Add bottom undershoot to the project tree

Since there's a search entry there now it looks strange without it.
---
 src/libide/tree/ide-tree.ui | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/libide/tree/ide-tree.ui b/src/libide/tree/ide-tree.ui
index f46772e44..5d7ebfb22 100644
--- a/src/libide/tree/ide-tree.ui
+++ b/src/libide/tree/ide-tree.ui
@@ -23,6 +23,7 @@
             </property>
             <style>
               <class name="navigation-sidebar"/>
+              <class name="bottom-shadow-when-scroll"/>
             </style>
           </object>
         </child>
-- 
GitLab


From 2b5d061b1425c54406f71386488603a733f43591 Mon Sep 17 00:00:00 2001
From: Alexander Mikhaylenko <alexm@gnome.org>
Date: Thu, 2 Mar 2023 08:33:21 +0400
Subject: [PATCH 2/8] plugins/project-tree: Normalize margins around search
 entry

We use 6px for toolbars and such.
---
 src/plugins/project-tree/gbp-project-tree-pane.ui | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/plugins/project-tree/gbp-project-tree-pane.ui b/src/plugins/project-tree/gbp-project-tree-pane.ui
index bd7aefa59..47fb05125 100644
--- a/src/plugins/project-tree/gbp-project-tree-pane.ui
+++ b/src/plugins/project-tree/gbp-project-tree-pane.ui
@@ -111,10 +111,10 @@
             <signal name="search-started" handler="on_search_cb" swapped="true"/>
             <signal name="activate" handler="on_search_activate_cb" swapped="true"/>
             <property name="placeholder-text" translatable="yes">Filter</property>
-            <property name="margin-start">3</property>
-            <property name="margin-end">3</property>
-            <property name="margin-top">3</property>
-            <property name="margin-bottom">3</property>
+            <property name="margin-start">6</property>
+            <property name="margin-end">6</property>
+            <property name="margin-top">6</property>
+            <property name="margin-bottom">6</property>
           </object>
         </child>
       </object>
-- 
GitLab


From 2e1a95fc17b36d5325883c25eee37f83b4e17efb Mon Sep 17 00:00:00 2001
From: Alexander Mikhaylenko <alexm@gnome.org>
Date: Thu, 2 Mar 2023 08:35:33 +0400
Subject: [PATCH 3/8] Sync undershoot style class names with libadwaita

Libadwaita will have undershoot styles next cycle, so use the same names
as that.
---
 src/libide/greeter/ide-greeter-workspace.ui       | 2 +-
 src/libide/gui/style.css                          | 4 ++--
 src/libide/tree/ide-tree.ui                       | 2 +-
 src/plugins/buildui/gbp-buildui-status-popover.ui | 4 ++--
 src/plugins/buildui/gbp-buildui-targets-dialog.c  | 2 +-
 src/plugins/symbol-tree/gbp-symbol-popover.ui     | 2 +-
 src/plugins/vcsui/gbp-vcsui-clone-page.ui         | 2 +-
 src/plugins/vcsui/gbp-vcsui-switcher-popover.ui   | 4 ++--
 8 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/libide/greeter/ide-greeter-workspace.ui b/src/libide/greeter/ide-greeter-workspace.ui
index a4fb6b4f4..daaf9f905 100644
--- a/src/libide/greeter/ide-greeter-workspace.ui
+++ b/src/libide/greeter/ide-greeter-workspace.ui
@@ -55,7 +55,7 @@
                 <child>
                   <object class="GtkScrolledWindow" id="scroller">
                     <style>
-                      <class name="shadow-when-scroll"/>
+                      <class name="undershoot-top"/>
                     </style>
                     <property name="vexpand">true</property>
                     <property name="hscrollbar-policy">never</property>
diff --git a/src/libide/gui/style.css b/src/libide/gui/style.css
index 6db1fd54c..9e81ab651 100644
--- a/src/libide/gui/style.css
+++ b/src/libide/gui/style.css
@@ -50,11 +50,11 @@ notificationstack button {
   background: none;
 }
 
-scrolledwindow.shadow-when-scroll undershoot.top {
+scrolledwindow.undershoot-top undershoot.top {
   box-shadow: inset 0px 5px 14px -14px rgba(0,0,0,.9);
 }
 
-scrolledwindow.bottom-shadow-when-scroll undershoot.bottom {
+scrolledwindow.undershoot-bottom undershoot.bottom {
   box-shadow: inset 0px -5px 14px -14px rgba(0,0,0,.9);
 }
 
diff --git a/src/libide/tree/ide-tree.ui b/src/libide/tree/ide-tree.ui
index 5d7ebfb22..6cd17699f 100644
--- a/src/libide/tree/ide-tree.ui
+++ b/src/libide/tree/ide-tree.ui
@@ -23,7 +23,7 @@
             </property>
             <style>
               <class name="navigation-sidebar"/>
-              <class name="bottom-shadow-when-scroll"/>
+              <class name="undershoot-bottom"/>
             </style>
           </object>
         </child>
diff --git a/src/plugins/buildui/gbp-buildui-status-popover.ui b/src/plugins/buildui/gbp-buildui-status-popover.ui
index d8f44d334..81bad0e89 100644
--- a/src/plugins/buildui/gbp-buildui-status-popover.ui
+++ b/src/plugins/buildui/gbp-buildui-status-popover.ui
@@ -38,7 +38,7 @@
                     <property name="min-content-width">400</property>
                     <property name="max-content-width">400</property>
                     <style>
-                      <class name="shadow-when-scroll"/>
+                      <class name="undershoot-top"/>
                     </style>
                     <child>
                       <object class="GtkListView">
@@ -79,7 +79,7 @@
                     <property name="min-content-width">400</property>
                     <property name="max-content-width">400</property>
                     <style>
-                      <class name="shadow-when-scroll"/>
+                      <class name="undershoot-top"/>
                     </style>
                     <child>
                       <object class="GtkListView">
diff --git a/src/plugins/buildui/gbp-buildui-targets-dialog.c b/src/plugins/buildui/gbp-buildui-targets-dialog.c
index 8e5271ba3..3ede12698 100644
--- a/src/plugins/buildui/gbp-buildui-targets-dialog.c
+++ b/src/plugins/buildui/gbp-buildui-targets-dialog.c
@@ -275,6 +275,6 @@ gbp_buildui_targets_dialog_init (GbpBuilduiTargetsDialog *self)
        child = gtk_widget_get_next_sibling (child))
     {
       if (GTK_IS_SCROLLED_WINDOW (child))
-        gtk_widget_add_css_class (child, "shadow-when-scroll");
+        gtk_widget_add_css_class (child, "undershoot-top");
     }
 }
diff --git a/src/plugins/symbol-tree/gbp-symbol-popover.ui b/src/plugins/symbol-tree/gbp-symbol-popover.ui
index b3cc33787..d854f0c8d 100644
--- a/src/plugins/symbol-tree/gbp-symbol-popover.ui
+++ b/src/plugins/symbol-tree/gbp-symbol-popover.ui
@@ -17,7 +17,7 @@
             <property name="min-content-width">400</property>
             <property name="max-content-width">400</property>
             <style>
-              <class name="bottom-shadow-when-scroll"/>
+              <class name="undershoot-bottom"/>
             </style>
             <child>
               <object class="GtkListView" id="list_view">
diff --git a/src/plugins/vcsui/gbp-vcsui-clone-page.ui b/src/plugins/vcsui/gbp-vcsui-clone-page.ui
index b703b30f5..a4076ad70 100644
--- a/src/plugins/vcsui/gbp-vcsui-clone-page.ui
+++ b/src/plugins/vcsui/gbp-vcsui-clone-page.ui
@@ -72,7 +72,7 @@
                                 <property name="max-content-width">300</property>
                                 <property name="max-content-height">500</property>
                                 <style>
-                                  <class name="shadow-when-scroll"/>
+                                  <class name="undershoot-top"/>
                                 </style>
                                 <child>
                                   <object class="GtkListView">
diff --git a/src/plugins/vcsui/gbp-vcsui-switcher-popover.ui b/src/plugins/vcsui/gbp-vcsui-switcher-popover.ui
index 65beb890e..a3e90ac59 100644
--- a/src/plugins/vcsui/gbp-vcsui-switcher-popover.ui
+++ b/src/plugins/vcsui/gbp-vcsui-switcher-popover.ui
@@ -35,7 +35,7 @@
                     <property name="min-content-width">300</property>
                     <property name="max-content-width">300</property>
                     <style>
-                      <class name="shadow-when-scroll"/>
+                      <class name="undershoot-top"/>
                     </style>
                     <child>
                       <object class="GtkListView" id="branches_view">
@@ -101,7 +101,7 @@
                     <property name="min-content-width">300</property>
                     <property name="max-content-width">300</property>
                     <style>
-                      <class name="shadow-when-scroll"/>
+                      <class name="undershoot-top"/>
                     </style>
                     <child>
                       <object class="GtkListView" id="tags_view">
-- 
GitLab


From da743a743cfc63c891eade75b9a0659859049249 Mon Sep 17 00:00:00 2001
From: Alexander Mikhaylenko <alexm@gnome.org>
Date: Thu, 2 Mar 2023 08:42:10 +0400
Subject: [PATCH 4/8] Support undershoot for preferences pages as well

---
 src/libide/gui/style.css                                | 6 ++++--
 src/plugins/create-project/gbp-create-project-widget.ui | 3 +++
 src/plugins/vcsui/gbp-vcsui-clone-page.ui               | 3 +++
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/libide/gui/style.css b/src/libide/gui/style.css
index 9e81ab651..46c2d91f7 100644
--- a/src/libide/gui/style.css
+++ b/src/libide/gui/style.css
@@ -50,11 +50,13 @@ notificationstack button {
   background: none;
 }
 
-scrolledwindow.undershoot-top undershoot.top {
+scrolledwindow.undershoot-top > undershoot.top,
+preferencespage.undershoot-top > scrolledwindow > undershoot.top {
   box-shadow: inset 0px 5px 14px -14px rgba(0,0,0,.9);
 }
 
-scrolledwindow.undershoot-bottom undershoot.bottom {
+scrolledwindow.undershoot-bottom > undershoot.bottom,
+preferencespage.undershoot-bottom > scrolledwindow > undershoot.bottom {
   box-shadow: inset 0px -5px 14px -14px rgba(0,0,0,.9);
 }
 
diff --git a/src/plugins/create-project/gbp-create-project-widget.ui b/src/plugins/create-project/gbp-create-project-widget.ui
index d34833ed7..d7d07f114 100644
--- a/src/plugins/create-project/gbp-create-project-widget.ui
+++ b/src/plugins/create-project/gbp-create-project-widget.ui
@@ -3,6 +3,9 @@
   <template class="GbpCreateProjectWidget" parent="GtkWidget">
     <child>
       <object class="AdwPreferencesPage" id="main">
+        <style>
+          <class name="undershoot-top"/>
+        </style>
         <child>
           <object class="AdwPreferencesGroup">
             <child>
diff --git a/src/plugins/vcsui/gbp-vcsui-clone-page.ui b/src/plugins/vcsui/gbp-vcsui-clone-page.ui
index a4076ad70..b1a2a64dd 100644
--- a/src/plugins/vcsui/gbp-vcsui-clone-page.ui
+++ b/src/plugins/vcsui/gbp-vcsui-clone-page.ui
@@ -4,6 +4,9 @@
   <template class="GbpVcsuiClonePage" parent="GtkWidget">
     <child>
       <object class="AdwPreferencesPage" id="main">
+        <style>
+          <class name="undershoot-top"/>
+        </style>
         <child>
           <object class="AdwPreferencesGroup">
             <property name="margin-top">36</property>
-- 
GitLab


From 7d09ac08f22ee2162faadaf8ee6497573d9fe6f1 Mon Sep 17 00:00:00 2001
From: Alexander Mikhaylenko <alexm@gnome.org>
Date: Thu, 2 Mar 2023 08:53:00 +0400
Subject: [PATCH 5/8] libide/gui: Remove search list view background

---
 src/libide/gui/style.css | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/libide/gui/style.css b/src/libide/gui/style.css
index 46c2d91f7..65518de2c 100644
--- a/src/libide/gui/style.css
+++ b/src/libide/gui/style.css
@@ -36,6 +36,8 @@ popover.global-search contents .navigation-sidebar {
 }
 popover.global-search listview.results {
   padding: 6px 0;
+  background: none;
+  color: inherit;
 }
 popover.global-search listview.results row {
   min-height: 36px;
-- 
GitLab


From dd01fa40bf71895cb444c641e12fbfe81b565b82 Mon Sep 17 00:00:00 2001
From: Alexander Mikhaylenko <alexm@gnome.org>
Date: Thu, 2 Mar 2023 08:53:51 +0400
Subject: [PATCH 6/8] libide/gui: Fix search listview being truncated

It should not be in a viewport.
---
 src/libide/gui/ide-search-popover.ui | 35 ++++++++++++----------------
 1 file changed, 15 insertions(+), 20 deletions(-)

diff --git a/src/libide/gui/ide-search-popover.ui b/src/libide/gui/ide-search-popover.ui
index 7d74e4ecb..1259c77e0 100644
--- a/src/libide/gui/ide-search-popover.ui
+++ b/src/libide/gui/ide-search-popover.ui
@@ -75,23 +75,20 @@
                 <property name="hscrollbar-policy">never</property>
                 <property name="min-content-height">400</property>
                 <child>
-                  <object class="GtkViewport">
-                    <property name="scroll-to-focus">true</property>
-                    <child>
-                      <object class="GtkListView" id="list_view">
-                        <style>
-                          <class name="results"/>
-                        </style>
-                        <signal name="activate" handler="ide_search_popover_activate_cb" swapped="true" object="IdeSearchPopover"/>
-                        <property name="orientation">vertical</property>
-                        <property name="model">
-                          <object class="GtkSingleSelection" id="selection">
-                            <signal name="notify::selected-item" handler="ide_search_popover_selection_changed_cb" swapped="true" object="IdeSearchPopover"/>
-                          </object>
-                        </property>
-                        <property name="factory">
-                          <object class="GtkBuilderListItemFactory">
-                            <property name="bytes"><![CDATA[
+                  <object class="GtkListView" id="list_view">
+                    <style>
+                      <class name="results"/>
+                    </style>
+                    <signal name="activate" handler="ide_search_popover_activate_cb" swapped="true" object="IdeSearchPopover"/>
+                    <property name="orientation">vertical</property>
+                    <property name="model">
+                      <object class="GtkSingleSelection" id="selection">
+                        <signal name="notify::selected-item" handler="ide_search_popover_selection_changed_cb" swapped="true" object="IdeSearchPopover"/>
+                      </object>
+                    </property>
+                    <property name="factory">
+                      <object class="GtkBuilderListItemFactory">
+                        <property name="bytes"><![CDATA[
 <?xml version="1.0" encoding="UTF-8"?>
 <interface>
 <template class="GtkListItem">
@@ -174,11 +171,9 @@
 </template>
 </interface>
 ]]>
-                            </property>
-                          </object>
                         </property>
                       </object>
-                    </child>
+                    </property>
                   </object>
                 </child>
               </object>
-- 
GitLab


From 42828a0dd6a4183ea7bcff3cea7a15d9314a3230 Mon Sep 17 00:00:00 2001
From: Alexander Mikhaylenko <alexm@gnome.org>
Date: Thu, 2 Mar 2023 08:58:33 +0400
Subject: [PATCH 7/8] libide/terminal: Fix context menu alignment

---
 src/libide/terminal/ide-terminal.c | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/src/libide/terminal/ide-terminal.c b/src/libide/terminal/ide-terminal.c
index 766154220..eadca0c96 100644
--- a/src/libide/terminal/ide-terminal.c
+++ b/src/libide/terminal/ide-terminal.c
@@ -101,6 +101,22 @@ ide_terminal_get_colors (IdeTerminal *self,
     *fg = priv->fg;
 }
 
+static void
+ide_terminal_direction_changed (GtkWidget        *widget,
+                                GtkTextDirection  previous_direction)
+{
+  IdeTerminal *self = IDE_TERMINAL (widget);
+  IdeTerminalPrivate *priv = ide_terminal_get_instance_private (self);
+
+  if (priv->popover != NULL)
+    {
+      if (gtk_widget_get_direction (GTK_WIDGET (self)) == GTK_TEXT_DIR_RTL)
+        gtk_widget_set_halign (GTK_WIDGET (priv->popover), GTK_ALIGN_END);
+      else
+        gtk_widget_set_halign (GTK_WIDGET (priv->popover), GTK_ALIGN_START);
+    }
+}
+
 static void
 ide_terminal_css_changed (GtkWidget         *widget,
                           GtkCssStyleChange *change)
@@ -215,7 +231,12 @@ ide_terminal_popup (IdeTerminal *self,
 
       priv->popover = GTK_POPOVER (gtk_popover_menu_new_from_model (G_MENU_MODEL (menu)));
       gtk_popover_set_has_arrow (priv->popover, FALSE);
-      gtk_widget_set_halign (GTK_WIDGET (priv->popover), GTK_ALIGN_END);
+
+      if (gtk_widget_get_direction (GTK_WIDGET (self)) == GTK_TEXT_DIR_RTL)
+        gtk_widget_set_halign (GTK_WIDGET (priv->popover), GTK_ALIGN_END);
+      else
+        gtk_widget_set_halign (GTK_WIDGET (priv->popover), GTK_ALIGN_START);
+
       gtk_widget_set_parent (GTK_WIDGET (priv->popover), GTK_WIDGET (self));
 
       g_signal_connect_object (priv->popover,
@@ -558,6 +579,7 @@ ide_terminal_class_init (IdeTerminalClass *klass)
 
   object_class->dispose = ide_terminal_dispose;
 
+  widget_class->direction_changed = ide_terminal_direction_changed;
   widget_class->css_changed = ide_terminal_css_changed;
   widget_class->size_allocate = ide_terminal_size_allocate;
 
-- 
GitLab


From e4fc91b5f3f8e1ec0dde5d4bf733036ecdf63acd Mon Sep 17 00:00:00 2001
From: Alexander Mikhaylenko <alexm@gnome.org>
Date: Thu, 2 Mar 2023 09:13:13 +0400
Subject: [PATCH 8/8] libide/gui: Sync undershoot styles with libadwaita

---
 src/libide/gui/style.css | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/libide/gui/style.css b/src/libide/gui/style.css
index 65518de2c..ac1d21f27 100644
--- a/src/libide/gui/style.css
+++ b/src/libide/gui/style.css
@@ -54,12 +54,14 @@ notificationstack button {
 
 scrolledwindow.undershoot-top > undershoot.top,
 preferencespage.undershoot-top > scrolledwindow > undershoot.top {
-  box-shadow: inset 0px 5px 14px -14px rgba(0,0,0,.9);
+  box-shadow: inset 0 1px alpha(@shade_color, .75);
+  background: linear-gradient(to bottom, alpha(@shade_color, .75), transparent 4px);
 }
 
 scrolledwindow.undershoot-bottom > undershoot.bottom,
 preferencespage.undershoot-bottom > scrolledwindow > undershoot.bottom {
-  box-shadow: inset 0px -5px 14px -14px rgba(0,0,0,.9);
+  box-shadow: inset 0 -1px alpha(@shade_color, .75);
+  background: linear-gradient(to top, alpha(@shade_color, .75), transparent 4px);
 }
 
 button.pill.small {
-- 
GitLab