Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-builder gnome-builder
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 307
    • Issues 307
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-buildergnome-builder
  • Merge requests
  • !664

Reload .buildconfig when changed on disk

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alex Gábor Ispánovics requested to merge igalex/gnome-builder:wip/autoupdatebuildcfg into main Nov 05, 2022
  • Overview 5
  • Commits 3
  • Pipelines 7
  • Changes 2

Changes:

Monitor .buildconfig and reload it when changes.

GFileMonitor might trigger its changed callback even if the monitor was blocked during save/load. Therefore the last known modification time is also saved to avoid reloading the most recently saved .buildconfig. This would interfere with the "Configure Project" GUI (e.g. when adding additional variables)

Fixed #1868 (closed)

Tested cases:

Case 1:

  1. Changed a .buildconfig (including the name of the config).
  2. Then checked "Configure Project" to confirm changes.

Case 2:

  1. Modify config in "Configure Project" (e.g. adding additional variables)
  2. Checked .buildconfig on disk

Known issue:

When the .buildconfig file is overwritten/changed while a .buildconfig based config is edited in the "Configure Project" GUI as well, any further changes on the GUI will be ignored (i.e. will not be saved). I think this is acceptable for this feature.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/autoupdatebuildcfg