Skip to content

eslint: Do not use runtime

Sonny Piers requested to merge (removed):sonny-main-patch-74916 into main

gnome-builder-30437.log

Fixes the following on a very standard project setup (a simple flatpak application with an eslint file). You can reproduce by opening a JS file from a Junction project for example.

$ gnome-builder -vvv
[...]
17:56:12.9429                   ide-subprocess-launcher[ 30697]:    DEBUG: Launching 'flatpak build --env=CCACHE_DIR=/home/sonny/.cache/gnome-builder/flatpak-builder/ccache --env=FLATPAK_CONFIG_DIR=/home/sonny/.local/share/gnome-builder/flatpak/etc --env=PATH=/app/bin:/usr/bin --env=G_MESSAGES_DEBUG= --env=XDG_RUNTIME_DIR=/run/user/1000 --build-dir=/home/sonny/Projects/Webground --share=network --nofilesystem=host --filesystem=/home/sonny/.cache/gnome-builder --filesystem=/home/sonny/Projects/Webground --filesystem=/home/sonny/.cache/gnome-builder/projects/Webground/builds/re.sonny.Webground.json-flatpak-org.gnome.Platform-master-x86_64-main --env=NOCONFIGURE=1 /home/sonny/.cache/gnome-builder/projects/Webground/flatpak/staging/x86_64-main /home/sonny/Projects/Webground/node_modules/.bin/eslint -f json --ignore-pattern !node_modules/* --ignore-pattern !bower_components/* --stdin --stdin-filename=/home/sonny/Projects/Webground/src/application.js' from directory '/home/sonny/Projects/Webground' with environment G_MESSAGES_DEBUG= FLATPAK_CONFIG_DIR=/home/sonny/.local/share/gnome-builder/flatpak/etc CCACHE_DIR=/home/sonny/.cache/gnome-builder/flatpak-builder/ccache PATH=/usr/bin:/bin HOME=/home/sonny USER=sonny LANG=en_US.UTF-8 clearing parent environment
[...]
/usr/bin/env: ‘node’: No such file or directory

To be honest, I don't really understand the Builder strategy for this but I'm happy to change my PR to conform.

Some plugins attempt to run in the application runtime (robocup, eslint) and others don't (xgettext, codespell).

What is expected? For users to add dependencies to the application runtime? If the runtime is a toolbox – I understand the appeal, but in case of a flatpak it seems unnecessarily complicated.

Edited by Sonny Piers

Merge request reports