From b96a399820640f35d367924b47f8f9899ceaf656 Mon Sep 17 00:00:00 2001 From: Mohammed Sadiq Date: Thu, 25 Jan 2018 13:12:10 +0530 Subject: [PATCH 1/2] build-stage: trivial typo fix in variable name --- src/libide/buildsystem/ide-build-stage-transfer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libide/buildsystem/ide-build-stage-transfer.c b/src/libide/buildsystem/ide-build-stage-transfer.c index c032eb449..9483b115a 100644 --- a/src/libide/buildsystem/ide-build-stage-transfer.c +++ b/src/libide/buildsystem/ide-build-stage-transfer.c @@ -31,7 +31,7 @@ struct _IdeBuildStageTransfer { - IdeBuildStage parent_instnace; + IdeBuildStage parent_instance; IdeTransfer *transfer; guint disable_when_metered : 1; }; -- GitLab From 35d41268d01136a2224c5c7c81225eced6b3faa4 Mon Sep 17 00:00:00 2001 From: Mohammed Sadiq Date: Thu, 25 Jan 2018 14:04:34 +0530 Subject: [PATCH 2/2] build-stage: set the priority a better way g_task_set_priority() prefers second argument to be of form G_PRIORITY_*. The current variable, TRUE, is less documenting regarding the intention of the variable. As said by cherget, use G_PRIORITY_LOW. --- src/libide/buildsystem/ide-build-stage-transfer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libide/buildsystem/ide-build-stage-transfer.c b/src/libide/buildsystem/ide-build-stage-transfer.c index 9483b115a..f2fd6a467 100644 --- a/src/libide/buildsystem/ide-build-stage-transfer.c +++ b/src/libide/buildsystem/ide-build-stage-transfer.c @@ -96,7 +96,7 @@ ide_build_stage_transfer_execute_async (IdeBuildStage *stage, task = g_task_new (self, cancellable, callback, user_data); g_task_set_source_tag (task, ide_build_stage_transfer_execute_async); - g_task_set_priority (task, TRUE); + g_task_set_priority (task, G_PRIORITY_LOW); g_signal_connect (task, "notify::completed", -- GitLab