Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-builder gnome-builder
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 308
    • Issues 308
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-buildergnome-builder
  • Merge requests
  • !194

Fix UI files opening in Directory Browser

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed James Westman requested to merge jwestman/gnome-builder:fix-ls-plugin into master May 11, 2019
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 1

This was happening because the Directory Browser used a priority of G_MAXINT for regular files, causing an integer overflow in the comparator function here (because some other plugins have negative priorities).

Question: Should there be a set of predefined priorities that could be used? Something like HIGH, REGULAR, and FALLBACK, so plugin writers don't have to look up what other plugins are using?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-ls-plugin