gnome-builder merge requests
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests
2018-08-09T17:05:49Z
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/83
Improve snippets
2018-08-09T17:05:49Z
Ricardo Silva Veloso
Improve snippets
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/84
Add snippets for ES6 and fix some things
2018-07-30T05:31:50Z
Ricardo Silva Veloso
Add snippets for ES6 and fix some things
* ES6 classes are already being used in GJS & Polari, so I updated the snippets
* Move the GObject-related snippets to `gobject.snippets`
* Reformat Java snippets to common style
* ES6 classes are already being used in GJS & Polari, so I updated the snippets
* Move the GObject-related snippets to `gobject.snippets`
* Reformat Java snippets to common style
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/85
Update Brazilian Portuguese translation
2018-07-30T19:51:10Z
Ricardo Silva Veloso
Update Brazilian Portuguese translation
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/86
Build fixes for Nix
2018-07-31T01:13:35Z
Jamey Sharp
Build fixes for Nix
There have been multiple attempts to package GNOME Builder for the Nix package manager and NixOS ([mine](https://github.com/NixOS/nixpkgs/pull/44217) and an [earlier attempt](https://github.com/NixOS/nixpkgs/pull/33270)). Some of the dif...
There have been multiple attempts to package GNOME Builder for the Nix package manager and NixOS ([mine](https://github.com/NixOS/nixpkgs/pull/44217) and an [earlier attempt](https://github.com/NixOS/nixpkgs/pull/33270)). Some of the difficulties seem easy to resolve upstream, and potentially useful to others, so I'm hoping the two patches in this merge request can go in for 3.30.
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/88
Update Rust defaults, and fix style of C snippet
2018-07-31T01:01:16Z
Ricardo Silva Veloso
Update Rust defaults, and fix style of C snippet
Closes: #578
Closes: #578
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/89
doc: update writingdocs.rst to merge request
2018-08-01T19:35:38Z
Jacob Humphrey
doc: update writingdocs.rst to merge request
The page contributing/writingdocs used tell people to create a patch and open an issue with the patch file as a attachment. Currently, it is recomended for people to create a merge request. This merge request tells people to make merge r...
The page contributing/writingdocs used tell people to create a patch and open an issue with the patch file as a attachment. Currently, it is recomended for people to create a merge request. This merge request tells people to make merge requests.
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/90
Fix alpha component of color picker in some locales
2018-08-03T20:08:38Z
Ricardo Silva Veloso
Fix alpha component of color picker in some locales
In pt_BR locale, the color picker was returning comma as decimal separator. Improve JS import snippets.
In pt_BR locale, the color picker was returning comma as decimal separator. Improve JS import snippets.
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/91
snippets: Improve GBoxed snippets
2018-08-03T20:34:14Z
Philip Chimento
snippets: Improve GBoxed snippets
These need a get_type() function in the header, and some doc comments
with annotations, to be ready for gobject-introspection.
These need a get_type() function in the header, and some doc comments
with annotations, to be ready for gobject-introspection.
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/92
Add error format for rustc
2018-08-07T18:43:29Z
Ricardo Silva Veloso
Add error format for rustc
Closes #494.
Closes #494.
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/93
Change defaults for languages
2018-08-06T20:38:19Z
Ricardo Silva Veloso
Change defaults for languages
Change defaults for languages to common cases.
About Rust: https://github.com/rust-lang-nursery/fmt-rfcs/blob/master/guide/guide.md#indentation-and-line-width
Change defaults for languages to common cases.
About Rust: https://github.com/rust-lang-nursery/fmt-rfcs/blob/master/guide/guide.md#indentation-and-line-width
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/94
WIP: add info to breakpoint
2018-08-05T21:19:19Z
Ghost User
WIP: add info to breakpoint
This commit is totally broken, but the rough idea is to pass line, file and id to callback so breakpoint can be removed
related to #587
This commit is totally broken, but the rough idea is to pass line, file and id to callback so breakpoint can be removed
related to #587
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/95
flatpak: allow applications to talk to portals
2018-08-06T20:17:18Z
Florian Müllner
fmuellner@gnome.org
flatpak: allow applications to talk to portals
Portals are explicitly designed to give sandboxed applications access to
resources in a secure manner, and flatpak therefore grants all applications
permission to talk to any portal.
As a result, few manifests will explicitly request th...
Portals are explicitly designed to give sandboxed applications access to
resources in a secure manner, and flatpak therefore grants all applications
permission to talk to any portal.
As a result, few manifests will explicitly request that permission, so
to have apps work as expected when run through our flatpak-runner instead
of flatpak itself, we should grant them the same permission.
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/96
gdb: Pass breakpoint directly to remove effectively
2018-08-06T20:50:58Z
Ghost User
gdb: Pass breakpoint directly to remove effectively
Passing breakpoint it is located by path, being removed
![Captura_del_escritorio_de_06-08-18_01_32_28](/uploads/d6acceade2550d48ad347ff9a1802e45/Captura_del_escritorio_de_06-08-18_01_32_28.webm)
closes #587
Passing breakpoint it is located by path, being removed
![Captura_del_escritorio_de_06-08-18_01_32_28](/uploads/d6acceade2550d48ad347ff9a1802e45/Captura_del_escritorio_de_06-08-18_01_32_28.webm)
closes #587
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/97
log: filtering output by domain
2018-08-07T18:07:43Z
Ghost User
log: filtering output by domain
Allow log to be filter by domain.
Use case I'm debugging gdb communication and I'm only interested on `gbp-gdb-debugger` log domain (after adding this patch)
```
Author: Alberto Fanjul <albertofanjul@gmail.com>
Date: Tue Aug 7 19:00:...
Allow log to be filter by domain.
Use case I'm debugging gdb communication and I'm only interested on `gbp-gdb-debugger` log domain (after adding this patch)
```
Author: Alberto Fanjul <albertofanjul@gmail.com>
Date: Tue Aug 7 19:00:50 2018 +0200
gdb: show gdb communication
diff --git a/src/plugins/gdb/gbp-gdb-debugger.c b/src/plugins/gdb/gbp-gdb-debugger.c
index aaeaca0be..ec16266fe 100644
--- a/src/plugins/gdb/gbp-gdb-debugger.c
+++ b/src/plugins/gdb/gbp-gdb-debugger.c
@@ -1170,6 +1170,8 @@ gbp_gdb_debugger_insert_breakpoint_cb (GObject *object,
return;
}
+ g_debug ("gdb response: %s", output->line);
+
if (output->kind == GDBWIRE_MI_OUTPUT_RESULT &&
output->variant.result_record != NULL &&
output->variant.result_record->result != NULL)
@@ -2774,6 +2776,8 @@ gbp_gdb_debugger_exec_async (GbpGdbDebugger *self,
g_return_if_fail (!thread || IDE_IS_DEBUGGER_THREAD (thread));
g_return_if_fail (!cancellable || G_IS_CANCELLABLE (cancellable));
+ g_debug("gdb command: %s", command);
+
/* Wrap at 10,000, but steal 9999 to use for thread switching */
id = ++self->cmdseq;
if (id == 9999)
```
Now I can debug with pleasure using:
```
$ flatpak-builder --run builder build-aux/flatpak/org.gnome.Builder.json /bin/bash
(flatpak)$ IDE_MESSAGES_TRACE=none IDE_MESSAGES_INFO=none IDE_MESSAGES_MESSAGE=none IDE_MESSAGES_DEBUG=gbp-gdb-debugger gdb --args gnome-builder -vvv
```
because log is only:
```
19:09:17.0701 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -gdb-set mi-async on
19:09:17.0701 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -break-list
19:09:17.0702 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -gdb-set inferior-tty /proc/self/fd/3
19:09:17.0702 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -exec-run --all --start
19:09:17.0702 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -data-list-register-names
19:09:17.0719 Ide[ 199]: WARNING: Failed to parse gdb communication: (flatpak build:19070): flatpak-DEBUG: 19:09:17.718: Opening user flatpak installation at path /home/alberto/.local/share/flatpak
19:09:17.0719 Ide[ 199]: WARNING: Failed to parse gdb communication: (flatpak build:19070): flatpak-DEBUG: 19:09:17.718: No installations directory in /etc/flatpak/installations.d. Skipping
19:09:17.0719 Ide[ 199]: WARNING: There was a communication failure
19:09:17.0719 Ide[ 199]: WARNING: There was a communication failure
19:09:17.0723 Ide[ 199]: WARNING: Failed to parse gdb communication: (flatpak build:19070): flatpak-DEBUG: 19:09:17.723: Allocated instance id 1785157566
19:09:17.0723 Ide[ 199]: WARNING: Failed to parse gdb communication: (flatpak build:19070): flatpak-DEBUG: 19:09:17.723: Allowing host-fs access
19:09:17.0723 Ide[ 199]: WARNING: Failed to parse gdb communication: (flatpak build:19070): flatpak-DEBUG: 19:09:17.723: Allowing wayland access
19:09:17.0723 Ide[ 199]: WARNING: Failed to parse gdb communication: (flatpak build:19070): flatpak-DEBUG: 19:09:17.723: Allowing x11 access
19:09:17.0726 Ide[ 199]: WARNING: Failed to parse gdb communication: (flatpak build:19070): flatpak-DEBUG: 19:09:17.726: Failed to run in transient scope: In WaitingForReject: Expected 'REJECTED am1 am2 ... amN', got 'ERROR'
19:09:17.0726 Ide[ 199]: WARNING: Failed to parse gdb communication: 19:09:18.0000 Ide[ 199]: WARNING: gdb: No reply found for: 001^done
19:09:18.0000 Ide[ 199]: WARNING: gdb: No reply found for: 002^done,BreakpointTable={nr_rows="0",nr_cols="6",hdr=[{width="7",alignment="-1",col_name="number",colhdr="Num"},{width="14",alignment="-1",col_name="type",colhdr="Type"},{width="4",alignment="-1",col_name="disp",colhdr="Disp"},{width="3",alignment="-1",col_name="enabled",colhdr="Enb"},{width="10",alignment="-1",col_name="addr",colhdr="Address"},{width="40",alignment="2",col_name="what",colhdr="What"}],body=[]}
19:09:18.0000 Ide[ 199]: WARNING: gdb: No reply found for: 003^done
19:09:18.0040 Ide[ 199]: WARNING: gdb: No reply found for: 004^running
19:09:18.0051 Ide[ 199]: WARNING: gdb: No reply found for: 005^done,register-names=["rax","rbx","rcx","rdx","rsi","rdi","rbp","rsp","r8","r9","r10","r11","r12","r13","r14","r15","rip","eflags","cs","ss","ds","es","fs","gs","st0","st1","st2","st3","st4","st5","st6","st7","fctrl","fstat","ftag","fiseg","fioff","foseg","fooff","fop","xmm0","xmm1","xmm2","xmm3","xmm4","xmm5","xmm6","xmm7","xmm8","xmm9","xmm10","xmm11","xmm12","xmm13","xmm14","xmm15","mxcsr","ymm0h","ymm1h","ymm2h","ymm3h","ymm4h","ymm5h","ymm6h","ymm7h","ymm8h","ymm9h","ymm10h","ymm11h","ymm12h","ymm13h","ymm14h","ymm15h","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","orig_rax","al","bl","cl","dl","sil","dil","bpl","spl","r8l","r9l","r10l","r11l","r12l","r13l","r14l","r15l","ah","bh","ch","dh","ax","bx","cx","dx","si","di","bp","","r8w","r9w","r10w","r11w","r12w","r13w","r14w","r15w","eax","ebx","ecx","edx","esi","edi","ebp","esp","r8d","r9d","r10d","r11d","r12d","r13d","r14d","r15d","ymm0","ymm1","ymm2","ymm3","ymm4","ymm5","ymm6","ymm7","ymm8","ymm9","ymm10","ymm11","ymm12","ymm13","ymm14","ymm15"]
19:09:19.0531 (null)[ 208]: WARNING: ide-vala-service.vala:90: Error opening directory '/home/alberto/jhbuild/checkout/gitg/flatpak-gitg/var/run/media/alberto/06095c1f-7f67-444b-87f8-0f5185a7cfd5/lost+found': Permission denied
19:09:21.0060 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -break-list
19:09:21.0066 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -data-list-register-values x
19:09:21.0067 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -stack-list-frames
19:09:21.0359 ide-editor-perspective[ 199]: WARNING: The file is already loading
19:09:21.0444 Ide[ 199]: WARNING: There was a failure while calculating line changes from git. The exact error was: File is not under control of git working directory.
19:09:21.0449 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -stack-list-arguments --simple-values 0 0
19:09:21.0449 gbp-gdb-debugger[ 199]: DEBUG: gdb command: 9999-stack-select-frame 0
@@@@-stack-list-locals --simple-values
9999-stack-select-frame
Warning: disabling gigacage because GIGACAGE_ENABLED=0!
19:09:26.0187 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -exec-step
19:09:26.0187 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -data-list-register-names
19:09:26.0194 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -break-list
19:09:26.0196 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -data-list-register-values x
19:09:26.0197 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -stack-list-frames
19:09:26.0201 ide-editor-perspective[ 199]: WARNING: The file is already loading
19:09:26.0417 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -stack-list-arguments --simple-values 0 0
19:09:26.0417 gbp-gdb-debugger[ 199]: DEBUG: gdb command: 9999-stack-select-frame 0
@@@@-stack-list-locals --simple-values
9999-stack-select-frame
sys:1: Warning: g_mapped_file_get_length: assertion 'file != NULL' failed
19:09:29.0199 gbp-gdb-debugger[ 199]: DEBUG: gdb command: -break-insert --source /home/alberto/jhbuild/checkout/gitg/gitg/gitg-application.vala --line 34
19:09:29.0214 gbp-gdb-debugger[ 199]: DEBUG: gdb response: 018^done,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="<MULTIPLE>",times="0",original-location="-source /home/alberto/jhbuild/checkout/gitg/gitg/gitg-application.vala -line 34"},{number="2.1",enabled="y",addr="0x0000000000450850",func="gitg_application_construct",file="/home/alberto/jhbuild/checkout/gitg/gitg/gitg-application.vala",fullname="/home/alberto/jhbuild/checkout/gitg/gitg/gitg-application.vala",line="34",thread-groups=["i1"]},{number="2.2",enabled="y",addr="0x0000000000450929",func="gitg_application_new",file="/home/alberto/jhbuild/checkout/gitg/gitg/gitg-application.vala",fullname="/home/alberto/jhbuild/checkout/gitg/gitg/gitg-application.vala",line="34",thread-groups=["i1"]}
```
So something like domain filtering would be really appreciated
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/98
flatpak: Cleanup Python dependencies
2018-08-13T20:29:58Z
Patrick Griffis
flatpak: Cleanup Python dependencies
This had limited testing.
This had limited testing.
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/100
Added Vala api reference to documentation
2018-08-13T19:30:12Z
Yotam
Added Vala api reference to documentation
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/102
WIP: Improve Python indenter
2022-05-24T23:02:32Z
Ricardo Silva Veloso
WIP: Improve Python indenter
Closes #597 and automatically insert new comment lines.
Closes #597 and automatically insert new comment lines.
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/103
Add plugin for the Clang Language Server
2018-08-20T20:02:22Z
Nathaniel McCallum
Add plugin for the Clang Language Server
This patch may not yet be complete. It *does* work. But `clangd` doesn't get CFLAGS or LIBS, so compilation fails pretty quickly and shows a bunch of errors in the file. I'm not super familiar with the Language Server Protocol. So I'm no...
This patch may not yet be complete. It *does* work. But `clangd` doesn't get CFLAGS or LIBS, so compilation fails pretty quickly and shows a bunch of errors in the file. I'm not super familiar with the Language Server Protocol. So I'm not sure how to provide this information. Does anyone have any suggestions?
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/104
Add plugin for the Clang Language Server
2021-12-21T00:36:14Z
Nathaniel McCallum
Add plugin for the Clang Language Server
This patch may not yet be complete. It _does_ work. But `clangd` doesn't get CFLAGS or LIBS, so compilation fails pretty quickly and shows a bunch of errors in the file. I'm not super familiar with the Language Server Protocol. So I'm no...
This patch may not yet be complete. It _does_ work. But `clangd` doesn't get CFLAGS or LIBS, so compilation fails pretty quickly and shows a bunch of errors in the file. I'm not super familiar with the Language Server Protocol. So I'm not sure how to provide this information. Does anyone have any suggestions?
https://gitlab.gnome.org/GNOME/gnome-builder/-/merge_requests/105
ide-popover: fix leave event happening in another GdkWindow
2018-08-23T19:45:41Z
Sébastien Lafargue
ide-popover: fix leave event happening in another GdkWindow
Under Xorg, some doc popover are not dismissed when leaving
the view because the GdkWindow of the leave event is not
the widget window as under Wayland.
We now compare the event window with sub-windows of the widget,
that is the text an...
Under Xorg, some doc popover are not dismissed when leaving
the view because the GdkWindow of the leave event is not
the widget window as under Wayland.
We now compare the event window with sub-windows of the widget,
that is the text and gutter ones.