The device path in the data struct was never freed even though we owned
it. Small leak that only happened when pairing, so low impact.

bluetooth_client_setup_device_finish() stole the device path from the
result object but didn't mention it. Clarify the ownership of the "path"
return value.

The guard was guarding against a local variable ("device") being
NULL, instead guarding against one of the arguments ("device_path")
being NULL. Depending on the compiler and runtime, this would probably
fail most of the time, leading to problems using non-pairing devices
after the initial setup.

bluetooth_client_set_trusted: assertion 'device != NULL' failed

Fixes: 27e88fc0

As with discoverability, we need to disable discovery when the settings
widget is destroyed. This fixes an issue where we keep discovering when
switching away from the bluetooth panel in g-c-c. This is mainly an
issue as it may impact the performance of established bluetooth
connections.

Discoverability is automatically disabled again on widget finalization.
Remove the old fixme as the issue has been solved since.

The mouse's manual doesn't give any details on how to pair
it, but it claims to be "Mac only", so the behaviour was likely
the same one as Apple's own mice, with a "0000" pincode.
This was tested successfully.

Added it to POTFILES.skip but didn't remove it from POTFILES.in.

The 3.29 release cycle has already come and gone, we should be releasing
for the 3.31 cycle.

Fixes gnome-control-center#364

This fixes the name collision in GNOME Settings.

This is a fork of HdyColumn introduced to fix a name collision in GNOME
Settings as is has both gnome-bluetooth's version of HdyColumn and its
own in parallel.

The widget couldn't be named BluetoothColumn as the name was already
taken.

settings-widget: Use a Hdycolumn

See merge request !4

This allows to better test the size adaptation of the widget.

This stops the labels flickering when they are ellipsized and the
window's size changes.

This adapts the indentation of the children of HdyColumn, which were
deliberately left intact in the previous commit to make it more
readable.

Put the widget's content into a HdyColumn to better manage the available
width.

This deliberately doesn't adapt the indentation of the contained widget
to help this commit to be more readable and easier to review, it will be
adapted in the next commit.

This will be needed by the next commit to access HdyColumn.

This also lets the CI recursively update the submodules so it can pass.

(cherry picked from commit c080ec21)

Different meson improvements

See merge request !6

Since gnome-bluetooth was ported to meson, version has acquired
a new parameter called `private_headers` which replaces the
`--ignore-headers` argument in `scan_args` parameter.
`--rebuild-types` argument is also not necessary because a types
does exist already.

`--sgml-mode` and `--output-format=xml` parameters are also not
necessary because meson already handles them automatically.

Finally, the `version.xml` is included now explicitly as a
content file because previously it was copied as a workaround.

Functions derived from generators as `configure_file`,
`custom_target` and `i18n.merge_file` can use placeholders like
`@BASENAME@` that removes the extension from the input filename
string.

The output string has been replaced by this placeholder that
allows in some cases the use of less variables.

libgnome-bluetooth expose a number of includes in their public
headers belonging to different libraries. Therefore, these libraries
are indirect dependencies of the library to be built.

With this in mind, required dependencies have been split in two
sets, one formed by public dependencies and the other by private
dependencies.

The created `pkg-config` file now also use these new sets.

meson's `compile_resources` from `gnome` module is executed
considering the current source directory as its source directory
so there is no need to include it.

The `--warn-all` argument is already included by meson, so there is
no need to include it explicitly.

Since meson 0.46[0], meson has added support for checking properly
link flags support. `version-script` link flag check has been
changed to take advantage of this support.

[0] http://mesonbuild.com/Release-notes-for-0-46-0.html#new-functions-has_link_argument-and-friends

Although usually directory variables are set by using the `prefix`
directory, this might cause issues due to parameters that need
relative directories.

In order to ease the transition `prefix` directory has been stripped
from directory variables and only has been appended when necessary.

Since meson 0.49, the `/` character can be used to join paths[0], so
all the instances of `join_paths` have been replaced.

Required meson version has been bumped to 0.49.

[0] http://mesonbuild.com/Release-notes-for-0-49-0.html#joining-paths-with-

The used meson modules, default directories and includes have been
moved to the start of the build file, just after project related
information, so they are available early.

The way `po` directory path is defined has also been changed to
avoid the use of the `source_root` function.