GitLab

This reverts commit 5964bcb6.

Use the device alias for user-visible strings, making it possible for
end-users to change the name of Bluetooth devices on the command-line
when they have 2 of the same device for example.

Use g_autofree to get rid of a number of gotos.

bash thinks that the introspection binary created isn't readable or
executable when it's both. Work-around that by neutering the tests.

The value of the "default-adapter-discovering" property was set
incorrectly when using the switch to connect to a device.

See #70 (comment 922816)
Fixes: 08defddc

Closes: #70

Disable discovery during pairing and connect so as to work around broken
firmwares and hardware not being able to correctly connect to remote
devices when the adapter is performing a discovery.

Closes: gnome-control-center#820

The 8bitdo Zero gamepad can also appear as a keyboard to pair using
iCade protocol.

We should be reporting some of the pairing errors better than we are.
Make some notes as to what those errors are.

As can happen when inputting the pairing code wrong.

Closes: #67

Closes: #65

lib/bluetooth-pairing-dialog.c: In function ‘bluetooth_pairing_dialog_set_mode’:
include/glib-2.0/glib/gmacros.h:928:7: warning: ‘help’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  928 |    if (expr)                                    \
      |       ^
lib/bluetooth-pairing-dialog.c:69:8: note: ‘help’ was declared here
   69 |  char *help;
      |        ^~~~