GitLab

* glom/utility_widgets/dialog_image_save_progress.[h|cc]: Replace set_pixbuf()
with set_image_data().
save(): Save the original data, instead of saving the data from the pixbuf.
* glom/utility_widgets/imageglom.cc: Adapt.
This means, for instance, that if the user loads the a JPG in then they will
get exactly the same JPG out.

	* glom/libglom/connectionpool_backends/postgres.cc:
	* glom/xsl_utils.cc: Gio::FileOutputStream::write() returns a gssize, not a
	gsize.

	* glom/utility_widgets/imageglom.cc: init(): Remove the set_size_request()
	call which does not seem necessary.
	Do not call set_image(original) after scale(), because scale() does that,
	setting the scaled image.
	This avoids the GtkImage being huge, because GtkImage re-requests the
	bigger size again when the original is put in it.
	This is still not ideal. It would be nicer if we could just say "do not
	make the window bigger than the screen, or do not make this make the
	window bigger."

* glom/utility_widgets/imageglom.cc: For the case that we have no AppInfo
(not Open With), use the static AppInfo method, for consistency.
This might work on Win32 too.

* glom/utility_widgets/dialog_image_save_progress.[h|cc]:
* ui/operator/dialog_image_save_progress.glade:
Added a progress dialog to do image saving, though it does not yet do
async saving so the dialog is never shown.
* Makefile.am:
* Makefile_glom.am:
* po/POTFILES.in: Mention the new files.
  * glom/utility_widgets/imageglom.[h|cc]: Add the new context menu items,
  using a temporary file for the Open and Open With features.
  Open With uses AppChooserDialog to offer a choice to the user.
  Bug #630057

	* glom/utility_widgets/dialog_image_progress.[h|cc]:
	Rename to
	* glom/utility_widgets/dialog_image_load_progress.[h|cc]:
	* tests/test_glade_derived_instantiation.cc:
	* ui/operator/dialog_image_progress.glade: Rename to
	* ui/operator/dialog_image_load_progress.glade:
	* glom/utility_widgets/imageglom.h:
	* Makefile.am:
	* Makefile_glom.am:
	* po/POTFILES.in: Adapt.

	I can then add a new dialog for saving.

This is needed for the @docdir@ expansion used in the exampledir
variable.

* glom/libglom/glom.pc.in:

* glom/libglom/glom.pc.in:

* glom/libglom/data_structure/field.cc:
* glom/libglom/data_structure/layout/*.c:
* glom/mode_data/box_data_list.cc:
* glom/mode_data/box_data_list.h:
* glom/mode_data/box_data_manyrecords.cc:
* glom/mode_data/notebook_data.cc:
* ui/developer/dialog_script_library.glade: Add translator comments.
Bug #638996 (Joe Hansen)

* glom/mode_data/db_adddel/db_adddel.[h|cc]: Added set_height_rows(), so
we can set the minimum size based on the number of rows, though this
currently hard-codes a size for the non-rows part of the GtkTreeView, such
as the column headers.
* glom/mode_data/box_data_portal.cc:
* glom/mode_data/box_data_list_related.cc: Constructors: Remove unnecessary
calls to set_size_request().
Call set_height_rows() instead.

  The related records Gtk::TreeViews probably became too small since the port to
  gtkmm3. We now need to use Gtk::ScrolledArea::set_min_content_height().

  However, the number of rows should probably be something for the layout to
  specify per portal.

	* glom/mode_data/db_adddel/db_adddel.[h|cc]: get_fixed_cell_height():
	Return a guint instead of an int.

* glom/mode_data/datawidget/treemodel_db.[h|cc]: get_last_row():
Document that this never returns the placeholder row, and make sure that it
does not. There was a typo that --ed the wrong variable.
* glom/mode_data/db_adddel/db_adddel.[h|cc]: get_last_row():
Document that this never returns the placeholder row.
get_is_placeholder_row(): Remove an illogical call to is_last_row().
get_count(): Remove an illogical check to see whether the last row is the
placeholder row.
* glom/utility_widgets/adddel/adddel.h: get_last_row(): Document that this
  similarly-APIed widget has different behaviour.

  This stops the user from being taken to an empty record when clicking Last,
  or when clicking Next to the end.
  Bug #526115 comment #25 (Michael Hasselmann)

* glom/mode_data/db_adddel/db_adddel.h: These methods are not meant to
be overridden by anything.

* glom/application.cc: Use set_logo() though this only appears in the title
bar for some reason.

	* glom/application.cc: Add the Help menu itself, and use set_program_name()
	instead of set_name().

* glom/application.[h|cc]:
* glom/bakery/app.[h|cc]:
* glom/bakery/app_withdoc_gtk.[h|cc]: Move the help menu out of the
Bakery class, doing it all in our derived Application class, to give us
more control over the GtkAboutDialog. We do not need the abstraction any
more.
This restores the application description, which was probably lost when
converting to AboutDialog.

* ui/developer/:
* glom/glade_utils.h: get_glade_widget_derived_with_warning(): Guess the
filename based on the requested ID, for developer UI as we already did
for operator UI.
  This makes it possible to edit these in recent versions of Glade, without
  Glade silently renaming IDs to make them unique across the whole file.
  * po/POTFILES.in:
  * Makefile.am: Mention the new files.

* configure.ac: This is still only used if the automake version is recent
enough.

* glom/mode_data/db_adddel/db_adddel.cc: get_fixed_cell_height():
Add the GtkTreeView vertical-separator style property to the height,
which might be the right thing to do, and which works here at least.

* glom/libglom/connectionpool_backends/postgres.cc:
get_string_find_operator(): Use ILIKE, though this requires the lastest
libgdamm from git master.
Find has been case-sensitive since around glom 1.16, since we started
using SqlBuilder.

* glom/libglom/connectionpool_backends/backend.h:
* glom/libglom/connectionpool_backends/postgres.[h|cc]:
* glom/libglom/connectionpool_backends/sqlite.[h|cc]: Move method
  implementations into the .cc files.

* glom/libglom/data_structure/field.cc: SqlBuilder already takes
care of quoting so this just changed the actual value.
This makes Quick Find work again.

* glom/libglom/connectionpool.[h|cc]:
* glom/libglom/connectionpool_backends/backend.h:
* glom/libglom/connectionpool_backends/postgres.h:
* glom/libglom/connectionpool_backends/sqlite.h:
get_string_find_operator(): Return the Gnome::Gda operator enum
instead of the operator as a string.
* glom/libglom/data_structure/field.[h|cc]: sql_find_operator():
Likewise, return the Gnome::Gda operator enum.
* glom/libglom/utils.cc: get_find_where_clause_quick():
* glom/mode_data/box_data.cc: get_find_where_clause():
Use Field::sql_find_operator() and Field::sql_find(), as per
the TODO comments.

This was code that I forgot to change properly when porting to
use Gnome::Gda::SqlBuilder, so this has been broken since
Glom 1.16.
Find still does not work.

* glom/frame_glom.[h|cc]: Rename on_menu_Mode_Toggle() to
on_menu_Edit_Find() because that is what it is now.
* glom/application.cc: Adapted.

* ui/operator/window_main.glade: Remove the footer row of widgets.
* glom/frame_glom.[h|cc]: Instead build them manually and add them (in a box)
to the notebook at the right-hand side next to the tabs.

* ui/operator/: Split the .glade files up, giving them the same names
as the top-level (or almost top-level) IDs that the code looks for.
* glom/glade_utils.h: get_glade_widget_derived_with_warning(): Guess the
filename based on the requested ID.