GitLab

	* glom/main.cc: Pass no arguments to init(), though I think I will
	add the method overload back to goocanvasmm to avoid annoying people
	too much.

* glom/utility_widgets/sidebar.[h|cc]: Removed, because Gtk::HandleBox
is deprecated.
* Makefile_glom.am: Remove mention of this file.
* glom/utility_widgets/layouttoolbar.[h|cc]: Derive directly from
Gtk::ToolPalette instead.
* glom/mode_design/print_layouts/print_layout_toolbar.[h|cc]: Adapt.

* glom/mode_design/print_layouts/window_print_layout_edit.h: The glade
file still has a GtkHandleBox which we should remove, but in the
meantime just use it via Gtk::Box.

Add individual includes instead of general giomm.h, glibmm.h or gtkmm.h
includes.
Among other things, this might let us avoid the annoying warning about
deprecated GThread functions.

* ui/operator/window_main.glade: Request a small enough size to fit small
screens. This will then not warn during test_glade_derived_instantiation.cc.
However, more space may be requested later.

	* glom/mode_data/placeholder-glom.[h|cc]: Remove these files.
	* Makefile_glom.am: Remove mentions of these files.
	* glom/mode_data/flowtable_withfields.cc: Remove uses of PlaceholderGlom.

	* Many files: Use more specific includes.

	* POTFILES.in: Remove the mention of a file that no longer exists.

* glom/application.cc: set_progress_message(): Set the main UI elements to
insensitive(), because all our current uses of the progess message should
block user input, like a modal dialog.
* ui/operator/window_main.glade: Move the InfoBar out of the frame, because
it should not have the border, and so we can make the frame insensitive
without making the InfoBar insensitive. This required adding an extra
intermediate GtkBox, because otherwise there is no way to add the menubar
at the top, before the InfoBar.
This .glade file needed some hand-editing to remove bad <packing> tags that
glade (from git master) added.

	* glom/application.cc: set_progress_message(): Set the main UI elements to
	insensitive(), because all our current uses of the progess message should
	block user input, like a modal dialog.
	* ui/operator/window_main.glade: Move the InfoBar out of the frame, because
	it should not have the border, and so we can make the frame insensitive
	without making the InfoBar insensitive.

* Makefile_glom.am:
* glom/application.[h|cc]: Move the ShowProgressMessage class to separate
.h/.cc files because I generally prefer one .h/.cc per class.

* glom/application.[h|cc]: Move implementation into .cc file. Correct the code
style. Make the constructor explicit.

* configure.ac: Add a comment about not linking to gthread-2.0 in future.
* glom/libglom/init.cc:
* tests/import/test_parsing.cc:
* tests/import/test_signals.cc: Avoid calls to deprecated Glib::thread_init()
if glib is new enough.
This is a step to making Glom build against glibmm from git master with
--enable-warnings=fatal.

* glom/libglom/db_utils.cc: move it back to:
* glom/libglom/utils.[h|cc]: because it is needed by java-libglom.

	* tests/test_selfhosting_utils.[h|cc]: test_create_and_selfhost():
	Add a hosting_mode parameter so we can test sqlite too.
	Correct some return values and check that the directory really exists after
	it should have been created.
	* tests/test_selfhosting_new_empty.cc:
	* tests/test_selfhosting_new_from_example.cc:
	* tests/test_selfhosting_new_then_report.cc:
	* tests/test_selfhosting_sqlinjection.cc: Restructure so all tests are run
	twice - once for each backend.

	* glom/libglom/db_utils.[h|cc]: recreate_database_from_document(): Do not
	call add_standard_tables() and add_standard_groups() because create_database()
	(which we call) has already done this.
	query_execute_string(): Only -1 is an error, though that is odd.
	See libgda bug #662279 .

	* glom/libglom/utils.cc:
	* glom/base_db.[h|cc]: Moved count_rows_returned_by() to
 	* glom/libglom/db_utils.[h|cc]: and also moved
  Utils::build_sql_select_count_row() making it static (not API).
	* glom/frame_glom.cc:
	* glom/mode_data/datawidget/treemodel_db.cc: Adapted.

* tests/test_selfhosting_sqlinjection.cc: Try to avoid quoting by
saying that a text field is a number but still providing a text value.

2011-10-19  Murray Cumming  <murrayc@murrayc.com>

SQL Injection Test: Try to use (evil and unquoted) text for a number.

* tests/test_selfhosting_sqlinjection.cc: This seems to be safe already.

* tests/test_selfhosting_sqlinjection.cc: This seems to be safe already.

https://bugzilla.gnome.org/show_bug.cgi?id=662143

* tests/test_selfhosting_sqlinjection.cc: Instead of assuming that we know
what libgda uses.

* glom/libglom/connectionpool.cc: invalidate_connection(): Actually call
Gda::Connection::close() instead of relying on the Connection destructor to
do that, because maybe it is not closing it if maybe Connection::is_opened()
is not working correctly.
cleanup(): invalidate the connection before shutting down the server,
not after, in case an open connection is stopping the server from closing down.
* glom/libglom/connectionpool_backends/postgres_self.[h|cc]:
connect(): Remember the connection details so we can use them later to show
debug output.
Added show_active_connections() to try to get a clue about what is wrong
when the shutdown fails, using those connection details.
cleanup(): Call it when the shutdown fails.

	* tests/test_selfhosting_new_from_example.cc: Add some missing !.

	* glom/libglom/init.cc: Specify pygobject 3 instead of 2 when calling
	pygobject_init(). They are parallel-installable and incompatible and it is
	3 that we depend on. This recently started failing during "make check",
	which it should.

* tests/test_selfhosting_sqlinjection.cc: Attempt to do bad things
that would be possible if our SQL values were not escaped properly
in the SQL. (libgda takes care of this.)
* Makefile_tests.am: Mention the new test.

	* glom/libglom/document/document.[h|cc]: Added get_field_primary_key(),
	for use by:
	* tests/test_selfhosting_utils.[h|cc]: Added test_table_exists().
	* tests/test_selfhosting_new_from_example.cc: Add quick checks that
	some other tables exist.

	* tests/test_selfhosting_utils.[h|cc]: Added test_model_expected_size().
	* tests/test_selfhosting_new_from_example.cc: Test the quick find and
	the count query.

	* glom/libglom/data_structure/glomconversions.cc: format_time():
	Return a result from the catch block.