1. 25 Oct, 2011 2 commits
  2. 24 Oct, 2011 6 commits
  3. 21 Oct, 2011 1 commit
    • Murray Cumming's avatar
      Avoid calling g_thread_init() if possible. · 492690ed
      Murray Cumming authored
      * configure.ac: Add a comment about not linking to gthread-2.0 in future.
      * glom/libglom/init.cc:
      * tests/import/test_parsing.cc:
      * tests/import/test_signals.cc: Avoid calls to deprecated Glib::thread_init()
      if glib is new enough.
      This is a step to making Glom build against glibmm from git master with
      --enable-warnings=fatal.
      492690ed
  4. 20 Oct, 2011 6 commits
  5. 19 Oct, 2011 2 commits
    • Murray Cumming's avatar
      Self-hosting: Attempt to avoid failed shutdowns. · 1ef1e126
      Murray Cumming authored
      * glom/libglom/connectionpool.cc: invalidate_connection(): Actually call
      Gda::Connection::close() instead of relying on the Connection destructor to
      do that, because maybe it is not closing it if maybe Connection::is_opened()
      is not working correctly.
      cleanup(): invalidate the connection before shutting down the server,
      not after, in case an open connection is stopping the server from closing down.
      * glom/libglom/connectionpool_backends/postgres_self.[h|cc]:
      connect(): Remember the connection details so we can use them later to show
      debug output.
      Added show_active_connections() to try to get a clue about what is wrong
      when the shutdown fails, using those connection details.
      cleanup(): Call it when the shutdown fails.
      1ef1e126
    • Murray Cumming's avatar
      Do not pygoject_init() the wrong version. · 7a71d707
      Murray Cumming authored
      	* glom/libglom/init.cc: Specify pygobject 3 instead of 2 when calling
      	pygobject_init(). They are parallel-installable and incompatible and it is
      	3 that we depend on. This recently started failing during "make check",
      	which it should.
      7a71d707
  6. 18 Oct, 2011 10 commits
    • Murray Cumming's avatar
      Self hosting test: Check that other tables exist. · 6d1c4843
      Murray Cumming authored
      	* glom/libglom/document/document.[h|cc]: Added get_field_primary_key(),
      	for use by:
      	* tests/test_selfhosting_utils.[h|cc]: Added test_table_exists().
      	* tests/test_selfhosting_new_from_example.cc: Add quick checks that
      	some other tables exist.
      6d1c4843
    • Murray Cumming's avatar
      Avoid a compiler warning. · 6da30a80
      Murray Cumming authored
      	* glom/libglom/data_structure/glomconversions.cc: format_time():
      	Return a result from the catch block.
      6da30a80
    • Murray Cumming's avatar
      Avoid some copy/pasting of code. · baa0549c
      Murray Cumming authored
      * glom/mode_design/print_layouts/print_layout_toolbar_button.cc:
      * glom/utility_widgets/layouttoolbar.cc:
      * glom/utility_widgets/layouttoolbarbutton.cc: Moved get_icon_path() to:
      * glom/utils_ui.[h|cc]
      baa0549c
    • Murray Cumming's avatar
      Test report contents. · 1db3de45
      Murray Cumming authored
      * glom/libglom/xsl_utils.[h|cc]: transform(): Return the contents,
      not a filepath.
      * glom/libglom/report_builder.[h|cc]: report_build(): return the
      contents, not the path. Add report_build_and_save() to get a temporary
      filepath.
      * glom/mode_data/box_data_manyrecords.cc:
      * glom/frame_glom.cc: Adapted.
      * tests/test_selfhosting_new_then_report.cc: Check that some expected
      text is in the generated HTML.
      1db3de45
    • Murray Cumming's avatar
      Test report building. · eca8c786
      Murray Cumming authored
      * tests/test_selfhosting_new_from_example.cc: Move most code into
      utility functions in:
      * tests/test_selfhosting_utils.[h|cc]:
      * tests/test_selfhosting_new_then_report.cc: Add a new test that also
      generates a HTML report.
      * Makefile_tests: Mention the new files.
      eca8c786
    • Murray Cumming's avatar
      Add try/catch around all uses of std::locale(""). · 9158ae51
      Murray Cumming authored
      	* glom/libglom/data_structure/glomconversions.cc: Add try/catch with a warning
      	whenever we use std::locale(""), which means the current locale, because that
      	can throw an exception if the locale is not properly configure.
      	* glom/main.cc: Mention that a non-installed or not-properly-configured
      	locale could be the cause of the problem.
      
      	However, I would like to know exactly what it means for a locale to be
      	properly configured.
      9158ae51
    • Murray Cumming's avatar
      Fix typo in previous commit · d2ba3c19
      Murray Cumming authored
      d2ba3c19
    • Murray Cumming's avatar
      Command line: Correct some exit results. · 450e8efc
      Murray Cumming authored
      * glom/main.cc: Use EXIT_FAILURE and EXIT_SUCCESS instead of 0 and -1,
      and use the correct ones.
      450e8efc
    • Murray Cumming's avatar
      libglom: FieldFomatting: Correct some parameter names. · b0b5ad68
      Murray Cumming authored
      * glom/libglom/data_structure/layout/fieldformatting.h: get_choices_related()
      Rename relationship_name to relatioship. It was already correct in the .cc
      file.
      b0b5ad68
    • Murray Cumming's avatar
      Correct the pkg-config file. · 359137ed
      Murray Cumming authored
      	* glom/libglom/glom.pc.in: Depend on libgdamm-5.0, not ligdamm-4.0.
        And depend on libxslt, because we just moved the xslt stuff into libglom.
      359137ed
  7. 17 Oct, 2011 8 commits
    • Murray Cumming's avatar
      Move ReportBuilder to libglom, to make testing easier. · 6d61144c
      Murray Cumming authored
      * glom/report_builder.[h|cc]:
      * glom/xsl_utils.[h|cc]: Moved to:
      * glom/libglom/report_builder.[h|cc]:
      * glom/libglom/xsl_utils.[h|cc]:
      * Makefile_glom.am, Makefile_libglom.am: Adapted, also adding a
      -D define for libglom to access the xslt file, though I am not happy
      about a library needing a file to be installed.
      6d61144c
    • Murray Cumming's avatar
      ReportBuilder: Do not depend on Base_DB unnecessarily. · 8f2b46a7
      Murray Cumming authored
      * glom/report_builder.[h|cc]: Just add get/set_document() instead.
      8f2b46a7
    • Murray Cumming's avatar
      Move report building code around. · c3d479cd
      Murray Cumming authored
      * glom/report_builder.[h|cc]: report_build(): Return the filepath,
      instead of opening it in the browser.
      * glom/xsl_utils[h|cc]: transform_and_open(): Rename to transform(),
      returning the filepath. Also correct some ustring filepath to std::string.
      * glom/utils_ui[h|cc]: Added show_report_in_browser().
      * glom/frame_glom.cc: on_menu_report_selected():
      * glom/mode_data/box_data_manyrecords.cc: print_layout: Adapted.
      c3d479cd
    • Murray Cumming's avatar
      Move some XSLT-processing code around. · 854ba701
      Murray Cumming authored
      * glom/mode_data/box_data.h: Remove declaration of non-implemented
      and unused xslt_process() method.
      * glom/xsl_utils.[h|cc]: Move xslt_process() in to the .cc file as a
      static function.
      854ba701
    • Murray Cumming's avatar
      Move some Report code around. · aae40ab1
      Murray Cumming authored
      * glom/mode_data/box_data_manyrecords.cc: print_layout():
      Move the report creation to ReportBuilder.
      * glom/report_builder.[h|cc]: Added create_standard_list_report().
      * glom/xsl_utils.cc: Do not output all the XSL and HTML to std::cout,
      but do output the temporary file name of the generated HTML file.
      aae40ab1
    • Murray Cumming's avatar
      List View: Correct the default column widths. · 438137d9
      Murray Cumming authored
      * glom/utils_ui.[h|cc]: get_suitable_field_width_for_widget(): Added a
      for_treeview parameter and adjust the width accordingly.
      * glom/mode_data/db_adddel/db_adddel.cc: treeview_append_colum():
        Replace the overly-generic division-by-3 hack with the new parameter, and
        add some hard-coded extra space.
      438137d9
    • Murray Cumming's avatar
      Details: Avoid an outdent after group titles · 015d5c58
      Murray Cumming authored
      * glom/mode_data/flowtablewithfields.cc: add_layout_group(): Work around
        the GtkFrame bug #644199
      015d5c58
    • Murray Cumming's avatar
      Print Layout: Print Standard: Avoid page break spaces in the middle of pages. · 0cb0e911
      Murray Cumming authored
      	* glom/print_layout/canvas_print_layout.[h|cc]: fill_with_data():
        Add an avoid_page_margins parameter, so we can choose to always move items
        past the margins on to the next page while setting their data.
      	* glom/print_layout/print_layout_utils.[h|cc]: create_standard():
      	Add an avoid_page_margins parameter, so we can choose to do this later instead
      	when setting the data, to avoid big gaps that are later moved down into the
      	middle of the page.
      	do_print_layout(): Add an avoid_page_margins parameter here too, passing
      	it to fill_with_data().
      	* glom/mode_data/box_data_details.cc: print_layout(): Do not avoid page
      	margins when creating, because that will happen when expanding items.
      	Avoid the page margins when setting the details.
      	* glom/mode_design/print_layouts/window_print_layout_edit.cc:
      	on_menu_insert_create_standard(): Avoid page margins when creating.
      	However, those gaps could be left in the middle of the page when printing,
      	because some items may be expanded. We need a way to squash that space
      	later when it is unecessary.
      0cb0e911
  8. 14 Oct, 2011 5 commits
    • Murray Cumming's avatar
      Fix DTD to fix make check. · c9f08af2
      Murray Cumming authored
      * glom/glom_document.dtd: Mention several attributes that were added
      in the last year or so. The new examples/test/ uses them.
      c9f08af2
    • Murray Cumming's avatar
      List: Actually show custom choices, instead of crashing. · 5daa674d
      Murray Cumming authored
      	* glom/mode_data/datawidget/cellcreation.cc: create_cell(): Call
      	set_choices_fixed() if appropriate.
      	* glom/mode_data/datawidget/cellrenderer_dblist.cc: on_editing_started():
      	Replace a g_assert with a warning to std::cerr, in case this happens
      	again, particularly now that we know when it can happen - if there is
      	no text-column set.
      	Bug #661764 (André Klapper)
      5daa674d
    • Murray Cumming's avatar
      Print Layout: Avoid grouping items at the tops of pages. · ec191a49
      Murray Cumming authored
      * glom/print_layout/print_layout_utils.[h|cc]: move_fully_to_page():
      Change this to needs_move_fully_to_page(), so we can decide later how
      much to move the items.
      * glom/print_layout/canvas_print_layout.[h|cc]: move_items_below_item():
      Rename to move_items_down(), not taking an item, and ignoring the x
      dimension, moving everything down.
      Remember the highest item that needs moving down more, because it
      is in a page margin, then move everything below it down by the same
      offset. Keep doing that until no items are in margins, gradually adding
      pages. This is a simple form of pagination, and not a particularly
      efficient one.
      ec191a49
    • Murray Cumming's avatar
      Print Layout: Another expansion fixes. · 0bf04d68
      Murray Cumming authored
      	* glom/print_layout/print_layout_utils.[h|cc]: move_fully_to_page():
      	Move generic CanvasItemMovables instead of just CanvasLayoutItems.
      	* glom/print_layout/canvas_print_layout.cc: move_items_below_item():
      	Likewise.
      0bf04d68
    • Murray Cumming's avatar
      Print Layout: Increase page count correctly when expanding portals. · 7e1d1466
      Murray Cumming authored
      	* glom/print_layout/canvas_print_layout.cc: move_items_below_item():
      	Correct an off-by-one error in the calculation of the number of pages
      	needed.
      7e1d1466