GitLab

* glom/frame_glom.cc: Add a stdout message saying the the
default user has been disabled, because the existing message
about the failure to remove the user looks at first like
a security problem.
I still do not know why removal fails, even though we do
change the ownership of the database.

* glom/base_db.[h|cc]: Move remove_user() and
remove_user_from_group() to
* glom/libglom/db_utils.[h|cc].
* glom/frame_glom.cc:
* glom/mode_design/users/dialog_users_list.cc: Adapted.
* tests/test_selfhosting_new_empty_then_users.cc: Test these
functions.

	* glom/frame_glom.cc: on_menu_developer_developer(): Actually use the
	result of Privs::get_user_is_in_group().
	* tests/test_selfhosting_new_from_example_operator.cc: Test this
	same function here, though this test currently fails anyway.
	Really prevent changing to developer mode for non-developers.
	This fixes bug #669043 (alien)

* glom/libglom/privs.cc: get_table_privileges(): Instead of parsing the
relacl.pg_class field, use the PostgreSQL has_table_privilege()
function, though it needs some strange quoting (see comments).
This code is much simpler now.
* tests/test_selfhosting_new_empty_then_users.cc: Add various other
table, group, and user names, to excercise the code.
This now passes.

* glom/mode_design/users/dialog_new_group.cc:
* glom/mode_design/users/dialog_user.cc: Add includes to fix the build.

* tests/test_selfhosting_new_empty_then_users.cc:
Privs::get_table_privileges() must parse a strange format. This test
shows that it fails if the group name contains spaces.

* glom/libglom/privs.[h|cc]: Add a MAX_ROLE_SIZE enum constants.
I cannot find any PostgreSQL documentation of this 63 character limit.
* glom/mode_design/users/dialog_new_group.cc:
* glom/mode_design/users/dialog_user.cc: Use it to set maximum characters
for the entry boxes.
* tests/test_selfhosting_new_empty_then_users.cc: Show that the problem
found so far was caused by too-long names, not spaces.
I still need to check parsing of table permissions.

* tests/test_selfhosting_new_empty_then_users.cc: Use for loops to
simplify the code and to make sure that we test adding of users with
all the group types.
This shows a problem:
  Privs::get_database_groups() does not contain the expected user:
  group: somegroup with space characters1
  user: someuser with space characters1for_somegroup with space characters1

* tests/test_selfhosting_new_empty_then_users.cc:
Add tables that will be affected.
Test strange characters in group and user names.

* glom/mode_design/users/dialog_groups_list.cc: on_button_group_new():
Move the group creation code to:
* glom/libglom/db_utils.[h|cc]:

* glom/libglom/privs.[h|cc]: set_table_privileges():
Return a bool to report failures.
* Makefile_tests.am:
* tests/test_selfhosting_new_empty_then_users.cc: Add this test to
test simple creation of a group and a user.

* glom/base_db.[h|cc]: Move add_user() to
* glom/libglom/db_utils.[h|cc]:
* glom/frame_glom.cc:
* glom/mode_design/users/dialog_users_list.cc: Adapted.

* glom/libglom/connectionpool.cc: invalidate_connection():
Also clear m_pFieldTypes to make sure that we refill it when making
a new connection.

* glom/libglom/data_structure/fieldtypes.[h|cc]: Add get_types_count().
* tests/test_selfhosting_utils.[h|cc]: Add test_selfhost() to
start an already-existing .glom system.
* Makefile_tests.am:
* tests/test_selfhosting_new_from_example_operator.cc:
Add this new test which attempts to re-open a .glom system as
a non-developer user. This currently fails to get the list of
tables from the database. I must investigate that.

* Makefile_tests.am:
* tests/test_selfhosting_new_empty_change_sysprefs.cc: Add this
test to check that the writing and reading of System Preferences works.

* tests/test_selfhosting_utils.[h|cc]: Add functions for self-hosting
of an empty new database, used by the existing code too.
* Makefile_tests.am:
* tests/test_selfhosting_new_empty.cc: Use test_selfhosting_utils to
simplify this code, making it easier to create variations of this test.

* tests/test_selfhosting_new_empty.cc: Call cleanup if test() returns
false, like we in the other tests, to avoid calling it in too many
places.

* configure.ac: Require goocanvas 2.0.1.

* glom/onlineglom_strings.cc:
* Makefile.am:
* po/POTFILES.in: Mention the new file.
These strings are actually used here:
http://gitorious.org/online-glom/gwt-glom/trees/master/src/main/resources/org/glom/web/client/ui
and I must manually copy the translations across until I find a better way.

* glom/libglom/data_structure/translatable_item.h: This
method is not used, of course.

* glom/libglom/data_structure/print_layout.[h|cc]:
* glom/libglom/data_structure/report.[h|cc]:
* glom/libglom/data_structure/tableinfo.[h|cc]: Hide the member
variables behind getters and setters.
* glom/application.cc:
* glom/base_db.cc:
* glom/libglom/db_utils.cc:
* glom/libglom/document/document.cc:
* glom/libglom/report_builder.cc:
* glom/mode_design/print_layouts/window_print_layout_edit.cc:
* glom/mode_design/report_layout/dialog_layout_report.cc:
* glom/navigation/box_tables.cc:
* glom/print_layout/canvas_print_layout.[h|cc]:
* glom/print_layout/print_layout_utils.cc:
* tests/test_document_load.cc: Adapt.
This avoids java-libglom from generating getM_*() and setM_*() methods,
as well as being generally correct.

* glom/libglom/db_utils.cc: set_database_preferences(): Also UPDATE
the organization name.

This fixes bug #668836 (alien)

* glom/mode_design/layout/layout_item_dialogs/box_formatting.cc:
on_combo_choices_relationship_changed(): By default, automatically
choose the related table's primary key as the field to show in the
choices. Other fields should then be shown (or looked up) based on the
chosen ID.
This avoids the confusion noticed here: https://bugzilla.gnome.org/show_bug.cgi?id=668759#c21

* glom/mode_data/datawidget/cellrenderer_dblist.cc:
repack_cells_related(): Do not crash if create_cell() returns 0,
and add a comment explaining that that is OK.
* glom/mode_data/datawidget/cellcreation.cc: Add explanatory comments.

This fixes the second crash mentioned in #668759 (alien).

* glom/mode_data/datawidget/treemodel_db.h: Make most methods and
members private again, documentation what they *key methods and members
really mean.
* glom/mode_data/datawidget/treemodel_db_withextratext.[h|cc]: Add
m_column_index_first and m_item_first members.
Constructor: Set these by looking for the first LayoutItem_Field,
because that is what we will want to show in the first cell of
a combobox, which is where this model is used.
Use these instead of the *key members, which were actually the primary
key. We had previously assumed that the first field would always be
the primary key, but we should not enforce that.
This fixes crashing bug #668759 (alien).

	* glom/libglom/data_structure/layout/layoutitem_field.h:
	predicate_LayoutItem_Field_IsSameField: Let this be used with containers of
	LayoutItems as well as just LayoutItem_Fields.
	* glom/libglom/utils.[h|cc]: Add get_layout_items_plus_primary_key().
	* glom/mode_data/box_data_list.cc: create_layout(): Simplify code by using
	get_layout_items_plus_primary_key().
	* glom/mode_data/datawidget/combochoiceswithtreemodel.cc:
	set_choices_related(): Use get_layout_items_plus_primary_key() so the
	model has the primary key, avoiding a warning and a later crash.

* Makefile_tests.am:
* tests/test_selfhosting_new_from_example_in_locales.sh:
Run the test_selfhosting_new_from_example example in various
locales, to make sure that the libgda problem (see bug #668346),
or something like it, does not come back.
* tests/test_selfhosting_new_from_example.cc: Call setlocale().

* glom/glom_document.dtd: <connection>: Port and server should be
optional because the document can specify a SQLite file instead.
* glom/libglom/document/document.cc: save_before(): Remove all
children of the root node before recreating them, to avoid keeping
old stuff.

	* examples/example_film_manager.glom:
	* examples/example_lesson_planner.glom:
	* examples/example_music_collection.glom:
	* examples/example_project_manager.glom:
	* examples/example_smallbusiness.glom: