1. 21 Sep, 2009 4 commits
  2. 18 Sep, 2009 4 commits
    • Murray Cumming's avatar
      Maemo: Use some Hildon widgets. · 5bbc84a8
      Murray Cumming authored
      * glom/utility_widgets/entryglom.[h|cc]:
      * glom/utility_widgets/textviewglom.h: Use Hildon::TextView and Hildon::Entry.
    • Murray Cumming's avatar
      Fix a typo to fix the build on maemo. · 1b546445
      Murray Cumming authored
    • Murray Cumming's avatar
      CsvParser: Made some API private. · e0fa4a2a
      Murray Cumming authored
      * glom/dialog_import_csv.[h|cc]: get_field_for_column(): Return a
      sharedptr<const>, not a silly const sharedptr<>&.
      * glom/dialog_import_csv_progress.cc:
      * glom/import_csv.[h|cc]: add get_state() and get_rows_count(). Make
      some API private to make it clearer what needs to be done to make
      this a real self-contained class.
    • Murray Cumming's avatar
      CSV Import: Minor code style changes. · 4828bb2d
      Murray Cumming authored
      * glom/dialog_import_csv.cc:
      * glom/dialog_import_csv_progress.cc:
      * glom/import_csv.[h]cc]: Prefix the state enum with STATE_.
      Use 0 instead of NULL because this is C++. Remove some debug output.
      Make signal type and variable names consistent with other code.
      * tests/import/test_signals.cc: Add a last std::endl.
  3. 17 Sep, 2009 3 commits
    • Michael Hasselmann's avatar
      Refactoring Dialog_Import_CSV: created testcase for the CsvParser's signal emission · b0415320
      Michael Hasselmann authored
      * Makefile_tests.am: all tests now run within valgrind by default since mem
      leaks in testcases are potential mem leaks in the application. Parameters might
      need tweaking.
      * glom/import_csv.cc (CsvParser::on_idle_parse): Fixed a missing negation in a
      conditional, which was wrongfully leading to signal emissions. Found by the
      import signals testcase.
      * test/import/test_parsing.cc: Fixed a null byte issue when setting the raw
      contents of the parser.
      * test/import/test_signals.cc: This testcase checks the CsvParser's signal
      emission on varying input. The basic idea was to have on testcase for each
      code path that leads to a signal emission in glom/import_csv.cc, even if that
      leads to overlapping code coverage tests with the parser testcase.
    • Johannes Schmid's avatar
      Replace a TODO comment with g_assert_val_if_reached() · 66e2d4e2
      Johannes Schmid authored
      Reaching this branch would mean that the dialog returned an unhandled response.
    • Johannes Schmid's avatar
      Really check if pygda module is available. · 3460b8c0
      Johannes Schmid authored
      A typo caused the check for the glom module twice while the gda module wasn't checked at all
  4. 16 Sep, 2009 1 commit
  5. 14 Sep, 2009 4 commits
  6. 09 Sep, 2009 1 commit
    • Michael Hasselmann's avatar
      Refactoring Glom::Dialog_Import_CSV · 8076d24b
      Michael Hasselmann authored
      * ChangeLog, Makefile_glom.am, glom/dialog_import_csv.[h|cc],
      glom/import_csv.[h|cc], glom/dialog_import_csv_progress.cc: Moved the inlined
      Parser class from the Dialog_Import_CSV class to the new CsvParser class.  The
      CsvParser already handles the line scanning and encoding conversion but is
      supposed to take over the file reading responsibility as well.  In order to
      allow the Dialog_Import_CSV class to parse a scanned line into its tree model
      the parser emits a lineScanned signal, with the currently scanned line as
  7. 08 Sep, 2009 1 commit
  8. 05 Sep, 2009 11 commits
  9. 04 Sep, 2009 8 commits
    • Murray Cumming's avatar
      offer_new_or_existing(): Add Gtk::Builder error handling . · 46066fb2
      Murray Cumming authored
      * glom/application.cc: offer_new_or_existing(): Add error handling to
      show how GtkBuilder complains about Atk objects in .glade files on
      Maemo, and actually fails.
    • Murray Cumming's avatar
      Fix the build when -fno-exceptions · 7b58ecc0
      Murray Cumming authored
      is used.
    • Murray Cumming's avatar
      Added dlopen test of the python library. · abe4d551
      Murray Cumming authored
      * glom/libglom/test_connectionpool.cc:
      * glom/libglom/test_document.cc: Fixed the build without exceptions.
      * Makefile_tests.am: Added test_load_python_library, using dlopen()
      to show the numpunct linker error (bug #594142) without actually using
    • Murray Cumming's avatar
      Avoid compiler warnings. · 1dbba0b4
      Murray Cumming authored
      * configure.ac: Add a comment about using the PYTHON environment
      variable to specify the python version.
      * glom/dialog_existing_or_new.cc:
      * glom/dialog_import_csv_progress.cc:
      * glom/utility_widgets/canvas/canvas_group_resizable.cc: Avoid some
      compiler warnings, mostly about missing returns in unlikely
    • Murray Cumming's avatar
      Mention the failed python module name on stdcerr. · 7a00472e
      Murray Cumming authored
      * glom/python_embed/glom_python.cc: glom_python_module_is_available(),
      gda_python_module_is_available(): Output a hint to the command-line too,
      in case maemo crashes when showing UI as mine does at the moment,
      and to mention the exact python module name that failed.
    • Daniel Elstner's avatar
      Do not try to catch non-existing MetaStructError · beb62fb1
      Daniel Elstner authored
      * glom/base_db.cc (Base_DB::get_fields_for_table_from_database):
      For now, catch Glib::Error instead of Gnome::Gda::MetaStructError,
      which does not exist.
    • Murray Cumming's avatar
      Fix the client-only non-maemo build on maemo. · 9c637c9f
      Murray Cumming authored
      * configure.ac: Correct the AS_IF() calls so that we really do not
      need iso-codes in client-only mode.
      * glom/print_layout/canvas_layout_item.cc:
      * glom/print_layout/canvas_print_layout.cc:
      * glom/printoperation_printlayout.cc: Fix the build without
      exceptions, without properties and without default signal handlers,
      with ifdefs.
      * glom/base_db.cc: get_fields_for_table_from_database(): Actually add
      a no-exceptions ifdef for the use of Gda::MetaStruct::complement()
      instead of just ifdefing it out for Maemo.
      * glom/mode_data/notebook_data.cc:
      * glom/utility_widgets/adddel/adddel.cc:
      * glom/utility_widgets/db_adddel/db_adddel.cc:
      * glom/utility_widgets/entryglom.cc:
      * glom/utility_widgets/imageglom.cc:
      Likewise, ifdef the use of get_accessible on GTKMM_ATKMM_ENABLED instead
      of GLOM_ENABLE_MAEMO, to fix the client-only non-maemo build on Maemo.
      Again, please stop abusing the MAEMO ifdef for hacks without even a TODO.
    • Murray Cumming's avatar
  10. 03 Sep, 2009 3 commits
    • Murray Cumming's avatar
      Moved more design-only classes to glom/mode_design/ · a30d42a1
      Murray Cumming authored
      * glom/libglom/data_structure/iso_codes.[h|cc]:
       * glom/utility_widgets/comboentry_currency.cc
      * glom/mode_design/translation/:
      Moved to glom/mode_design/.
      * glom/Makefile_glom.am, *.[h|cc]:
      * po/POTFILES.in: Adapted.
      * configure.ac: Make use of iso-codes dependent on client-only, not
      maemo, because that actually makes sense.
    • Murray Cumming's avatar
      Move some non-layout print_layout code back out of mode_design · 740dd5f2
      Murray Cumming authored
      	* glom/mode_design/print_layouts/canvas_layout_item.[h|cc]:
      	* glom/mode_design/print_layouts/canvas_print_layout.[h|cc]:
      	Moved to glom/print_layout/, because they are used by client-only mode
      	* glom/Makefile_glom.am, *.[h|cc]: Adapted.
      	* po/POTFILES.in: Update for moved files.
    • Murray Cumming's avatar
      Moved many developer-mode files into glom/mode_design/ now that our · 34e6b88a
      Murray Cumming authored
      	non-recursive build allows that without linker errors.
      	* glom/combobox_fields.[h|cc]:
      	* glom/combobox_relationship.[h|cc]:
      	* glom/layout_item_dialogs/:
      	* glom/mode_data/dialog_choose_field.[h|cc]:
      	* glom/mode_data/dialog_choose_relationship.[h|cc]:
      	* glom/mode_data/dialog_layout*.[h|cc]:
      	* glom/mode_data/treestore_layout.[h|cc]:
      	* glom/layout_item_dialogs/:
      	Moved to glom/mode_design/layout/
      	* glom/reports/report_builder.[h|cc]: Moved to glom/
      	* glom/reports/dialog_layout_report.[h|cc]"
      	* glom/reports/treestore_report_layout.[h|cc]:
      	Moved to glom/mode_design/report_layout/
      	* glom/database_preferences.[h|cc]:
      	* glom/relationships_overview/: Moved to
      	* glom/glom_developer.glade:
      	* glom/dialog_new_self_hosted_connection.[h|cc]:Rename to
      	glom/mode_design/dialog_initial_password.[h|cc], renaming the class too,
      	because that's what this is now.
      	* glom/utility_widgets/dialog_layoutitem_properties.[h|cc]: Removed
      	this unused class.
      	* glom/Makefile_glom.am, *.[h|cc]: Adapted.