GitLab

* glom/utils_ui.[h]cc]: Added get_filepath_with_extension() to add
(if necessary) a specified file extension to a filepath.
* glom/frame_glom.cc: on_menu_file_export(): Add a .csv file
extension if not already specified, so we automatically see the
export file in the file chooser when importing.

when accessing the vector of vectors. Note that this check is
already in the appropriate place in the import_csv_refactored branch.
This makes bug #593304 slighly clearer, though it is now an endless
loop with debug output.

* glom/dialog_import_csv.cc: Set the number of sample rows to 2
by default, not 0.
a secondary top-level object (textbuffer).

the .so name and header install location. Noticed by Chris Coulson.

* Makefile_tests.am, test/import/utils.[cc|h],
tests/import/test_[parsing|signals].cc: Only report on failure. Moved common
parts into an utility namespace.

* glom/utility_widgets/entryglom.[h|cc]:
* glom/utility_widgets/textviewglom.h: Use Hildon::TextView and Hildon::Entry.

* glom/dialog_import_csv.[h|cc]: get_field_for_column(): Return a
sharedptr<const>, not a silly const sharedptr<>&.
* glom/dialog_import_csv_progress.cc:
* glom/import_csv.[h|cc]: add get_state() and get_rows_count(). Make
some API private to make it clearer what needs to be done to make
this a real self-contained class.

* glom/dialog_import_csv.cc:
* glom/dialog_import_csv_progress.cc:
* glom/import_csv.[h]cc]: Prefix the state enum with STATE_.
Use 0 instead of NULL because this is C++. Remove some debug output.
Make signal type and variable names consistent with other code.
* tests/import/test_signals.cc: Add a last std::endl.

* Makefile_tests.am: Do not run all tests under valgrind. valgrind is
for humans to read, and make check has no way to know if the result is
appopriate or not. Run things under valgrind when you want to.

* Makefile_tests.am: all tests now run within valgrind by default since mem
leaks in testcases are potential mem leaks in the application. Parameters might
need tweaking.

* glom/import_csv.cc (CsvParser::on_idle_parse): Fixed a missing negation in a
conditional, which was wrongfully leading to signal emissions. Found by the
import signals testcase.

* test/import/test_parsing.cc: Fixed a null byte issue when setting the raw
contents of the parser.

* test/import/test_signals.cc: This testcase checks the CsvParser's signal
emission on varying input. The basic idea was to have on testcase for each
code path that leads to a signal emission in glom/import_csv.cc, even if that
leads to overlapping code coverage tests with the parser testcase.

Reaching this branch would mean that the dialog returned an unhandled response.

Unfortunately this test doesn't trigger the crash bug that happens on exit() on the maemo platform.

A typo caused the check for the glom module twice while the gda module wasn't checked at all

* glom/glom.glade: The encoding info now has more space for itself and properly
expands, whereas the encoding combobox doesn't take up more hspace than
needed.

	* glom/glom.glade: main_window: Put the Records:/Found: widgets in
	sub-hboxes, and change their order by hand in the .glade file because
	GtkBuilder and Glade do not seem to interpret the file in the same way.

2009-09-14  Murray Cumming  <murrayc@murray.com>

* glom/frame_glom.cc:
* glom/utility_widgets/flowtable.cc: Fixed warnings-as-errors build
problems with the latest gtkmm.

* Makefile_tests.am, tests/import.sh,
tests/import/test_parsing.cc: The first tests for the CsvParser are ready.
Basic input is tested but no real world examples yet. Run with 'make check
TESTS=tests/import.sh' to run tests with valgrind.

Renamed regression_tests folder to tests

* ChangeLog, Makefile_glom.am, glom/dialog_import_csv.[h|cc],
glom/import_csv.[h|cc], glom/dialog_import_csv_progress.cc: Moved the inlined
Parser class from the Dialog_Import_CSV class to the new CsvParser class.  The
CsvParser already handles the line scanning and encoding conversion but is
supposed to take over the file reading responsibility as well.  In order to
allow the Dialog_Import_CSV class to parse a scanned line into its tree model
the parser emits a lineScanned signal, with the currently scanned line as
parameter.

* glom/frame_glom.[h|cc]: connection_request_password_and_attempt():
Move some decision-making into handle_request_password_connection_error,
to allow us to handle the no-exception API better, though this is
clearer anyway, or would be without the ifdefs.

for unsupported backends.

Correct and ifdef to an ifndef.

* glom/application.[h|cc]: Remove unused (and unnecessary since the new
initial dialog) on_menu_file_open() and on_menu_file_close() overrides
and ui_file_select_open_with_browse().
* glom/dialog_existing_or_new.cc: on_select_clicked(): Use
Hildon::FileChooserDialog on Maemo.
* glom/bakery/app_withdoc_gtk.cc: Remove the uncommented undef of
GLOM_ENABLE_MAEMO - no more nasty hacks please. Instead comment-out
the set_menu() call with a TODO, leaving the rest of the maemo-specific
code working.

* glom/application.[h|cc]:
Added check_document_hosting_mode_is_supported() to warn the user
if the build cannot use the hosting mode in the file, and call it from
on_document_load().
* glom/libglom/document/bakery/document.cc: load(), load_from_data():
Call set_is_new(false) so we can check for this in
App/View::on_document_load(), to avoid complaining about an unused
default hosting mode.

actually handle the enum for opening an existing file in client mode.

* glom/application.cc: offer_new_or_existing(): Add error handling to
show how GtkBuilder complains about Atk objects in .glade files on
Maemo, and actually fails.