GitLab

This seems to fix the crash when choosing an image repeatedly:
https://bugzilla.gnome.org/show_bug.cgi?id=761396#c13

Because recent versions of libevince-view have an assert that crashes
the application:
https://bugzilla.gnome.org/show_bug.cgi?id=761396#c12

It seems useful.

I guess this is why I haven't been seeing the busy cursor recently.
Found by clang-tidy.

Doing that just to unconst the members is still awful, but at least
this is explicit about what we are doing.

Why didn't the compiler catch this?

See https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#sl50-avoid-endl

So we can use std::unique_ptr<> instead of std::shared_ptr<> for the
parser member variable, and generally make the APIs slightly less
tightly bound.

Because nothing shares it.

Found by clang-tidy's misc-use-override check.

With help from clang-modernize-3.7.

With help from clang-modernize-3.7.

Otherwise, we still get the dropped table name when asking libgda
for a list of tables. This caused Glom to complain that a
previously-deleted table name already existed when the user tried to
recreate it.
Bug #754645 (m.rick.mac)

So we always get the same result regardless of the current locale,
because the "data" shouldn't really be locale-specific.
This has disadvantages for collation but we also want the database
to be fairly portable across environments.

This might help this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=761372

Because this can fail in the real world and it would be nice to know
as soon as possible:
https://bugzilla.gnome.org/show_bug.cgi?id=761373