GitLab

	* glom/application.cc: set_progress_message(): Set the main UI elements to
	insensitive(), because all our current uses of the progess message should
	block user input, like a modal dialog.
	* ui/operator/window_main.glade: Move the InfoBar out of the frame, because
	it should not have the border, and so we can make the frame insensitive
	without making the InfoBar insensitive.

* Makefile_glom.am:
* glom/application.[h|cc]: Move the ShowProgressMessage class to separate
.h/.cc files because I generally prefer one .h/.cc per class.

* glom/application.[h|cc]: Move implementation into .cc file. Correct the code
style. Make the constructor explicit.

* configure.ac: Add a comment about not linking to gthread-2.0 in future.
* glom/libglom/init.cc:
* tests/import/test_parsing.cc:
* tests/import/test_signals.cc: Avoid calls to deprecated Glib::thread_init()
if glib is new enough.
This is a step to making Glom build against glibmm from git master with
--enable-warnings=fatal.

* glom/libglom/db_utils.cc: move it back to:
* glom/libglom/utils.[h|cc]: because it is needed by java-libglom.

	* tests/test_selfhosting_utils.[h|cc]: test_create_and_selfhost():
	Add a hosting_mode parameter so we can test sqlite too.
	Correct some return values and check that the directory really exists after
	it should have been created.
	* tests/test_selfhosting_new_empty.cc:
	* tests/test_selfhosting_new_from_example.cc:
	* tests/test_selfhosting_new_then_report.cc:
	* tests/test_selfhosting_sqlinjection.cc: Restructure so all tests are run
	twice - once for each backend.

	* glom/libglom/db_utils.[h|cc]: recreate_database_from_document(): Do not
	call add_standard_tables() and add_standard_groups() because create_database()
	(which we call) has already done this.
	query_execute_string(): Only -1 is an error, though that is odd.
	See libgda bug #662279 .

	* glom/libglom/utils.cc:
	* glom/base_db.[h|cc]: Moved count_rows_returned_by() to
 	* glom/libglom/db_utils.[h|cc]: and also moved
  Utils::build_sql_select_count_row() making it static (not API).
	* glom/frame_glom.cc:
	* glom/mode_data/datawidget/treemodel_db.cc: Adapted.

* tests/test_selfhosting_sqlinjection.cc: Try to avoid quoting by
saying that a text field is a number but still providing a text value.

2011-10-19  Murray Cumming  <murrayc@murrayc.com>

SQL Injection Test: Try to use (evil and unquoted) text for a number.

* tests/test_selfhosting_sqlinjection.cc: This seems to be safe already.

* tests/test_selfhosting_sqlinjection.cc: This seems to be safe already.

https://bugzilla.gnome.org/show_bug.cgi?id=662143

* tests/test_selfhosting_sqlinjection.cc: Instead of assuming that we know
what libgda uses.

* glom/libglom/connectionpool.cc: invalidate_connection(): Actually call
Gda::Connection::close() instead of relying on the Connection destructor to
do that, because maybe it is not closing it if maybe Connection::is_opened()
is not working correctly.
cleanup(): invalidate the connection before shutting down the server,
not after, in case an open connection is stopping the server from closing down.
* glom/libglom/connectionpool_backends/postgres_self.[h|cc]:
connect(): Remember the connection details so we can use them later to show
debug output.
Added show_active_connections() to try to get a clue about what is wrong
when the shutdown fails, using those connection details.
cleanup(): Call it when the shutdown fails.

	* tests/test_selfhosting_new_from_example.cc: Add some missing !.

	* glom/libglom/init.cc: Specify pygobject 3 instead of 2 when calling
	pygobject_init(). They are parallel-installable and incompatible and it is
	3 that we depend on. This recently started failing during "make check",
	which it should.

* tests/test_selfhosting_sqlinjection.cc: Attempt to do bad things
that would be possible if our SQL values were not escaped properly
in the SQL. (libgda takes care of this.)
* Makefile_tests.am: Mention the new test.

	* glom/libglom/document/document.[h|cc]: Added get_field_primary_key(),
	for use by:
	* tests/test_selfhosting_utils.[h|cc]: Added test_table_exists().
	* tests/test_selfhosting_new_from_example.cc: Add quick checks that
	some other tables exist.

	* tests/test_selfhosting_utils.[h|cc]: Added test_model_expected_size().
	* tests/test_selfhosting_new_from_example.cc: Test the quick find and
	the count query.

	* glom/libglom/data_structure/glomconversions.cc: format_time():
	Return a result from the catch block.

* glom/mode_design/print_layouts/print_layout_toolbar_button.cc:
* glom/utility_widgets/layouttoolbar.cc:
* glom/utility_widgets/layouttoolbarbutton.cc: Moved get_icon_path() to:
* glom/utils_ui.[h|cc]

* glom/libglom/xsl_utils.[h|cc]: transform(): Return the contents,
not a filepath.
* glom/libglom/report_builder.[h|cc]: report_build(): return the
contents, not the path. Add report_build_and_save() to get a temporary
filepath.
* glom/mode_data/box_data_manyrecords.cc:
* glom/frame_glom.cc: Adapted.
* tests/test_selfhosting_new_then_report.cc: Check that some expected
text is in the generated HTML.

* tests/test_selfhosting_new_from_example.cc: Move most code into
utility functions in:
* tests/test_selfhosting_utils.[h|cc]:
* tests/test_selfhosting_new_then_report.cc: Add a new test that also
generates a HTML report.
* Makefile_tests: Mention the new files.

* examples/example_film_manager.glom: Make the Scenes table appear first so
people get a better idea of what this is about - managing production of a
single film, not managing a collection of films.

	* tests/test_glom_date_in_locales.sh: A new test that sets LANG and then tries
	to start glom with it's date-checking option, to see if any fail.
	However, this is not run during "make check", or even distributed, because
	it depends on you having the locales installed and configured.

	* en_CA.po: Added a translation for the date format, because the default
	does not show 4-digit years. This avoids the warning at startup, which
	asks the translator to deal with it.
	Note that I used YYYY/MM/DD instead of DD/MM/YYY, because a) It is
  apparrently	the official format for Canada, though the other one is still
  common, and b) date parsing failed with DD/MM/YY in this locale.

	* glom/libglom/data_structure/glomconversions.cc: Add try/catch with a warning
	whenever we use std::locale(""), which means the current locale, because that
	can throw an exception if the locale is not properly configure.
	* glom/main.cc: Mention that a non-installed or not-properly-configured
	locale could be the cause of the problem.

	However, I would like to know exactly what it means for a locale to be
	properly configured.

* glom/main.cc: Use EXIT_FAILURE and EXIT_SUCCESS instead of 0 and -1,
and use the correct ones.

* glom/libglom/data_structure/layout/fieldformatting.h: get_choices_related()
Rename relationship_name to relatioship. It was already correct in the .cc
file.

	* glom/libglom/glom.pc.in: Depend on libgdamm-5.0, not ligdamm-4.0.
  And depend on libxslt, because we just moved the xslt stuff into libglom.