GitLab

* glom/utils_ui.[h|cc]: get_suitable_field_width_for_widget(): Added a
for_treeview parameter and adjust the width accordingly.
* glom/mode_data/db_adddel/db_adddel.cc: treeview_append_colum():
  Replace the overly-generic division-by-3 hack with the new parameter, and
  add some hard-coded extra space.

* glom/mode_data/flowtablewithfields.cc: add_layout_group(): Work around
  the GtkFrame bug #644199

	* glom/print_layout/canvas_print_layout.[h|cc]: fill_with_data():
  Add an avoid_page_margins parameter, so we can choose to always move items
  past the margins on to the next page while setting their data.
	* glom/print_layout/print_layout_utils.[h|cc]: create_standard():
	Add an avoid_page_margins parameter, so we can choose to do this later instead
	when setting the data, to avoid big gaps that are later moved down into the
	middle of the page.
	do_print_layout(): Add an avoid_page_margins parameter here too, passing
	it to fill_with_data().
	* glom/mode_data/box_data_details.cc: print_layout(): Do not avoid page
	margins when creating, because that will happen when expanding items.
	Avoid the page margins when setting the details.
	* glom/mode_design/print_layouts/window_print_layout_edit.cc:
	on_menu_insert_create_standard(): Avoid page margins when creating.
	However, those gaps could be left in the middle of the page when printing,
	because some items may be expanded. We need a way to squash that space
	later when it is unecessary.

https://bugzilla.gnome.org/show_bug.cgi?id=660496

* glom/glom_document.dtd: Mention several attributes that were added
in the last year or so. The new examples/test/ uses them.

* tests/python/test_load_python_library.cc: Noticed on OpenBSD in
bug #660495 (Jasper Lievisse Adriaanse).
I don't know why this worked on Linux.

	* examples/example_lesson_planner.glom: Remove an old button script
	from the XML though it was not used anymore in the UI.
	* examples/example_project_manager.glom: Contacts: Remove the Test
	button. It is in the small business example already instead.

	* examples/example_smallbusiness.glom: This fixes this crash, which
	apparently happens when trying to use pygtk when pygobject-3 is
	already loaded:
	Warning: specified class size for type `PyGtkGenericCellRenderer' is
	smaller than the parenttype's `GtkCellRenderer' class size

	Bug #661766 (André Klapper)

	* glom/mode_data/datawidget/cellcreation.cc: create_cell(): Call
	set_choices_fixed() if appropriate.
	* glom/mode_data/datawidget/cellrenderer_dblist.cc: on_editing_started():
	Replace a g_assert with a warning to std::cerr, in case this happens
	again, particularly now that we know when it can happen - if there is
	no text-column set.
	Bug #661764 (André Klapper)

* glom/print_layout/print_layout_utils.[h|cc]: move_fully_to_page():
Change this to needs_move_fully_to_page(), so we can decide later how
much to move the items.
* glom/print_layout/canvas_print_layout.[h|cc]: move_items_below_item():
Rename to move_items_down(), not taking an item, and ignoring the x
dimension, moving everything down.
Remember the highest item that needs moving down more, because it
is in a page margin, then move everything below it down by the same
offset. Keep doing that until no items are in margins, gradually adding
pages. This is a simple form of pagination, and not a particularly
efficient one.

	* glom/print_layout/print_layout_utils.[h|cc]: move_fully_to_page():
	Move generic CanvasItemMovables instead of just CanvasLayoutItems.
	* glom/print_layout/canvas_print_layout.cc: move_items_below_item():
	Likewise.

	* glom/print_layout/canvas_print_layout.cc: move_items_below_item():
	Correct an off-by-one error in the calculation of the number of pages
	needed.

* glom/print_layout/print_layout_utils.cc: create_standard():
Make text fields multiline if they are multiline on the details
layout.

	* glom/print_layout/canvas_print_layout.cc: move_items_below_item():
	Check that we don't move the item itself.

* glom/print_layout/print_layout_utils.[h|cc]: Remove the hacky get_units()
function.

* glom/libglom/data_structure/layout/layoutitem.[h|cc]: Add
  set_print_layout_position_y() for convenience.
* glom/print_layout/print_layout_utils.cc: create_standard(): Use
move_fully_to_page().

* glom/print_layout/canvas_print_layout.[h|cc]: Moved get_page_for_y() and
move_fully_to_page() to:
* glom/print_layout/print_layout_utils.[h|cc]:

* glom/print_layout/canvas_print_layout.cc: get_page_for_y(): Correct this
  calculation.

* glom/application.cc: Use set_version().

* glom/navigation/box_tables.cc: Remove the autoincrement rows for all
autoincrement fields.

	* glom/libglom/db_utils.[h|cc]: Added remove_auto_increment().
	* glom/navigation/box_tables.cc: on_adddel_Delete(): Remove the primary key's
	autoincrement too.
	Bug #661653

	* glom/libglom/db_utils.cc: Otherwise we risk having an empty where clause,
	and doing unwanted things to the entire table.

	* glom/libglom/db_utils.cc: Add a utility function for adding the where
	clause for the auto-increments table.

* glom/bakery/dialog_offersave.cc:
* glom/import_csv/dialog_import_csv.cc:
* glom/mode_design/fields/dialog_fieldcalculation.cc:
* glom/mode_design/layout/combobox_relationship.cc:
* glom/mode_design/layout/dialog_layout_details.cc:
* glom/mode_design/layout/layout_item_dialogs/dialog_buttonscript.cc:
* glom/navigation/box_tables.cc:
* glom/utils_ui.cc: Let translators arrange built strings.

* examples/tests/example_field_formatting_test.glom: New file.

* glom/mode_data/box_data_details.cc: This is now the same as when
printing a non-standard print layout.

* glom/mode_design/fields/dialog_fielddefinition.h: Use the table
(from the .glade file) via Gtk::Widget*.
* ui/developer/window_print_layout_edit.glade: Replace the GtkTable
with a GtkGrid.
* glom/mode_design/print_layouts/window_print_layout_edit.cc:
Adapt.
There are still GtkTables in the other .glade files, but this at least
lets us build with gtkmm 3.3/3.4 even with --enable-warnings=fatal.

* glom/print_layout/print_layout_utils.[h|cc]: moved get_page_height()
from CanvasPrintLayout to here. And actually get the margins.
* glom/print_layout/canvas_print_layout.cc: get_page_y_start_and_end():
Use it here.
get_page_height(): Forward to the PrintLayoutUtils versions, passing
the extra parameters.

* glom/print_layout/canvas_print_layout.[h|cc]: move_items_below_item():
Use a new move_fully_to_page() method to make sure that items are never
in the margins if that is possible, when expanding related records
portals for real data.
Also add extra pages when necessary.

* glom/print_layout/canvas_layout_item.[h|cc]: Added
move_items_below_item().
* glom/print_layout/canvas_print_layout.[h|cc]: fill_with_data_portal():
move other items lower when changing the size of the portal's table.

* glom/print_layout/canvas_layout_item.[h|cc]:
Moved get_canvas_table_cell_child() here from CanvasPrintLayout.
create_canvas_item_for_layout_item(): Move the table-child creation
code into add_portal_rows_if_necessary().
* glom/print_layout/canvas_print_layout.[h|cc]: fill_with_data_portal():
Add rows, up to the maximum, according to the number of database rows.
* glom/print_layout/print_layout_utils.cc: create_standard():
Set a simple default height for one row, but set a min of 1 and a max
of 100 so it will expand later.

	* examples/example_film_manager.glom:
	* examples/example_music_collection.glom:
	* examples/example_project_manager.glom:
	* examples/example_smallbusiness.glom: Adapt to new document structure.

* glom/glom_document.dtd: Adapted.
* glom/libglom/data_structure/layout/layoutitem_portal.[h|cc]:
set_rows_count(): Return a min and max, and change it from double to
gulong.
* glom/libglom/document/document.cc: load_after(), save_before():
Store it in the document. The old XML attribute was new in Glom 1.19
anyway, so we can change it.

* ui/developer/window_data_layout.glade: Add an extra SpinButton,
adjust the labels, and add explanatory tooltips.
* glom/mode_design/layout/dialog_layout_details.[h|cc]: Adapted.

* glom/mode_data/db_adddel/db_adddel.[h|cc]: set_height_rows():
Take the min and max.
construct_specified_column(): Increase the size if appropriate when
there are more database rows to show.
* glom/mode_design/layout/dialog_layout_list_related.cc:
* glom/print_layout/print_layout_utils.cc:
* glom/libglom/db_utils.cc:
* glom/mode_data/box_data_list_related.cc: Adapted.