1. 13 Feb, 2012 1 commit
  2. 09 Feb, 2012 1 commit
  3. 08 Feb, 2012 2 commits
  4. 06 Feb, 2012 1 commit
  5. 05 Feb, 2012 1 commit
    • Murray Cumming's avatar
      Button scripts and Field Calculations: Test button: Check for pygtk2. · 42ab9898
      Murray Cumming authored
      * glom/mode_data/box_data.cc: :execute_button_script(): Move the
      warning UI into
      * glom/utils_ui.[h|cc]: a new script_check_for_pygtk2_with_warning()
      * glom/mode_design/fields/dialog_fieldcalculation.cc: on_button_test():
      * glom/mode_design/layout/layout_item_dialogs/dialog_buttonscript.cc:
      on_button_test_script(): Use the new function here.
  6. 03 Feb, 2012 12 commits
    • Marek Černocký's avatar
      Updated Czech translation · e9334643
      Marek Černocký authored
    • Daniel Mustieles García's avatar
      Updated Spanish translation · 90f6398d
      Daniel Mustieles García authored
    • Murray Cumming's avatar
      Button scripts: Check and warn about pygtk2 instead of crashing. · 6b5f2993
      Murray Cumming authored
      * glom/libglom/utils.[h|cc]: Add script_check_for_pygtk().
      * Makefile_tests.am:
      * tests/test_script_check_for_problems.cc: Add a test for the check
      * glom/mode_data/box_data.cc: execute_button_script(): Show a
      warning dialog, and do not run the script, if it seems to use pygtk.
      This should help with but #669196 (alien) and ##661766 (Andre Klapper) .
    • Murray Cumming's avatar
      Minor formatting changes · d1a3988b
      Murray Cumming authored
    • Murray Cumming's avatar
      ReportBuilder: Add error checking. · 253cb851
      Murray Cumming authored
      * glom/libglom/report_builder.[h|cc]: Return bool
      from the private methods and check those results.
    • Murray Cumming's avatar
      Reports: Make summary fields work again. · f0c2ed90
      Murray Cumming authored
      * glom/libglom/report_builder.cc: report_build_summary():
      Remove any sort clause (ORDER BY) from the FoundSet because that makes
      no sense for a single row with summary fields. It looks like recent versions
      of PostgreSQL have become more strict about this, producing this error, for
      column invoices.invoice_id must appear in the GROUP BY clause or be used in an aggregate function
      * Makefile_tests.am:
      * tests/test_selfhosting_new_then_report_summary.cc: Add a test for this.
      This fixes bug #669281 (alien)
    • Murray Cumming's avatar
      Remove debug output. · b5f94ac9
      Murray Cumming authored
    • Murray Cumming's avatar
      Fix more group privileges · e959f511
      Murray Cumming authored
    • Murray Cumming's avatar
      Document: Really load the table privileges. · 694bc016
      Murray Cumming authored
      	* glom/libglom/db_utils.[h|cc]: add_group(): Take a bool superuser
      	add_groups_from_document(): Use add_group() instead of executing
      	the ADD GROUP query directly, to make sure that we also start
      	with some sane table privileges defaults, in case nothing else
      	sets the privielges.
      	* glom/libglom/document/document.cc: load_after(): Fix a typo
      	so that the group privileges are really loaded (and then
      	saved again instead of being lost).
      	* examples/example_film_manager.glom:
      	* examples/example_smallbusiness.glom: Save these with
      	useful group privileges, so the groups will be allowed to
      	see tables.
      	* tests/test_document_load.cc: Test the loading of the group
      	Previously the examples were created with groups that could not
      	even view the tables, which meant that they could not even
      	find out about their existence.
      	This deals with the problem found here:
      	But I would like to show the existence (and structure) of tables
      	even if their data cannot be viewed, so there is more work to do.
    • Murray Cumming's avatar
      test_selfhosting_new_empty_then_users: Slight improvement. · 7d6715ef
      Murray Cumming authored
      	* tests/test_selfhosting_new_from_example_operator.cc: Check
      	that the group exists before adding a user to it.
    • Murray Cumming's avatar
      Add some runtime warnings. · 7193b1f9
      Murray Cumming authored
      	* glom/libglom/db_utils.cc: get_table_names_from_database():
      	Slightly improved error checking.
      	* glom/libglom/privs.cc: set_table_privileges():
      	Warn if a GRANT fails.
    • Kjartan Maraas's avatar
      Updated Norwegian bokmål translation · 2633b032
      Kjartan Maraas authored
  7. 02 Feb, 2012 12 commits
  8. 01 Feb, 2012 10 commits
    • Murray Cumming's avatar
      Allow user and group names to have spaces and other special characters. · ce417b97
      Murray Cumming authored
      * glom/libglom/privs.cc: get_table_privileges(): Instead of parsing the
      relacl.pg_class field, use the PostgreSQL has_table_privilege()
      function, though it needs some strange quoting (see comments).
      This code is much simpler now.
      * tests/test_selfhosting_new_empty_then_users.cc: Add various other
      table, group, and user names, to excercise the code.
      This now passes.
    • Murray Cumming's avatar
      Fix the build. · 6e779a38
      Murray Cumming authored
      * glom/mode_design/users/dialog_new_group.cc:
      * glom/mode_design/users/dialog_user.cc: Add includes to fix the build.
    • Murray Cumming's avatar
      test_selfhosting_new_empty_then_users: Show the problem with spaces. · b1e34c7f
      Murray Cumming authored
      * tests/test_selfhosting_new_empty_then_users.cc:
      Privs::get_table_privileges() must parse a strange format. This test
      shows that it fails if the group name contains spaces.
    • Murray Cumming's avatar
      Fix typos · 91b06b02
      Murray Cumming authored
    • Murray Cumming's avatar
      Limit user and group name lengths. · 739a0452
      Murray Cumming authored
      * glom/libglom/privs.[h|cc]: Add a MAX_ROLE_SIZE enum constants.
      I cannot find any PostgreSQL documentation of this 63 character limit.
      * glom/mode_design/users/dialog_new_group.cc:
      * glom/mode_design/users/dialog_user.cc: Use it to set maximum characters
      for the entry boxes.
      * tests/test_selfhosting_new_empty_then_users.cc: Show that the problem
      found so far was caused by too-long names, not spaces.
      I still need to check parsing of table permissions.
    • Murray Cumming's avatar
      Fix typo · ccaf384e
      Murray Cumming authored
    • Murray Cumming's avatar
      test_selfhosting_new_empty_then_users: Test user adding with all group names. · 2bd22e21
      Murray Cumming authored
      * tests/test_selfhosting_new_empty_then_users.cc: Use for loops to
      simplify the code and to make sure that we test adding of users with
      all the group types.
      This shows a problem:
        Privs::get_database_groups() does not contain the expected user:
        group: somegroup with space characters1
        user: someuser with space characters1for_somegroup with space characters1
    • Murray Cumming's avatar
      test_selfhosting_new_empty_then_users: Improvements. · 4ad252ec
      Murray Cumming authored
      * tests/test_selfhosting_new_empty_then_users.cc:
      Add tables that will be affected.
      Test strange characters in group and user names.
    • Murray Cumming's avatar
      Add test_selfhosting_new_empty_then_users · 68ad8059
      Murray Cumming authored
      * glom/mode_design/users/dialog_groups_list.cc: on_button_group_new():
      Move the group creation code to:
      * glom/libglom/db_utils.[h|cc]:
      * glom/libglom/privs.[h|cc]: set_table_privileges():
      Return a bool to report failures.
      * Makefile_tests.am:
      * tests/test_selfhosting_new_empty_then_users.cc: Add this test to
      test simple creation of a group and a user.
    • Murray Cumming's avatar
      Add test_selfhosting_new_from_example_operator. · 9c67be8d
      Murray Cumming authored
      * glom/base_db.[h|cc]: Move add_user() to
      * glom/libglom/db_utils.[h|cc]:
      * glom/frame_glom.cc:
      * glom/mode_design/users/dialog_users_list.cc: Adapted.
      * glom/libglom/connectionpool.cc: invalidate_connection():
      Also clear m_pFieldTypes to make sure that we refill it when making
      a new connection.
      * glom/libglom/data_structure/fieldtypes.[h|cc]: Add get_types_count().
      * tests/test_selfhosting_utils.[h|cc]: Add test_selfhost() to
      start an already-existing .glom system.
      * Makefile_tests.am:
      * tests/test_selfhosting_new_from_example_operator.cc:
      Add this new test which attempts to re-open a .glom system as
      a non-developer user. This currently fails to get the list of
      tables from the database. I must investigate that.