Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G glibmm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • glibmm
  • Merge requests
  • !12

Add Property::get_proxy() const for read-only proxy, make method const, tweak doc wording

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Daniel Boles requested to merge wip/dboles/property-proxy-const into master Jun 11, 2019
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 1

from #44 (closed)

I think this all can't hurt, and certainly glibmm itself still compiles and tests OK, but in case I didn't think of any weird side-effects this might possibly have, please let me know!


commit 199a6aab97f3a44fc627cddd6cfeb1f477d1ff85 (HEAD -> wip/dboles/property-proxy-const, origin/wip/dboles/property-proxy-const)
Author: Daniel Boles <dboles@src.gnome.org>
Date:   Tue Jun 11 23:25:25 2019 +0100

    Property: Add const get_proxy() returning ReadOnly
    
    We could only get_proxy() if non-const and with a read/write Proxy. This
    resolves that so that we can get a read-only proxy from a const Property
    (without having to construct manually from the instance/name as before).
    
    Close https://gitlab.gnome.org/GNOME/glibmm/issues/44

commit bfe785f44dffd7fcd4457f96b7b927092d08ee55
Author: Daniel Boles <dboles@src.gnome.org>
Date:   Tue Jun 11 23:24:30 2019 +0100

    Property: Getting Proxy from ReadOnly is const too
    
    Thereʼs no need for this to require a non-const Property_ReadOnly as the
    Proxy by definition canʼt modify it, so make it const like other methods

commit 49707a268ce93c6bdb0ca731f9b007ab5fe63cdd
Author: Daniel Boles <dboles@src.gnome.org>
Date:   Tue Jun 11 23:23:36 2019 +0100

    Property: Clarify “manipulate” → read and/or write
Edited Jun 11, 2019 by Daniel Boles
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/dboles/property-proxy-const