Skip to content

Backport !728 “gsocket: Remove (type) annotation from flags arguments” to glib-2-60

Philip Withnall requested to merge pwithnall/glib:backport-728-socket-flags-glib-2-60 into glib-2-60

This is essentially a revert of commit cc7f2f6b. While those flags arguments do accept values of type GSocketMsgFlags, they also accept OS-specific flags which are not defined in GSocketMsgFlags.

The use of (type GSocketMsgFlags) makes language bindings like GJS rightfully assert that values passed in to the argument only contain flags from GSocketMsgFlags, which precludes the use of OS-specific flags, and hence breaks various bits of code.

See gjs#227 (comment 460136) and !710 (comment 460249).

Signed-off-by: Philip Withnall withnall@endlessm.com

Fixes: gjs#227 (closed)

Merge request reports