gdbus-codegen generates invalid header guards when build directory contains a + character
@mcatanzaro
Submitted by Michael Catanzaro Link to original bug (#796189)
Description
I noticed this fun build warning today:
[964/1056] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/UIProcess/API/glib/WebKitWebContext.cpp.o
In file included from ../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.h:29:0,
from DerivedSources/ForwardingHeaders/WebCore/GeolocationProviderGeoclue.h:1,
from ../Source/WebKit/UIProcess/API/glib/WebKitGeolocationProvider.h:24,
from ../Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:40:
DerivedSources/WebCore/Geoclue2Interface.h:8:49: warning: extra tokens at end of #ifndef directive
#ifndef ___BUILDSTREAM_GNOME_CORE_DEPS_WEBKITGTK+_BST__BUILDDIR_DERIVEDSOURCES_WEBCORE_GEOCLUE2INTERFACE_H__
^
DerivedSources/WebCore/Geoclue2Interface.h:9:49: warning: ISO C++11 requires whitespace after the macro name
#define ___BUILDSTREAM_GNOME_CORE_DEPS_WEBKITGTK+_BST__BUILDDIR_DERIVEDSOURCES_WEBCORE_GEOCLUE2INTERFACE_H__
^
Problem is caused by the + in the build directory name. gdbus-codegen should strip that out when generating the file. Probably there are other characters that need to be removed too.
Edited by Christoph Reiter