1. 14 Jun, 2018 1 commit
  2. 13 Jun, 2018 1 commit
    • Arnaud Rebillout's avatar
      gfdonotificationbackend: Fix possible invalid pointer in dbus callback · 57e070f8
      Arnaud Rebillout authored
      The way things were before: a FreedesktopNotification struct is
      allocated before the dbus call, and this same struct is possibly re-used
      for other dbus calls. If the server becomes unavailable, the callback
      will be invoked after the call times out, which leaves a long time where
      other dbus calls can happen, re-using the same FreedesktopNotification
      as user data. When the first call times out, the callback is invoked,
      and the user data is freed. Subsequent calls that used the same user
      data will time out later on, and try to free a pointer that was already
      freed, hence segfaults.
      
      This bug can be reproduced in Cinnamon 3.6.7, as mentioned in:
      <https://github.com/linuxmint/Cinnamon/issues/7491>
      
      This commit fixes that by always allocating a new
      FreedesktopNotification before invoking dbus_call(), ensuring that the
      callback always have a valid user data.
      Signed-off-by: Arnaud Rebillout's avatarArnaud Rebillout <elboulangero@gmail.com>
      57e070f8
  3. 18 Jul, 2017 1 commit
  4. 29 May, 2017 1 commit
  5. 18 Feb, 2017 1 commit
    • Timm Bäder's avatar
      fdo notification: Avoid a double free · 1920b550
      Timm Bäder authored
      We're first getting the notification by its notify_id, but activating
      the action afterwards could redraw it, leading to a dangling pointer.
      Fix this by simply searching the list of active notifications again
      after activating the action.
      1920b550
  6. 07 Dec, 2016 1 commit
  7. 05 Mar, 2015 1 commit
  8. 28 Jun, 2014 1 commit
  9. 31 Jan, 2014 1 commit
  10. 01 Jan, 2014 1 commit
  11. 28 Oct, 2013 1 commit
  12. 21 Oct, 2013 3 commits