1. 09 Jul, 2018 1 commit
  2. 31 May, 2018 1 commit
  3. 25 Apr, 2018 1 commit
  4. 13 Mar, 2018 3 commits
  5. 04 Dec, 2017 1 commit
  6. 28 Nov, 2017 1 commit
  7. 11 Sep, 2017 2 commits
    • Daniel Macks's avatar
      Avoid setting unused variables (-Wself-assign) · b8f9c08a
      Daniel Macks authored
      Setting a variable and then assigning it to itself avoids
      -Wunused-but-set-variable but this specific trick is now caught by
      -Wself-assign. Instead, actually use the value or don't bother
      assigning it at all:
      
      gdbusauthmechanismsha1.c: #ifdef a var decl to match its actual use use
      gdbusauthmechanismsha1.c: call g_ascii_strtoll() in void context
      
      https://bugzilla.gnome.org/show_bug.cgi?id=745723
      b8f9c08a
    • Daniel Macks's avatar
      Avoid setting unused variables (-Wself-assign) · 190f64a0
      Daniel Macks authored
      Setting a variable and then assigning it to itself avoids
      -Wunused-but-set-variable but this specific trick is now caught by
      -Wself-assign. Instead, actually use the value or don't bother
      assigning it at all:
      
      gdbusauth.c: call g_data_input_stream_read_byte() in void context
      gdbusauthmechanismsha1.c: value is actually used
      gdbusmessage.c: use consistent preprocessor-token protection
      gthreadedresolver.c: skip over bytes in data blob
      httpd.c: do something useful with the value
      
      https://bugzilla.gnome.org/show_bug.cgi?id=745723
      190f64a0
  8. 03 Aug, 2017 1 commit
    • Philip Withnall's avatar
      Consistently save errno immediately after the operation setting it · 5cddde1f
      Philip Withnall authored
      Prevent the situation where errno is set by function A, then function B
      is called (which is typically _(), but could be anything else) and it
      overwrites errno, then errno is checked by the caller.
      
      errno is a horrific API, and we need to be careful to save its value as
      soon as a function call (which might set it) returns. i.e. Follow the
      pattern:
        int errsv, ret;
        ret = some_call_which_might_set_errno ();
        errsv = errno;
      
        if (ret < 0)
          puts (strerror (errsv));
      
      This patch implements that pattern throughout GLib. There might be a few
      places in the test code which still use errno directly. They should be
      ported as necessary. It doesn’t modify all the call sites like this:
        if (some_call_which_might_set_errno () && errno == ESOMETHING)
      since the refactoring involved is probably more harmful than beneficial
      there. It does, however, refactor other call sites regardless of whether
      they were originally buggy.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=785577
      5cddde1f
  9. 21 Jun, 2017 1 commit
  10. 29 May, 2017 1 commit
  11. 12 Oct, 2016 1 commit
  12. 31 Jan, 2014 1 commit
  13. 26 Nov, 2013 1 commit
  14. 20 Nov, 2013 1 commit
    • Dan Winship's avatar
      Replace #ifdef HAVE_UNISTD_H checks with #ifdef G_OS_UNIX · 158dde05
      Dan Winship authored
      In Windows development environments that have it, <unistd.h> is mostly
      just a wrapper around several other native headers (in particular,
      <io.h>, which contains read(), close(), etc, and <process.h>, which
      contains getpid()). But given that some Windows dev environments don't
      have <unistd.h>, everything that uses those functions on Windows
      already needed to include the correct Windows header as well, and so
      there is never any point to including <unistd.h> on Windows.
      
      Also, remove some <unistd.h> includes (and a few others) that were
      unnecessary even on unix.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=710519
      158dde05
  15. 24 Jun, 2013 2 commits
  16. 21 May, 2013 1 commit
    • Dan Winship's avatar
      Use 'dumb quotes' rather than `really dumb quotes' · 4b94c083
      Dan Winship authored
      Back in the far-off twentieth century, it was normal on unix
      workstations for U+0060 GRAVE ACCENT to be drawn as "‛" and for U+0027
      APOSTROPHE to be drawn as "’". This led to the convention of using
      them as poor-man's ‛smart quotes’ in ASCII-only text.
      
      However, "'" is now universally drawn as a vertical line, and "`" at a
      45-degree angle, making them an `odd couple' when used together.
      
      Unfortunately, there are lots of very old strings in glib, and also
      lots of new strings in which people have kept up the old tradition,
      perhaps entirely unaware that it used to not look stupid.
      
      Fix this by just using 'dumb quotes' everywhere.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=700746
      4b94c083
  17. 13 Jan, 2013 1 commit
  18. 08 Sep, 2011 1 commit
  19. 15 Apr, 2011 1 commit
  20. 08 Apr, 2011 1 commit
  21. 04 Sep, 2010 1 commit
  22. 28 Aug, 2010 1 commit
  23. 10 Jul, 2010 1 commit
  24. 07 Jul, 2010 1 commit
  25. 22 Jun, 2010 1 commit
  26. 20 May, 2010 1 commit
    • David Zeuthen's avatar
      Bug 619142 – Build fixes · 366b3ffc
      David Zeuthen authored
       - Fix various #include issues
      
       - Change #error to #warning for the EXTERNAL authentication mechanism.
         It is not clear if this should work on Win32 at all.
      
       - Call close() before unlink() for the SHA1 keyring
      
       - Change #error to #warning so we don't forget to do
         permission checking of the .dbus-keyrings directory
      
       - Use Win32 SID for the SHA1 auth mech
      
       - Apparently we can't use word 'interface' as an identifier
      
       - Implement a _g_dbus_win32_get_user_sid() function. For now it's
         private. Don't know if it should be public somewhere. Maybe in
         a future GCredentials support for Win32? I don't know.
      
       - GFileDescriptorBased is not available on Win32. So avoid using
         it in GLocalFile stuff. Now, Win32 still uses GLocalFile + friends
         (which works with file descriptors) so expose a private function
         to get the fd for an OutputStream so things still work.
      
       - Fixup gio.symbols
      
       - Fixup tests/gdbus-peer.c so it builds
      
      With this, at least things compile and the gdbus-peer.exe test case
      passes. Which is a great start. I've tested this by cross-compiling on
      a x86_64 Fedora 13 host using mingw32 and running the code on a 32-bit
      Windows 7 box.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=619142Signed-off-by: default avatarDavid Zeuthen <davidz@redhat.com>
      366b3ffc
  27. 14 May, 2010 1 commit
    • Matthias Clasen's avatar
      Cleanups · 1d22b648
      Matthias Clasen authored
      Sort #includes a bit better, and don't include platform-specific
      headers in gio.h.
      1d22b648
  28. 09 May, 2010 1 commit
  29. 06 May, 2010 3 commits