1. 19 Mar, 2019 4 commits
  2. 17 Mar, 2019 14 commits
    • Emmanuel Fleury's avatar
      Fixing signedness warning in glib/gslice.c · fad04d2e
      Emmanuel Fleury authored
      In file included from glib/glibconfig.h:9,
                       from glib/gslice.c:20:
      glib/gslice.c: In function ‘magazine_cache_trim’:
      glib/gmacros.h:354:25: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
       #define ABS(a)    (((a) < 0) ? -(a) : (a))
                               ^
      glib/gslice.c:643:10: note: in expansion of macro ‘ABS’
         while (ABS (stamp - magazine_chain_uint_stamp (current)) >= allocator->config.working_set_msecs)
                ^~~
      fad04d2e
    • Emmanuel Fleury's avatar
      Fix various signedness warnings in glib/ghash.c · e9f57495
      Emmanuel Fleury authored
      To conform to a better signedness schema, this patch change
      GHashTable.size field from gint to gsize (and change accordingly the
      tests with it).
      e9f57495
    • Emmanuel Fleury's avatar
      Fixing various warnings in glib/gvariant-parser.c · a7aac03e
      Emmanuel Fleury authored
      glib/gvariant-parser.c: In function ‘number_get_value’:
      glib/gvariant-parser.c:1924:46: error: operand of ?: changes signedness from ‘int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare]
             return g_variant_new_int16 (negative ? -((gint16) abs_val) : abs_val);
                                                   ^~~~~~~~~~~~~~~~~~~
      glib/gvariant-parser.c:1934:46: error: operand of ?: changes signedness from ‘int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare]
             return g_variant_new_int32 (negative ? -((gint32) abs_val) : abs_val);
                                                    ^~~~~~~~~~~~~~~~~~~
      glib/gvariant-parser.c:1944:46: error: operand of ?: changes signedness from ‘long int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare]
             return g_variant_new_int64 (negative ? -((gint64) abs_val) : abs_val);
                                                        ^~~~~~~~~~~~~~~~~~~
      glib/gvariant-parser.c:1954:47: error: operand of ?: changes signedness from ‘int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare]
             return g_variant_new_handle (negative ? -((gint32) abs_val) : abs_val);
                                                         ^~~~~~~~~~~~~~~~~~~
      glib/gvariant-parser.c: In function ‘g_variant_parse_error_print_context’:
      glib/gvariant-parser.c:2785:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
             if (point >= strlen (source_str))
                       ^~
      a7aac03e
    • Emmanuel Fleury's avatar
      Fixing various warning in glib/gvarianttypeinfo.c · 357c3db9
      Emmanuel Fleury authored
      glib/gvarianttypeinfo.c:115:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'b' */ { fixed_aligned(1) },   /* boolean */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:117:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'd' */ { fixed_aligned(8) },   /* double */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:120:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'g' */ { unaligned        },   /* signature string */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:121:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'h' */ { fixed_aligned(4) },   /* file handle (int32) */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:122:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'i' */ { fixed_aligned(4) },   /* int32 */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:127:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'n' */ { fixed_aligned(2) },   /* int16 */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:128:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'o' */ { unaligned        },   /* object path string */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:130:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'q' */ { fixed_aligned(2) },   /* uint16 */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:132:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 's' */ { unaligned        },   /* string */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:133:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 't' */ { fixed_aligned(8) },   /* uint64 */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:134:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'u' */ { fixed_aligned(4) },   /* uint32 */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:135:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'v' */ { aligned(8)       },   /* variant */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:137:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'x' */ { fixed_aligned(8) },   /* int64 */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c:138:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers]
         /* 'y' */ { fixed_aligned(1) },   /* byte */
                   ^
      glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here
         guchar container_class;
                ^~~~~~~~~~~~~~~
      glib/gvarianttypeinfo.c: In function ‘tuple_info_free’:
      glib/gvarianttypeinfo.c:368:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
         for (i = 0; i < tuple_info->n_members; i++)
                       ^
      glib/gvarianttypeinfo.c: In function ‘tuple_set_base_info’:
      glib/gvarianttypeinfo.c:641:16: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
             if (m->i == -1 && m->type_info->fixed_size)
                      ^~
      357c3db9
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/gvariant.c · 3f3a7472
      Emmanuel Fleury authored
      glib/gvariant.c: In function ‘g_variant_new_strv’:
      glib/gvariant.c:1563:17: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare]
         for (i = 0; i < length; i++)
                       ^
      glib/gvariant.c: In function ‘g_variant_new_objv’:
      glib/gvariant.c:1699:17: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare]
         for (i = 0; i < length; i++)
                       ^
      glib/gvariant.c: In function ‘g_variant_new_bytestring_array’:
      glib/gvariant.c:1939:17: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare]
         for (i = 0; i < length; i++)
                       ^
      3f3a7472
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/gvariant-core.c · 9023483d
      Emmanuel Fleury authored
      glib/gvariant-core.c: In function ‘g_variant_ensure_size’:
      glib/gvariant-core.c:339:19: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
         if (value->size == (gssize) -1)
                         ^~
      9023483d
    • Emmanuel Fleury's avatar
      Fixing missing initializer in glib/giounix.c · b673ac48
      Emmanuel Fleury authored
                           ^~~
      glib/giounix.c:111:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers]
       };
       ^
      In file included from glib/giochannel.h:33,
                       from glib/glib.h:54,
                       from glib/gprintf.h:21,
                       from glib/gstdio.h:22,
                       from glib/giounix.c:43:
      glib/gmain.h:262:19: note: ‘closure_callback’ declared here
         GSourceFunc     closure_callback;
                         ^~~~~~~~~~~~~~~~
      b673ac48
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/gthread-posix.c · 5dd02cc6
      Emmanuel Fleury authored
      In file included from glib/glibconfig.h:9,
                       from glib/gtypes.h:32,
                       from glib/gatomic.h:27,
                       from glib/gthread.h:32,
                       from glib/gthread-posix.c:42:
      glib/gthread-posix.c: In function ‘g_system_thread_new’:
      glib/gmacros.h:348:26: error: comparison of integer expressions of different signedness: ‘long int’ and ‘gulong’ {aka ‘long unsigned int’} [-Werror=sign-compare]
       #define MAX(a, b)  (((a) > (b)) ? (a) : (b))
                                ^
      glib/gthread-posix.c:1169:22: note: in expansion of macro ‘MAX’
               stack_size = MAX (min_stack_size, stack_size);
                            ^~~
      glib/gmacros.h:348:35: error: operand of ?: changes signedness from ‘long int’ to ‘gulong’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare]
       #define MAX(a, b)  (((a) > (b)) ? (a) : (b))
                                         ^~~
      glib/gthread-posix.c:1169:22: note: in expansion of macro ‘MAX’
               stack_size = MAX (min_stack_size, stack_size);
                            ^~~
      5dd02cc6
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/gtester.c · c3d0440a
      Emmanuel Fleury authored
      glib/gtester.c: In function ‘main’:
      glib/gtester.c:705:19: error: comparison of integer expressions of different signedness: ‘guint’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
         for (ui = 1; ui < argc; ui++)
                         ^
      c3d0440a
    • Emmanuel Fleury's avatar
      Fixing missing initializer in glib-unix.c · 125a1e1f
      Emmanuel Fleury authored
      glib/glib-unix.c:314:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers]
       };
       ^
      In file included from glib/giochannel.h:33,
                       from glib/glib.h:54,
                       from glib/glib-unix.h:33,
                       from glib/glib-unix.c:29:
      glib/gmain.h:262:19: note: ‘closure_callback’ declared here
         GSourceFunc     closure_callback;
                         ^~~~~~~~~~~~~~~~
      125a1e1f
    • Emmanuel Fleury's avatar
      Fixing various warnings in glib/gstring.c · 165a922a
      Emmanuel Fleury authored
      In file included from glib/glibconfig.h:9,
                       from glib/gtypes.h:32,
                       from glib/gstring.h:32,
                       from glib/gstring.c:37:
      glib/gstring.c: In function ‘g_string_insert_len’:
      glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
           g_return_val_if_fail (pos <= string->len, string);
                                     ^~
      glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’
       #define G_LIKELY(expr) (expr)
                               ^~~~
      glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’
           g_return_val_if_fail (pos <= string->len, string);
           ^~~~~~~~~~~~~~~~~~~~
      glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
             if (pos < string->len)
                     ^
      glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare]
             if (offset < pos)
                        ^
      In file included from glib/glibconfig.h:9,
                       from glib/gtypes.h:32,
                       from glib/gstring.h:32,
                       from glib/gstring.c:37:
      glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
       #define MIN(a, b)  (((a) < (b)) ? (a) : (b))
                                ^
      glib/gstring.c:464:22: note: in expansion of macro ‘MIN’
                 precount = MIN (len, pos - offset);
                            ^~~
      glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
       #define MIN(a, b)  (((a) < (b)) ? (a) : (b))
                                         ^~~
      glib/gstring.c:464:22: note: in expansion of macro ‘MIN’
                 precount = MIN (len, pos - offset);
                            ^~~
      glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
             if (len > precount)
                     ^
      glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
             if (pos < string->len)
                     ^
      In file included from glib/glibconfig.h:9,
                       from glib/gtypes.h:32,
                       from glib/gstring.h:32,
                       from glib/gstring.c:37:
      glib/gstring.c: In function ‘g_string_insert_c’:
      glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
           g_return_val_if_fail (pos <= string->len, string);
                                     ^~
      glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’
       #define G_LIKELY(expr) (expr)
                               ^~~~
      glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’
           g_return_val_if_fail (pos <= string->len, string);
           ^~~~~~~~~~~~~~~~~~~~
      glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
         if (pos < string->len)
                 ^
      In file included from glib/glibconfig.h:9,
                       from glib/gtypes.h:32,
                       from glib/gstring.h:32,
                       from glib/gstring.c:37:
      glib/gstring.c: In function ‘g_string_insert_unichar’:
      glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
           g_return_val_if_fail (pos <= string->len, string);
                                     ^~
      glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’
       #define G_LIKELY(expr) (expr)
                               ^~~~
      glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’
           g_return_val_if_fail (pos <= string->len, string);
           ^~~~~~~~~~~~~~~~~~~~
      glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
         if (pos < string->len)
                 ^
      In file included from glib/glibconfig.h:9,
                       from glib/gtypes.h:32,
                       from glib/gstring.h:32,
                       from glib/gstring.c:37:
      glib/gstring.c: In function ‘g_string_erase’:
      glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
         g_return_val_if_fail (pos <= string->len, string);
                                   ^~
      glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’
       #define G_LIKELY(expr) (expr)
                               ^~~~
      glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’
         g_return_val_if_fail (pos <= string->len, string);
         ^~~~~~~~~~~~~~~~~~~~
      glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
             g_return_val_if_fail (pos + len <= string->len, string);
                                             ^~
      glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’
       #define G_LIKELY(expr) (expr)
                               ^~~~
      glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’
             g_return_val_if_fail (pos + len <= string->len, string);
             ^~~~~~~~~~~~~~~~~~~~
      glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
             if (pos + len < string->len)
                           ^
      165a922a
    • Emmanuel Fleury's avatar
      Fixing various warnings in glib/gtimezone.c · 9f44506d
      Emmanuel Fleury authored
      glib/gtimezone.c: In function ‘g_time_zone_unref’:
      glib/gtimezone.c:241:29: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
                 for (idx = 0; idx < tz->t_info->len; idx++)
                                   ^
      In file included from glib/glibconfig.h:9,
                       from glib/gtypes.h:32,
                       from glib/gtimezone.h:27,
                       from glib/gtimezone.c:24:
      glib/gtimezone.c: In function ‘init_zone_from_iana_info’:
      glib/gtimezone.c:578:34: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
             g_assert (trans.info_index < gtz->t_info->len);
                                        ^
      glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’
       #define G_LIKELY(expr) (expr)
                               ^~~~
      glib/gtimezone.c:578:7: note: in expansion of macro ‘g_assert’
             g_assert (trans.info_index < gtz->t_info->len);
             ^~~~~~~~
      glib/gtimezone.c: In function ‘find_relative_date’:
      glib/gtimezone.c:859:22: error: comparison of integer expressions of different signedness: ‘GDateWeekday’ {aka ‘enum <anonymous>’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare]
             if (first_wday > wday)
                            ^
      glib/gtimezone.c: In function ‘init_zone_from_rules’:
      glib/gtimezone.c:938:19: error: comparison of integer expressions of different signedness: ‘guint’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
         for (ri = 0; ri < rules_num - 1; ri++)
                         ^
      glib/gtimezone.c:958:19: error: comparison of integer expressions of different signedness: ‘guint’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
         for (ri = 0; ri < rules_num - 1; ri++)
                         ^
      glib/gtimezone.c: In function ‘g_time_zone_adjust_time’:
      glib/gtimezone.c:1792:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
         for (i = 0; i <= intervals; i++)
                       ^~
      glib/gtimezone.c:1825:39: error: comparison of integer expressions of different signedness: ‘gboolean’ {aka ‘int’} and ‘GTimeType’ {aka ‘enum <anonymous>’} [-Werror=sign-compare]
             else if (interval_isdst (tz, i) != type)
                                             ^~
      glib/gtimezone.c:1832:22: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
                 else if (i < intervals &&
                            ^
      glib/gtimezone.c: In function ‘g_time_zone_find_interval’:
      glib/gtimezone.c:1881:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
         for (i = 0; i <= intervals; i++)
                       ^~
      glib/gtimezone.c:1900:35: error: comparison of integer expressions of different signedness: ‘gboolean’ {aka ‘int’} and ‘GTimeType’ {aka ‘enum <anonymous>’} [-Werror=sign-compare]
         else if (interval_isdst (tz, i) != type)
                                         ^~
      glib/gtimezone.c:1905:18: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
             else if (i < intervals && time_ >= interval_local_start (tz, i + 1))
                        ^
      9f44506d
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/gtestutils.c · 99d32c28
      Emmanuel Fleury authored
      glib/gtestutils.c: In function ‘g_test_build_filename_va’:
      glib/gtestutils.c:3865:49: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘long unsigned int’ [-Werror=sign-compare]
         for (num_path_segments = 2; num_path_segments < G_N_ELEMENTS (pathv); num_path_segments++)
                                                       ^
      99d32c28
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/gthreadpool.c · 179dbbde
      Emmanuel Fleury authored
      glib/gthreadpool.c: In function ‘g_thread_pool_wait_for_new_pool’:
      glib/gthreadpool.c:157:46: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
             if (g_atomic_int_get (&unused_threads) >= local_max_unused_threads)
                                                    ^~
      glib/gthreadpool.c: In function ‘g_thread_pool_wakeup_and_stop_all’:
      glib/gthreadpool.c:836:17: error: comparison of integer expressions of different signedness: ‘guint’ {aka ‘unsigned int’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare]
         for (i = 0; i < pool->num_threads; i++)
                       ^
      179dbbde
  3. 16 Mar, 2019 2 commits
    • LRN's avatar
      GIO: Convert ENOTSOCK to G_IO_ERROR_INVALID_ARGUMENT · 5df0337f
      LRN authored
      instead of using a generic G_IO_ERROR_FAILED error code.
      This is in line with what W32 part of the code is doing with WSAENOTSOCK.
      
      This fix will break two tests in libsoup, which were written following
      the implementation and thus expect G_IO_ERROR_FAILED when attempting to
      do stuff with no-longer-valid socket descriptors.
      5df0337f
    • Emmanuele Bassi's avatar
      Revert "headers: Add various missing G_DISABLE_DEPRECATED guards" · e5ba5845
      Emmanuele Bassi authored
      This reverts commit 80fcb1bc.
      
      G_DISABLE_DEPRECATED should never be used by anybody, least of all by
      GLib. We have deprecation annotations for the compiler, these days, and
      they are much better suited than a macro that makes symbols appear and
      disappear. The fact that gtk-doc doesn't understand the deprecation
      annotations is a limitation of gtk-doc, and it's gtk-doc that ought to be
      fixed.
      
      Commit 80fcb1bc broke GStreamer, which disables old API that was
      deprecated before the introduction of the deprecation annotations, but
      still uses newly deprecated one, and relies on the deprecation
      annotations to do their thing. It also broke libsoup, as it uses
      GValueArray in its own API.
      e5ba5845
  4. 15 Mar, 2019 20 commits
    • Emmanuel Fleury's avatar
      Fixing signedness problem in glib/gstrfuncs.c · 592d4369
      Emmanuel Fleury authored
      glib/gstrfuncs.c: In function ‘g_strstr_len’:
      glib/gstrfuncs.c:2709:24: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
             if (haystack_len < needle_len)
                              ^
      592d4369
    • Emmanuel Fleury's avatar
      Fixing various warnings in glib/gmain.c · 81a4698c
      Emmanuel Fleury authored
      glib/gmain.c:480:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers]
       };
       ^
      In file included from glib/giochannel.h:33,
                       from glib/glib.h:54,
                       from glib/glib-unix.h:33,
                       from glib/gmain.c:50:
      glib/gmain.h:262:19: note: ‘closure_callback’ declared here
         GSourceFunc     closure_callback;
                         ^~~~~~~~~~~~~~~~
      glib/gmain.c:491:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers]
       };
       ^
      In file included from glib/giochannel.h:33,
                       from glib/glib.h:54,
                       from glib/glib-unix.h:33,
                       from glib/gmain.c:50:
      glib/gmain.h:262:19: note: ‘closure_callback’ declared here
         GSourceFunc     closure_callback;
                         ^~~~~~~~~~~~~~~~
      glib/gmain.c:499:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers]
       };
       ^
      In file included from glib/giochannel.h:33,
                       from glib/glib.h:54,
                       from glib/glib-unix.h:33,
                       from glib/gmain.c:50:
      glib/gmain.h:262:19: note: ‘closure_callback’ declared here
         GSourceFunc     closure_callback;
                         ^~~~~~~~~~~~~~~~
      glib/gmain.c:507:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers]
       };
       ^
      In file included from glib/giochannel.h:33,
                       from glib/glib.h:54,
                       from glib/glib-unix.h:33,
                       from glib/gmain.c:50:
      glib/gmain.h:262:19: note: ‘closure_callback’ declared here
         GSourceFunc     closure_callback;
                         ^~~~~~~~~~~~~~~~
      glib/gmain.c: In function ‘g_source_set_callback_indirect’:
      glib/gmain.c:1615:68: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body]
                                                     callback_funcs->get));
                                                                          ^
      81a4698c
    • Emmanuel Fleury's avatar
      Fixing missing initializer for field in gscanner.c · 9eb4fcde
      Emmanuel Fleury authored
      glib/gscanner.c:344:1: error: missing initializer for field ‘padding_dummy’ of ‘GScannerConfig’ {aka ‘const struct _GScannerConfig’} [-Werror=missing-field-initializers]
       };
       ^
      In file included from glib/gscanner.c:40:
      glib/gscanner.h:166:10: note: ‘padding_dummy’ declared here
         guint  padding_dummy;
                ^~~~~~~~~~~~~
      9eb4fcde
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/goptions.c · aef59ca7
      Emmanuel Fleury authored
      glib/goption.c: In function ‘context_has_h_entry’:
      glib/goption.c:785:21: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare]
             for (i = 0; i < context->main_group->n_entries; i++)
                           ^
      glib/goption.c:797:21: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare]
             for (i = 0; i < group->n_entries; i++)
                           ^
      aef59ca7
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/gmarkup.c · 4eed83a0
      Emmanuel Fleury authored
      In file included from glib/glibconfig.h:9,
                       from ../glib.git/glib/gtypes.h:32,
                       from ../glib.git/glib/gquark.h:32,
                       from ../glib.git/glib/gerror.h:28,
                       from ../glib.git/glib/gmarkup.h:28,
                       from ../glib.git/glib/gmarkup.c:28:
      ../glib.git/glib/gmarkup.c: In function ‘unescape_gstring_inplace’:
      ../glib.git/glib/gmarkup.c:789:30: error: comparison of integer expressions of different signedness: ‘long int’ and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
         g_assert (to - string->str <= string->len);
                                    ^~
      ../glib.git/glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’
       #define G_LIKELY(expr) (expr)
                               ^~~~
      ../glib.git/glib/gmarkup.c:789:3: note: in expansion of macro ‘g_assert’
         g_assert (to - string->str <= string->len);
         ^~~~~~~~
      ../glib.git/glib/gmarkup.c:790:24: error: comparison of integer expressions of different signedness: ‘long int’ and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
         if (to - string->str != string->len)
                              ^~
      ../glib.git/glib/gmarkup.c: In function ‘g_markup_parse_boolean’:
      ../glib.git/glib/gmarkup.c:2634:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
         for (i = 0; i < G_N_ELEMENTS (falses); i++)
                       ^
      ../glib.git/glib/gmarkup.c:2645:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
         for (i = 0; i < G_N_ELEMENTS (trues); i++)
                       ^
      4eed83a0
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/gquark.c · f58702eb
      Emmanuel Fleury authored
      glib/gquark.c: In function ‘g_quark_to_string’:
      glib/gquark.c:268:13: error: comparison of integer expressions of different signedness: ‘GQuark’ {aka ‘unsigned int’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare]
         if (quark < seq_id)
                   ^
      f58702eb
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/gprimes.c · d7ddf669
      Emmanuel Fleury authored
      glib/gprimes.c: In function ‘g_spaced_primes_closest’:
      glib/gprimes.c:91:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘long unsigned int’ [-Werror=sign-compare]
         for (i = 0; i < G_N_ELEMENTS (g_primes); i++)
                       ^
      d7ddf669
    • Emmanuel Fleury's avatar
      Fix signedness in glib/gmappedfile.c · 8eae303d
      Emmanuel Fleury authored
      glib/gmappedfile.c: In function ‘mapped_file_new_from_fd’:
      glib/gmappedfile.c:153:18: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
         if (st.st_size > G_MAXSIZE)
                        ^
      8eae303d
    • Emmanuel Fleury's avatar
      Fixing signedness in glib/giochannel.c · 2f9e6e97
      Emmanuel Fleury authored
      In file included from glib/glibconfig.h:9,
                       from glib/gtypes.h:32,
                       from glib/gquark.h:32,
                       from glib/gerror.h:28,
                       from glib/gconvert.h:32,
                       from glib/giochannel.h:32,
                       from glib/giochannel.c:37:
      glib/giochannel.c: In function ‘g_io_channel_write_chars’:
      glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare]
       #define MIN(a, b)  (((a) < (b)) ? (a) : (b))
                                ^
      glib/giochannel.c:2285:31: note: in expansion of macro ‘MIN’
                 gssize write_this = MIN (space_in_buf, count - wrote_bytes);
                                     ^~~
      glib/gmacros.h:351:41: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘gsize’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare]
       #define MIN(a, b)  (((a) < (b)) ? (a) : (b))
                                               ^~~
      glib/giochannel.c:2285:31: note: in expansion of macro ‘MIN’
                 gssize write_this = MIN (space_in_buf, count - wrote_bytes);
                                     ^~~
      glib/giochannel.c:2415:41: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
                               g_assert (count == from_buf_len - from_buf_old_len);
                                               ^~
      glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’
       #define G_LIKELY(expr) (expr)
                               ^~~~
      glib/giochannel.c:2415:25: note: in expansion of macro ‘g_assert’
                               g_assert (count == from_buf_len - from_buf_old_len);
                               ^~~~~~~~
      2f9e6e97
    • Emmanuel Fleury's avatar
    • Philip Withnall's avatar
    • Philip Withnall's avatar
    • Philip Withnall's avatar
      tests: Compile the test_unix_address() test unconditionally · 3cd30c59
      Philip Withnall authored
      Just skip the test if the unix transport isn’t supported. This means we
      get better compilation coverage, and more explicit TAP output saying
      that the test is being skipped on unsupported platforms.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      3cd30c59
    • Philip Withnall's avatar
    • Philip Withnall's avatar
    • Philip Withnall's avatar
      tests: Split out D-Bus address parsing tests · e0561cfd
      Philip Withnall authored
      Rather than having them in the unix-transport specific tests.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      e0561cfd
    • Philip Withnall's avatar
      tests: Always check an address is valid before checking it’s supported · 685d6058
      Philip Withnall authored
      This gets us extra test coverage for free.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      685d6058
    • Philip Withnall's avatar
      gdbusaddress: Clean up memory management in _g_dbus_address_parse_entry() · e458b016
      Philip Withnall authored
      This introduces no functional changes.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      e458b016
    • Philip Withnall's avatar
      gdbusaddress: Require that transport names and keys are non-empty · 131ba661
      Philip Withnall authored
      The specification doesn’t explicitly say this, but it doesn’t say
      otherwise, and it would be pretty weird to have an empty transport name
      or key.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      131ba661
    • Philip Withnall's avatar
      gdbusaddress: Remove some always-true branches · 8966b0f8
      Philip Withnall authored
      g_strsplit() can never return NULL.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      8966b0f8