1. 15 Mar, 2019 5 commits
  2. 14 Mar, 2019 2 commits
  3. 13 Mar, 2019 12 commits
  4. 12 Mar, 2019 5 commits
    • Vasily Galkin's avatar
      gtestutils: fix typo in message when stdout is wrong · 2d24ea94
      Vasily Galkin authored
      "stderr was" -> "stdout was"
      2d24ea94
    • Vasily Galkin's avatar
      gdbus, tests, win32: test session dbus autolaunch · b245344c
      Vasily Galkin authored
      The test performs implicit autolaunching of a bus
      and checks if it is connectible.
      
      In build the test is moved from "only non-windows with have_dbus_daemon"
      to "anywhere".
      
      This is intentional: actually it doesn't execute any external
      binaries on unix (so doesn't require dbus_daemon)
      and now has win32 implementation.
      
      The test has some problems that are not problems of test itself,
      but are reasoned by current win32 implementation:
      
       - since the implementation uses global win32 kernel objects
      with fixed names not depending on g_get_user_runtime_dir or other context
      if preexisting bus running by some other libgio-using application
      the test would silently pass.
      
       - since the implementation uses problematic time-based synchronization,
      that has a race condition between opening and reading mmaped address,
      the test may randomly fail (I'd not seen this in practice).
      
       - since the implementation autolaunched process works for 3 seconds
      after last client disconnects, the executed subprocess runs for 3 seconds
      after test exit, maybe locking the libgio-2.0-0.dll file for that time.
      b245344c
    • Vasily Galkin's avatar
      gdbus, tests: rename gdbus-unix-addresses test to gdbus-address-get-session · b1f7c22a
      Vasily Galkin authored
      In preparation of adding non-unix testcase to the test.
      b1f7c22a
    • Vasily Galkin's avatar
      gdbus, win32: autolaunch bus with gdbus.exe instead of rundll32 · 8c7670f0
      Vasily Galkin authored
      This is a bit of breaking change:
      After this commit the apps relying of win32 dbus autolaunching,
      need to install gdbus.exe alongside with libgio-2.0-0.dll.
      
      A new command for gdbus tool is used for running server:
      gdbus.exe _win32_run_session_bus
      
      To implement it gdbus.exe uses the same exported function
      g_win32_run_session_bus that earlier was used by rundll.
      So (private) ABI was not changed.
      
      It runs the bus syncronously, exiting after inactivity timeout -
      all exactly like it was runed earlier with the help of rundll32.
      
      While private exported function may have _some_
      version compatibility issues between gdbus.exe and libgio-2.0-0.dll
      compiling dbus server registration logic directly into gdbus.exe
      can lead to _more hidden and more complex_ compatibility issues
      since the names and behaviour of syncronization objects
      used to publish server address would be required compatible between
      gdbus.exe and libgio-2.0-0.dll.
      
      So using "private" exported function to call
      looks like more safe behaviour.
      
      gdbus.exe binary was selected for this task since
      it has corresponding name and at least for msys2 is shippied
      in same package with libgio-2.0-0.dll
      
      turn_off_the_starting_cursor function is also kept as is,
      however it is not obvious if it is still needed
      (by now I failed reproducing original issue).
      
      Explicit g_warnings added to help with possible
      problematic cases for absent or incompatible gdbus.exe
      
      Mainloop is created after successful daemon creation
      Before this change the function leaked mainloop on daemon creation fail
      8c7670f0
    • Antonio Larrosa's avatar
      Handle an UNKNOWN NetworkManager connectivity as NONE · 2932a58c
      Antonio Larrosa authored
      nm_conn_to_g_conn already handles UNKNOWN like NONE (returning
      G_NETWORK_CONNECTIVITY_LOCAL in both cases). So in sync_properties
      we should also set new_connectivity to G_NETWORK_CONNECTIVITY_LOCAL
      for both NM_CONNECTIVITY_UNKNOWN and NM_CONNECTIVITY_NONE.
      
      This has the added benefit that when NetworkManager returns the network
      connectivity is UNKNOWN, we set network_available to FALSE as it should
      be. Previously, there were cases in a laptop with no network access,
      that g_network_monitor_get_network_available returned true, which was
      wrong and is also fixed with this commit.
      2932a58c
  5. 10 Mar, 2019 1 commit
  6. 08 Mar, 2019 15 commits