1. 25 Jan, 2019 1 commit
  2. 20 Dec, 2018 1 commit
    • Cosimo Cecchi's avatar
      gdbusproxy: only connect to NameOwnerChanged for message buses · dec0a687
      Cosimo Cecchi authored
      Names are a message bus feature, so it does not make sense to connect
      to NameOwnerChanged when the underlying connection is not a message
      bus.
      
      Moreover, g_dbus_connection_signal_subscribe() will also enforce that
      condition. Adding this extra check here is helpful to avoid a critical
      warning when using GDBusProxy with peer-to-peer connections.
      
      #1620
      dec0a687
  3. 10 Nov, 2018 1 commit
    • Cosimo Cecchi's avatar
      gdbusproxy: make g-name-owner property useful with unique names · 47be0f7a
      Cosimo Cecchi authored
      Currently, GDBusProxy:g-name-owner only notifies changes to the unique
      name owner of the remote object in case the proxy was constructed for a
      well-known name.
      That sounds like an artificial restriction, and it's convenient to
      connect to notify::g-name-owner if a proxy instance has already been
      created for an unique name, instead of additionally using
      g_bus_watch_name() to track the owner.
      
      To fix this, always connect to NameOwnerChanged after the proxy is
      initialized, instead of only doing so when the proxy was constructed for
      a well-known name.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=791316
      GNOME/glib#1310
      47be0f7a
  4. 08 Oct, 2018 1 commit
  5. 12 Sep, 2018 1 commit
  6. 25 Apr, 2018 1 commit
  7. 12 Feb, 2018 1 commit
  8. 11 Jan, 2018 1 commit
  9. 29 May, 2017 1 commit
  10. 27 Mar, 2017 1 commit
  11. 22 Nov, 2016 1 commit
  12. 29 Jun, 2016 1 commit
  13. 15 Jun, 2016 1 commit
    • Hans Petter Jansson's avatar
      GDbusProxy: Plug memory leak. · ae048625
      Hans Petter Jansson authored
      proxy->priv->name_owner gets overwritten in async_init_data_set_name_owner() on the
      assumption that it will always be NULL when we get there. However,
      on_name_owner_changed() can run first, and it does set name_owner.
      
      ==20126== 42 bytes in 6 blocks are definitely lost in loss record 15,174 of 48,256
      ==20126==    at 0x4C280F3: malloc (vg_replace_malloc.c:299)
      ==20126==    by 0x7541D00: g_malloc (gmem.c:104)
      ==20126==    by 0x7558FEE: g_strdup (gstrfuncs.c:364)
      ==20126==    by 0x6DF8E4F: on_name_owner_changed (gdbusproxy.c:1399)
      ==20126==    by 0x6DE94C4: emit_signal_instance_in_idle_cb (gdbusconnection.c:3743)
      ==20126==    by 0x753C315: g_main_dispatch (gmain.c:3066)
      ==20126==    by 0x753C315: g_main_context_dispatch (gmain.c:3642)
      ==20126==    by 0x753C667: g_main_context_iterate.isra.24 (gmain.c:3713)
      ==20126==    by 0x753CA69: g_main_loop_run (gmain.c:3907)
      ==20126==    by 0x5E38000: meta_run (main.c:556)
      ==20126==    by 0x401EC0: main (main.c:441)
      
      https://bugzilla.gnome.org/show_bug.cgi?id=755439
      ae048625
  14. 25 Nov, 2015 1 commit
  15. 12 Sep, 2015 1 commit
  16. 07 Apr, 2015 1 commit
  17. 04 Apr, 2015 1 commit
  18. 08 Feb, 2014 2 commits
  19. 06 Feb, 2014 3 commits
  20. 01 Feb, 2014 5 commits
  21. 31 Jan, 2014 1 commit
  22. 04 Oct, 2013 1 commit
  23. 24 Jun, 2013 2 commits
  24. 21 May, 2013 1 commit
    • Dan Winship's avatar
      Use 'dumb quotes' rather than `really dumb quotes' · 4b94c083
      Dan Winship authored
      Back in the far-off twentieth century, it was normal on unix
      workstations for U+0060 GRAVE ACCENT to be drawn as "‛" and for U+0027
      APOSTROPHE to be drawn as "’". This led to the convention of using
      them as poor-man's ‛smart quotes’ in ASCII-only text.
      
      However, "'" is now universally drawn as a vertical line, and "`" at a
      45-degree angle, making them an `odd couple' when used together.
      
      Unfortunately, there are lots of very old strings in glib, and also
      lots of new strings in which people have kept up the old tradition,
      perhaps entirely unaware that it used to not look stupid.
      
      Fix this by just using 'dumb quotes' everywhere.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=700746
      4b94c083
  25. 08 Jun, 2012 1 commit
  26. 31 Mar, 2012 1 commit
  27. 19 Mar, 2012 2 commits
  28. 15 Mar, 2012 1 commit
  29. 24 Feb, 2012 1 commit
  30. 21 Feb, 2012 1 commit
  31. 08 Feb, 2012 1 commit